Browse Source

Changed the order of default positions used by BalloonPanelView#attachTo for better positioning flexibility of the UI.

Aleksander Nowodzinski 5 years ago
parent
commit
91c9b63cfc

+ 4 - 4
packages/ckeditor5-ui/src/panel/balloon/balloonpanelview.js

@@ -224,15 +224,15 @@ export default class BalloonPanelView extends View {
 			element: this.element,
 			element: this.element,
 			positions: [
 			positions: [
 				defaultPositions.southArrowNorth,
 				defaultPositions.southArrowNorth,
-				defaultPositions.southArrowNorthWest,
-				defaultPositions.southArrowNorthEast,
 				defaultPositions.southArrowNorthMiddleWest,
 				defaultPositions.southArrowNorthMiddleWest,
 				defaultPositions.southArrowNorthMiddleEast,
 				defaultPositions.southArrowNorthMiddleEast,
+				defaultPositions.southArrowNorthWest,
+				defaultPositions.southArrowNorthEast,
 				defaultPositions.northArrowSouth,
 				defaultPositions.northArrowSouth,
-				defaultPositions.northArrowSouthWest,
-				defaultPositions.northArrowSouthEast,
 				defaultPositions.northArrowSouthMiddleWest,
 				defaultPositions.northArrowSouthMiddleWest,
 				defaultPositions.northArrowSouthMiddleEast,
 				defaultPositions.northArrowSouthMiddleEast,
+				defaultPositions.northArrowSouthWest,
+				defaultPositions.northArrowSouthEast,
 			],
 			],
 			limiter: defaultLimiterElement,
 			limiter: defaultLimiterElement,
 			fitInViewport: true
 			fitInViewport: true

+ 6 - 6
packages/ckeditor5-ui/tests/panel/balloon/balloonpanelview.js

@@ -181,15 +181,15 @@ describe( 'BalloonPanelView', () => {
 				target,
 				target,
 				positions: [
 				positions: [
 					BalloonPanelView.defaultPositions.southArrowNorth,
 					BalloonPanelView.defaultPositions.southArrowNorth,
-					BalloonPanelView.defaultPositions.southArrowNorthWest,
-					BalloonPanelView.defaultPositions.southArrowNorthEast,
 					BalloonPanelView.defaultPositions.southArrowNorthMiddleWest,
 					BalloonPanelView.defaultPositions.southArrowNorthMiddleWest,
 					BalloonPanelView.defaultPositions.southArrowNorthMiddleEast,
 					BalloonPanelView.defaultPositions.southArrowNorthMiddleEast,
+					BalloonPanelView.defaultPositions.southArrowNorthWest,
+					BalloonPanelView.defaultPositions.southArrowNorthEast,
 					BalloonPanelView.defaultPositions.northArrowSouth,
 					BalloonPanelView.defaultPositions.northArrowSouth,
-					BalloonPanelView.defaultPositions.northArrowSouthWest,
-					BalloonPanelView.defaultPositions.northArrowSouthEast,
 					BalloonPanelView.defaultPositions.northArrowSouthMiddleWest,
 					BalloonPanelView.defaultPositions.northArrowSouthMiddleWest,
 					BalloonPanelView.defaultPositions.northArrowSouthMiddleEast,
 					BalloonPanelView.defaultPositions.northArrowSouthMiddleEast,
+					BalloonPanelView.defaultPositions.northArrowSouthWest,
+					BalloonPanelView.defaultPositions.northArrowSouthEast,
 				],
 				],
 				limiter: document.body,
 				limiter: document.body,
 				fitInViewport: true
 				fitInViewport: true
@@ -271,7 +271,7 @@ describe( 'BalloonPanelView', () => {
 
 
 				view.attachTo( { target, limiter } );
 				view.attachTo( { target, limiter } );
 
 
-				expect( view.position ).to.equal( 'arrow_sw' );
+				expect( view.position ).to.equal( 'arrow_smw' );
 			} );
 			} );
 
 
 			it( 'should put balloon on the `north west` side of the target element when ' +
 			it( 'should put balloon on the `north west` side of the target element when ' +
@@ -412,7 +412,7 @@ describe( 'BalloonPanelView', () => {
 
 
 				view.attachTo( { target, limiter } );
 				view.attachTo( { target, limiter } );
 
 
-				expect( view.position ).to.equal( 'arrow_sw' );
+				expect( view.position ).to.equal( 'arrow_smw' );
 			} );
 			} );
 
 
 			it( 'should put balloon on the `south east` position when `north east` is limited', () => {
 			it( 'should put balloon on the `south east` position when `north east` is limited', () => {