Ver Fonte

Small fix in FocusObserver test.

Szymon Kupś há 8 anos atrás
pai
commit
8fc57cb238

+ 3 - 4
packages/ckeditor5-engine/tests/view/observer/focusobserver.js

@@ -178,7 +178,7 @@ describe( 'FocusObserver', () => {
 			const selectionChangeSpy = sinon.spy();
 			const renderSpy = sinon.spy();
 
-			setData( viewDocument, '<div contenteditable="true">{}foo bar</div>' );
+			setData( viewDocument, '<div contenteditable="true">foo bar</div>' );
 			viewDocument.render();
 			const domEditable = domRoot.childNodes[ 0 ];
 
@@ -186,14 +186,13 @@ describe( 'FocusObserver', () => {
 			viewDocument.on( 'render', renderSpy, { priority: 'low' } );
 
 			viewDocument.on( 'render', () => {
+				sinon.assert.notCalled( selectionChangeSpy );
 				sinon.assert.called( renderSpy );
+
 				done();
 			}, { priority: 'low' } );
 
 			observer.onDomEvent( { type: 'focus', target: domEditable } );
-
-			// Selection will land in the same place so no native selectionchange event.
-			domSelection.collapse( domEditable );
 		} );
 	} );
 } );

+ 4 - 7
packages/ckeditor5-engine/tests/view/observer/selectionobserver.js

@@ -3,6 +3,8 @@
  * For licensing, see LICENSE.md.
  */
 
+/* globals setTimeout, setInterval, clearInterval, document */
+
 import ViewRange from '../../../src/view/range';
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
 import ViewSelection from '../../../src/view/selection';
@@ -11,20 +13,15 @@ import SelectionObserver from '../../../src/view/observer/selectionobserver';
 import MutationObserver from '../../../src/view/observer/mutationobserver';
 import FocusObserver from '../../../src/view/observer/focusobserver';
 import log from '@ckeditor/ckeditor5-utils/src/log';
-import global from '@ckeditor/ckeditor5-utils/src/dom/global';
 import { parse } from '../../../src/dev-utils/view';
 
-const setTimeout = global.window.setTimeout;
-const setInterval = global.window.setInterval;
-const clearInterval = global.window.clearInterval;
-const domDocument = global.document;
-
 testUtils.createSinonSandbox();
 
 describe( 'SelectionObserver', () => {
-	let viewDocument, viewRoot, mutationObserver, selectionObserver, domRoot, domMain;
+	let viewDocument, viewRoot, mutationObserver, selectionObserver, domRoot, domMain, domDocument;
 
 	beforeEach( ( done ) => {
+		domDocument = document;
 		domRoot = domDocument.createElement( 'div' );
 		domRoot.innerHTML = `<div contenteditable="true"></div><div contenteditable="true" id="additional"></div>`;
 		domMain = domRoot.childNodes[ 0 ];