瀏覽代碼

Other (widget): `WidgetResize#getResizerByViewElement()` is now a public method.

Marek Lewandowski 5 年之前
父節點
當前提交
8f26321247

+ 1 - 1
packages/ckeditor5-image/src/imageresize/imageresizehandles.js

@@ -58,7 +58,7 @@ export default class ImageResizeHandles extends Plugin {
 		editingView.document.on( 'imageLoaded', ( evt, domEvent ) => {
 			const imageView = editor.editing.view.domConverter.domToView( domEvent.target );
 			const widgetView = imageView.findAncestor( 'figure' );
-			let resizer = this.editor.plugins.get( WidgetResize )._getResizerByViewElement( widgetView );
+			let resizer = this.editor.plugins.get( WidgetResize ).getResizerByViewElement( widgetView );
 
 			if ( resizer ) {
 				// There are rare cases when image will be triggered multiple times for the same widget, e.g. when

+ 1 - 1
packages/ckeditor5-image/tests/imageresize/imageresizehandles.js

@@ -451,7 +451,7 @@ describe( 'ImageResizeHandles', () => {
 	}
 
 	function getSelectedImageResizer( editor ) {
-		return editor.plugins.get( 'WidgetResize' )._getResizerByViewElement(
+		return editor.plugins.get( 'WidgetResize' ).getResizerByViewElement(
 			editor.editing.view.document.selection.getSelectedElement()
 		);
 	}

+ 12 - 13
packages/ckeditor5-widget/src/widgetresize.js

@@ -103,7 +103,7 @@ export default class WidgetResize extends Plugin {
 		viewSelection.on( 'change', () => {
 			const selectedElement = viewSelection.getSelectedElement();
 
-			this.visibleResizer = this._getResizerByViewElement( selectedElement ) || null;
+			this.visibleResizer = this.getResizerByViewElement( selectedElement ) || null;
 		} );
 	}
 
@@ -153,7 +153,7 @@ export default class WidgetResize extends Plugin {
 
 		// It could be that the element the resizer is created for is currently focused. In that
 		// case it should become visible.
-		if ( this._getResizerByViewElement( selectedElement ) == resizer ) {
+		if ( this.getResizerByViewElement( selectedElement ) == resizer ) {
 			this.visibleResizer = resizer;
 		}
 
@@ -161,6 +161,16 @@ export default class WidgetResize extends Plugin {
 	}
 
 	/**
+	 * Returns a resizer created for a given view element (widget element).
+	 *
+	 * @param {module:engine/view/containerelement~ContainerElement} viewElement View element associated with the resizer.
+	 * @returns {module:widget/widgetresize/resizer~Resizer/undefined}
+	 */
+	getResizerByViewElement( viewElement ) {
+		return this._resizers.get( viewElement );
+	}
+
+	/**
 	 * Returns a resizer that contains a given resize handle.
 	 *
 	 * @protected
@@ -176,17 +186,6 @@ export default class WidgetResize extends Plugin {
 	}
 
 	/**
-	 * Returns a resizer created for a given view element (widget element).
-	 *
-	 * @protected
-	 * @param {module:engine/view/containerelement~ContainerElement} viewElement
-	 * @returns {module:widget/widgetresize/resizer~Resizer}
-	 */
-	_getResizerByViewElement( viewElement ) {
-		return this._resizers.get( viewElement );
-	}
-
-	/**
 	 * @protected
 	 * @param {module:utils/eventinfo~EventInfo} event
 	 * @param {Event} domEventData Native DOM event.