8
0
Эх сурвалжийг харах

Add info about follow-ups to the code & comments cleanup.

Maciej Gołaszewski 5 жил өмнө
parent
commit
8ba179182a

+ 0 - 6
packages/ckeditor5-engine/src/model/differ.js

@@ -145,7 +145,6 @@ export default class Differ {
 
 		this._markRefresh( item.parent, item.startOffset, item.offsetSize );
 
-		// @todo: Probably makes sense - check later.
 		const range = Range._createOn( item );
 
 		for ( const marker of this._markerCollection.getMarkersIntersectingRange( range ) ) {
@@ -185,8 +184,6 @@ export default class Differ {
 			case 'removeAttribute':
 			case 'changeAttribute': {
 				for ( const item of operation.range.getItems( { shallow: true } ) ) {
-					// Attribute change on refreshed element is ignored
-					// TODO: this is wrong if attribute would be handled elsewhere: || this._isInRefreshedElement( item )
 					if ( this._isInInsertedElement( item.parent ) || this._isInRefreshedElement( item ) ) {
 						continue;
 					}
@@ -450,9 +447,6 @@ export default class Differ {
 			let i = 0; // Iterator in `elementChildren` array -- iterates through current children of element.
 			let j = 0; // Iterator in `snapshotChildren` array -- iterates through old children of element.
 
-			// console.log( changes.map( change => change.type ) );
-			// console.log( 'actions', actions, elementChildren.length );
-
 			// Process every action.
 			for ( const action of actions ) {
 				if ( action === 'i' ) {

+ 1 - 0
packages/ckeditor5-table/src/converters/table-heading-rows-refresh-post-fixer.js

@@ -44,6 +44,7 @@ function tableHeadingRowsRefreshPostFixer( model ) {
 		// @if CK_DEBUG_TABLE // console.log( `Post-fixing table: refreshing heading rows (${ tablesToRefresh.size }).` );
 
 		for ( const table of tablesToRefresh.values() ) {
+			// Should be handled by a `triggerBy` configuration. See: https://github.com/ckeditor/ckeditor5/issues/8138.
 			differ.reInsertItem( table );
 		}