8
0
Просмотр исходного кода

Other: Removed dummy `ck-enabled` class.

Maciej Gołaszewski 7 лет назад
Родитель
Сommit
8b81365d91

+ 1 - 1
packages/ckeditor5-ui/src/button/buttonview.js

@@ -118,7 +118,7 @@ export default class ButtonView extends View {
 				class: [
 					'ck',
 					'ck-button',
-					bind.to( 'isEnabled', value => value ? 'ck-enabled' : 'ck-disabled' ),
+					bind.if( 'isEnabled', 'ck-disabled', value => !value ),
 					bind.if( 'isVisible', 'ck-hidden', value => !value ),
 					bind.to( 'isOn', value => value ? 'ck-on' : 'ck-off' ),
 					bind.if( 'withText', 'ck-button_with-text' )

+ 1 - 1
packages/ckeditor5-ui/src/dropdown/dropdownview.js

@@ -147,7 +147,7 @@ export default class DropdownView extends View {
 				class: [
 					'ck',
 					'ck-dropdown',
-					bind.to( 'isEnabled', isEnabled => isEnabled ? '' : 'ck-disabled' )
+					bind.if( 'isEnabled', 'ck-disabled', value => !value )
 				]
 			},
 

+ 1 - 1
packages/ckeditor5-ui/src/list/listitemview.js

@@ -50,7 +50,7 @@ export default class ListItemView extends View {
 					'ck-list__item',
 					bind.to( 'class' ),
 					bind.if( 'isActive', 'ck-list__item_active' ),
-					bind.to( 'isEnabled', value => value ? 'ck-enabled' : 'ck-disabled' )
+					bind.if( 'isEnabled', 'ck-disabled', value => !value )
 				],
 				style: bind.to( 'style' ),
 				tabindex: bind.to( 'tabindex' )

+ 2 - 2
packages/ckeditor5-ui/tests/button/buttonview.js

@@ -47,10 +47,10 @@ describe( 'ButtonView', () => {
 	describe( '<button> bindings', () => {
 		describe( 'class', () => {
 			it( 'is set initially', () => {
-				expect( view.element.classList ).to.have.length( 4 );
+				expect( view.element.classList ).to.have.length( 3 );
 				expect( view.element.classList.contains( 'ck' ) ).to.true;
 				expect( view.element.classList.contains( 'ck-button' ) ).to.true;
-				expect( view.element.classList.contains( 'ck-enabled' ) ).to.true;
+				expect( view.element.classList.contains( 'ck-disabled' ) ).to.false;
 				expect( view.element.classList.contains( 'ck-off' ) ).to.true;
 			} );
 

+ 3 - 6
packages/ckeditor5-ui/tests/list/listitemview.js

@@ -75,7 +75,7 @@ describe( 'ListItemView', () => {
 	describe( 'DOM bindings', () => {
 		describe( '"class" attribute', () => {
 			it( 'reacts on view#class', () => {
-				expect( view.element.classList ).to.have.length( 3 );
+				expect( view.element.classList ).to.have.length( 2 );
 
 				view.set( 'class', 'foo' );
 
@@ -83,7 +83,7 @@ describe( 'ListItemView', () => {
 			} );
 
 			it( 'reacts on view#isActive', () => {
-				expect( view.element.classList ).to.have.length( 3 );
+				expect( view.element.classList ).to.have.length( 2 );
 
 				view.set( 'isActive', true );
 
@@ -91,19 +91,16 @@ describe( 'ListItemView', () => {
 			} );
 
 			it( 'reacts on view#isEnabled', () => {
-				expect( view.element.classList ).to.have.length( 3 );
+				expect( view.element.classList ).to.have.length( 2 );
 
-				expect( view.element.classList.contains( 'ck-enabled' ) ).to.be.true;
 				expect( view.element.classList.contains( 'ck-disabled' ) ).to.be.false;
 
 				view.set( 'isEnabled', false );
 
-				expect( view.element.classList.contains( 'ck-enabled' ) ).to.be.false;
 				expect( view.element.classList.contains( 'ck-disabled' ) ).to.be.true;
 
 				view.set( 'isEnabled', true );
 
-				expect( view.element.classList.contains( 'ck-enabled' ) ).to.be.true;
 				expect( view.element.classList.contains( 'ck-disabled' ) ).to.be.false;
 			} );
 		} );