Parcourir la source

Merge pull request #1744 from ckeditor/t/1743

Internal: Fixed `Writer` `model-writer-insert-forbidden-move` error usage. Closes #1743.
Piotr Jasiun il y a 6 ans
Parent
commit
890284c286

+ 10 - 2
packages/ckeditor5-engine/src/model/writer.js

@@ -177,8 +177,16 @@ export default class Writer {
 			// If it isn't the same root.
 			else {
 				if ( item.root.document ) {
-					// It is forbidden to move a node that was already in a document outside of it.
-					throw new Error( 'model-writer-insert-forbidden-move: Cannot move a node from a document to a different tree.' );
+					/**
+					 * Cannot move a node from a document to a different tree.
+					 * It is forbidden to move a node that was already in a document outside of it.
+					 *
+					 * @error model-writer-insert-forbidden-move
+					 */
+					throw new CKEditorError(
+						'model-writer-insert-forbidden-move: ' +
+						'Cannot move a node from a document to a different tree. ' +
+						'It is forbidden to move a node that was already in a document outside of it.' );
 				} else {
 					// Move between two different document fragments or from document fragment to a document is possible.
 					// In that case, remove the item from it's original parent.

+ 2 - 2
packages/ckeditor5-engine/tests/model/writer.js

@@ -302,7 +302,7 @@ describe( 'Writer', () => {
 
 			expect( () => {
 				insert( node, docFrag );
-			} ).to.throw();
+			} ).to.throw( CKEditorError, /^model-writer-insert-forbidden-move/ );
 		} );
 
 		it( 'should transfer markers from given DocumentFragment', () => {
@@ -716,7 +716,7 @@ describe( 'Writer', () => {
 
 			expect( () => {
 				append( node, docFrag );
-			} ).to.throw();
+			} ).to.throw( CKEditorError, /^model-writer-insert-forbidden-move/ );
 		} );
 	} );