Procházet zdrojové kódy

Renamed toWidget option addSelectionHandler to hasSelectionHandler.

Aleksander Nowodzinski před 7 roky
rodič
revize
8756e24aa9

+ 4 - 4
packages/ckeditor5-widget/src/utils.js

@@ -53,7 +53,7 @@ export function isWidget( element ) {
  * @param {Object} [options={}]
  * @param {String|Function} [options.label] Element's label provided to {@link ~setLabel} function. It can be passed as
  * a plain string or a function returning a string.
- * @param {Boolean} [options.addSelectionHandler=false] If set to true the widget will have a selection handler added.
+ * @param {Boolean} [options.hasSelectionHandler=false] If `true`, the widget will have a selection handler added.
  * @returns {module:engine/view/element~Element} Returns same element.
  */
 export function toWidget( element, writer, options = {} ) {
@@ -66,8 +66,8 @@ export function toWidget( element, writer, options = {} ) {
 		setLabel( element, options.label, writer );
 	}
 
-	if ( options.addSelectionHandler ) {
-		addSelectionHandler( element, writer );
+	if ( options.hasSelectionHandler ) {
+		hasSelectionHandler( element, writer );
 	}
 
 	setHighlightHandling(
@@ -184,7 +184,7 @@ function getFillerOffset() {
 //
 // @param {module:engine/view/editableelement~EditableElement}
 // @param {module:engine/view/writer~Writer} writer
-function addSelectionHandler( editable, writer ) {
+function hasSelectionHandler( editable, writer ) {
 	const selectionHandler = writer.createUIElement( 'div', { class: 'ck ck-selection-handler' }, function( domDocument ) {
 		const domElement = this.toDomElement( domDocument );
 

+ 2 - 2
packages/ckeditor5-widget/tests/utils.js

@@ -91,8 +91,8 @@ describe( 'widget utils', () => {
 			expect( element.hasClass( 'foo' ) ).to.be.false;
 		} );
 
-		it( 'should add element a selection handler to widget if addSelectionHandler=true is passed', () => {
-			toWidget( element, writer, { addSelectionHandler: true } );
+		it( 'should add element a selection handler to widget if hasSelectionHandler=true is passed', () => {
+			toWidget( element, writer, { hasSelectionHandler: true } );
 
 			expect( element.hasClass( 'ck-widget_selectable' ) ).to.be.true;
 

+ 1 - 1
packages/ckeditor5-widget/tests/widget.js

@@ -1184,7 +1184,7 @@ describe( 'Widget', () => {
 							view: ( modelItem, viewWriter ) => {
 								const widget = viewWriter.createContainerElement( 'div' );
 
-								return toWidget( widget, viewWriter, { addSelectionHandler: true } );
+								return toWidget( widget, viewWriter, { hasSelectionHandler: true } );
 							}
 						} ) );
 				} );