瀏覽代碼

Merge pull request #23 from ckeditor/t/ckeditor5/1341

Tests: Added a test checking memory leaks when the editor is created and destroyed (see ckeditor/ckeditor5#1341).
Aleksander Nowodzinski 6 年之前
父節點
當前提交
853f386024
共有 2 個文件被更改,包括 9 次插入1 次删除
  1. 1 0
      packages/ckeditor5-build-balloon/package.json
  2. 8 1
      packages/ckeditor5-build-balloon/tests/ckeditor.js

+ 1 - 0
packages/ckeditor5-build-balloon/package.json

@@ -30,6 +30,7 @@
     "@ckeditor/ckeditor5-basic-styles": "^10.1.0",
     "@ckeditor/ckeditor5-block-quote": "^10.1.1",
     "@ckeditor/ckeditor5-ckfinder": "^10.0.0",
+    "@ckeditor/ckeditor5-core": "^11.1.0",
     "@ckeditor/ckeditor5-dev-utils": "^11.0.1",
     "@ckeditor/ckeditor5-dev-webpack-plugin": "^7.0.1",
     "@ckeditor/ckeditor5-easy-image": "^10.0.4",

+ 8 - 1
packages/ckeditor5-build-balloon/tests/ckeditor.js

@@ -7,6 +7,7 @@
 
 import BalloonEditor from '../src/ckeditor';
 import BaseBalloonEditor from '@ckeditor/ckeditor5-editor-balloon/src/ballooneditor';
+import { describeMemoryUsage, testMemoryUsage } from '@ckeditor/ckeditor5-core/tests/_utils/memory';
 
 describe( 'BalloonEditor build', () => {
 	let editor, editorElement;
@@ -22,7 +23,7 @@ describe( 'BalloonEditor build', () => {
 		editorElement.remove();
 	} );
 
-	describe( 'buid', () => {
+	describe( 'build', () => {
 		it( 'contains plugins', () => {
 			expect( BalloonEditor.builtinPlugins ).to.not.be.empty;
 		} );
@@ -155,4 +156,10 @@ describe( 'BalloonEditor build', () => {
 			expect( editor.getData() ).to.equal( data );
 		} );
 	} );
+
+	describeMemoryUsage( () => {
+		testMemoryUsage(
+			'should not grow on multiple create/destroy',
+			() => BalloonEditor.create( document.querySelector( '#mem-editor' ) ) );
+	} );
 } );