|
|
@@ -11,66 +11,71 @@ import InsertRowCommand from '../../src/commands/insertrowcommand';
|
|
|
import { downcastInsertTable } from '../../src/converters/downcast';
|
|
|
import upcastTable from '../../src/converters/upcasttable';
|
|
|
import { formatTable, formattedModelTable, modelTable } from '../_utils/utils';
|
|
|
+import TableUtils from '../../src/tableutils';
|
|
|
|
|
|
describe( 'InsertRowCommand', () => {
|
|
|
let editor, model, command;
|
|
|
|
|
|
beforeEach( () => {
|
|
|
- return ModelTestEditor.create()
|
|
|
- .then( newEditor => {
|
|
|
- editor = newEditor;
|
|
|
- model = editor.model;
|
|
|
- command = new InsertRowCommand( editor );
|
|
|
-
|
|
|
- const conversion = editor.conversion;
|
|
|
- const schema = model.schema;
|
|
|
-
|
|
|
- schema.register( 'table', {
|
|
|
- allowWhere: '$block',
|
|
|
- allowAttributes: [ 'headingRows' ],
|
|
|
- isBlock: true,
|
|
|
- isObject: true
|
|
|
- } );
|
|
|
-
|
|
|
- schema.register( 'tableRow', {
|
|
|
- allowIn: 'table',
|
|
|
- allowAttributes: [],
|
|
|
- isBlock: true,
|
|
|
- isLimit: true
|
|
|
- } );
|
|
|
-
|
|
|
- schema.register( 'tableCell', {
|
|
|
- allowIn: 'tableRow',
|
|
|
- allowContentOf: '$block',
|
|
|
- allowAttributes: [ 'colspan', 'rowspan' ],
|
|
|
- isBlock: true,
|
|
|
- isLimit: true
|
|
|
- } );
|
|
|
-
|
|
|
- model.schema.register( 'p', { inheritAllFrom: '$block' } );
|
|
|
-
|
|
|
- // Table conversion.
|
|
|
- conversion.for( 'upcast' ).add( upcastTable() );
|
|
|
- conversion.for( 'downcast' ).add( downcastInsertTable() );
|
|
|
-
|
|
|
- // Table row upcast only since downcast conversion is done in `downcastTable()`.
|
|
|
- conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableRow', view: 'tr' } ) );
|
|
|
-
|
|
|
- // Table cell conversion.
|
|
|
- conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'td' } ) );
|
|
|
- conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'th' } ) );
|
|
|
-
|
|
|
- conversion.attributeToAttribute( { model: 'colspan', view: 'colspan' } );
|
|
|
- conversion.attributeToAttribute( { model: 'rowspan', view: 'rowspan' } );
|
|
|
+ return ModelTestEditor.create( {
|
|
|
+ plugins: [ TableUtils ]
|
|
|
+ } ).then( newEditor => {
|
|
|
+ editor = newEditor;
|
|
|
+ model = editor.model;
|
|
|
+
|
|
|
+ const conversion = editor.conversion;
|
|
|
+ const schema = model.schema;
|
|
|
+
|
|
|
+ schema.register( 'table', {
|
|
|
+ allowWhere: '$block',
|
|
|
+ allowAttributes: [ 'headingRows' ],
|
|
|
+ isBlock: true,
|
|
|
+ isObject: true
|
|
|
} );
|
|
|
+
|
|
|
+ schema.register( 'tableRow', {
|
|
|
+ allowIn: 'table',
|
|
|
+ allowAttributes: [],
|
|
|
+ isBlock: true,
|
|
|
+ isLimit: true
|
|
|
+ } );
|
|
|
+
|
|
|
+ schema.register( 'tableCell', {
|
|
|
+ allowIn: 'tableRow',
|
|
|
+ allowContentOf: '$block',
|
|
|
+ allowAttributes: [ 'colspan', 'rowspan' ],
|
|
|
+ isBlock: true,
|
|
|
+ isLimit: true
|
|
|
+ } );
|
|
|
+
|
|
|
+ model.schema.register( 'p', { inheritAllFrom: '$block' } );
|
|
|
+
|
|
|
+ // Table conversion.
|
|
|
+ conversion.for( 'upcast' ).add( upcastTable() );
|
|
|
+ conversion.for( 'downcast' ).add( downcastInsertTable() );
|
|
|
+
|
|
|
+ // Table row upcast only since downcast conversion is done in `downcastTable()`.
|
|
|
+ conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableRow', view: 'tr' } ) );
|
|
|
+
|
|
|
+ // Table cell conversion.
|
|
|
+ conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'td' } ) );
|
|
|
+ conversion.for( 'upcast' ).add( upcastElementToElement( { model: 'tableCell', view: 'th' } ) );
|
|
|
+
|
|
|
+ conversion.attributeToAttribute( { model: 'colspan', view: 'colspan' } );
|
|
|
+ conversion.attributeToAttribute( { model: 'rowspan', view: 'rowspan' } );
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
afterEach( () => {
|
|
|
return editor.destroy();
|
|
|
} );
|
|
|
|
|
|
- describe( 'isEnabled', () => {
|
|
|
- describe( 'when selection is collapsed', () => {
|
|
|
+ describe( 'below', () => {
|
|
|
+ beforeEach( () => {
|
|
|
+ command = new InsertRowCommand( editor );
|
|
|
+ } );
|
|
|
+
|
|
|
+ describe( 'isEnabled', () => {
|
|
|
it( 'should be false if wrong node', () => {
|
|
|
setData( model, '<p>foo[]</p>' );
|
|
|
expect( command.isEnabled ).to.be.false;
|
|
|
@@ -81,145 +86,207 @@ describe( 'InsertRowCommand', () => {
|
|
|
expect( command.isEnabled ).to.be.true;
|
|
|
} );
|
|
|
} );
|
|
|
- } );
|
|
|
|
|
|
- describe( 'execute()', () => {
|
|
|
- it( 'should insert row in given table at given index', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ]
|
|
|
- ] ) );
|
|
|
+ describe( 'execute()', () => {
|
|
|
+ it( 'should insert row after current position', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ]
|
|
|
+ ] ) );
|
|
|
|
|
|
- command.execute( { at: 1 } );
|
|
|
+ command.execute();
|
|
|
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '21', '22' ]
|
|
|
- ] ) );
|
|
|
- } );
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '10', '11' ]
|
|
|
+ ] ) );
|
|
|
+ } );
|
|
|
|
|
|
- it( 'should insert row in given table at default index', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ]
|
|
|
- ] ) );
|
|
|
+ it( 'should update table heading rows attribute when inserting row in headings section', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 3 } ) );
|
|
|
+ } );
|
|
|
|
|
|
- command.execute();
|
|
|
+ it( 'should not update table heading rows attribute when inserting row after headings section', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10[]', '11' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10[]', '11' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+ } );
|
|
|
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ '', '' ],
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ]
|
|
|
- ] ) );
|
|
|
- } );
|
|
|
+ it( 'should expand rowspan of a cell that overlaps inserted rows', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ { colspan: 2, contents: '00' }, '02', '03' ],
|
|
|
+ [ { colspan: 2, rowspan: 4, contents: '10[]' }, '12', '13' ],
|
|
|
+ [ '22', '23' ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ { colspan: 2, contents: '00' }, '02', '03' ],
|
|
|
+ [ { colspan: 2, rowspan: 5, contents: '10[]' }, '12', '13' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '22', '23' ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ } );
|
|
|
|
|
|
- it( 'should update table heading rows attribute when inserting row in headings section', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ],
|
|
|
- [ '31', '32' ]
|
|
|
- ], { headingRows: 2 } ) );
|
|
|
-
|
|
|
- command.execute( { at: 1 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '21', '22' ],
|
|
|
- [ '31', '32' ]
|
|
|
- ], { headingRows: 3 } ) );
|
|
|
- } );
|
|
|
+ it( 'should not expand rowspan of a cell that does not overlaps inserted rows', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ { rowspan: 2, contents: '00' }, '01', '02' ],
|
|
|
+ [ '11[]', '12' ],
|
|
|
+ [ '20', '21', '22' ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ { rowspan: 2, contents: '00' }, '01', '02' ],
|
|
|
+ [ '11[]', '12' ],
|
|
|
+ [ '', '', '' ],
|
|
|
+ [ '20', '21', '22' ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ } );
|
|
|
|
|
|
- it( 'should not update table heading rows attribute when inserting row after headings section', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ],
|
|
|
- [ '31', '32' ]
|
|
|
- ], { headingRows: 2 } ) );
|
|
|
-
|
|
|
- command.execute( { at: 2 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '31', '32' ]
|
|
|
- ], { headingRows: 2 } ) );
|
|
|
- } );
|
|
|
+ it( 'should properly calculate columns if next row has colspans', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ { rowspan: 2, contents: '00' }, '01', '02' ],
|
|
|
+ [ '11[]', '12' ],
|
|
|
+ [ { colspan: 3, contents: '20' } ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ { rowspan: 2, contents: '00' }, '01', '02' ],
|
|
|
+ [ '11[]', '12' ],
|
|
|
+ [ '', '', '' ],
|
|
|
+ [ { colspan: 3, contents: '20' } ]
|
|
|
+ ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should insert rows at the end of a table', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10[]', '11' ]
|
|
|
+ ] ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
|
|
|
- it( 'should expand rowspan of a cell that overlaps inserted rows', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ { colspan: 2, contents: '11[]' }, '13', '14' ],
|
|
|
- [ { colspan: 2, rowspan: 4, contents: '21' }, '23', '24' ],
|
|
|
- [ '33', '34' ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
-
|
|
|
- command.execute( { at: 2, rows: 3 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ { colspan: 2, contents: '11[]' }, '13', '14' ],
|
|
|
- [ { colspan: 2, rowspan: 7, contents: '21' }, '23', '24' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '33', '34' ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10[]', '11' ],
|
|
|
+ [ '', '' ]
|
|
|
+ ] ) );
|
|
|
+ } );
|
|
|
} );
|
|
|
+ } );
|
|
|
|
|
|
- it( 'should not expand rowspan of a cell that does not overlaps inserted rows', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ { rowspan: 2, contents: '11[]' }, '12', '13' ],
|
|
|
- [ '22', '23' ],
|
|
|
- [ '31', '32', '33' ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
-
|
|
|
- command.execute( { at: 2, rows: 3 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ { rowspan: 2, contents: '11[]' }, '12', '13' ],
|
|
|
- [ '22', '23' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ '31', '32', '33' ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ describe( 'location=above', () => {
|
|
|
+ beforeEach( () => {
|
|
|
+ command = new InsertRowCommand( editor, { location: 'above' } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should properly calculate columns if next row has colspans', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ { rowspan: 2, contents: '11[]' }, '12', '13' ],
|
|
|
- [ '22', '23' ],
|
|
|
- [ { colspan: 3, contents: '31' } ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
-
|
|
|
- command.execute( { at: 2, rows: 3 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ { rowspan: 2, contents: '11[]' }, '12', '13' ],
|
|
|
- [ '22', '23' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ '', '', '' ],
|
|
|
- [ { colspan: 3, contents: '31' } ]
|
|
|
- ], { headingColumns: 3, headingRows: 1 } ) );
|
|
|
+ describe( 'isEnabled', () => {
|
|
|
+ it( 'should be false if wrong node', () => {
|
|
|
+ setData( model, '<p>foo[]</p>' );
|
|
|
+ expect( command.isEnabled ).to.be.false;
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should be true if in table', () => {
|
|
|
+ setData( model, modelTable( [ [ '[]' ] ] ) );
|
|
|
+ expect( command.isEnabled ).to.be.true;
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should insert rows at the end of a table', () => {
|
|
|
- setData( model, modelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ]
|
|
|
- ] ) );
|
|
|
-
|
|
|
- command.execute( { at: 2, rows: 3 } );
|
|
|
-
|
|
|
- expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
- [ '11[]', '12' ],
|
|
|
- [ '21', '22' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '', '' ],
|
|
|
- [ '', '' ]
|
|
|
- ] ) );
|
|
|
+ describe( 'execute()', () => {
|
|
|
+ it( 'should insert row at the beginning of a table', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ]
|
|
|
+ ] ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '', '' ],
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ]
|
|
|
+ ] ) );
|
|
|
+ } );
|
|
|
+ it( 'should insert row at the end of a table', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20[]', '21' ]
|
|
|
+ ] ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '20[]', '21' ]
|
|
|
+ ] ) );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should update table heading rows attribute when inserting row in headings section', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '', '' ],
|
|
|
+ [ '00[]', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20', '21' ]
|
|
|
+ ], { headingRows: 3 } ) );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should not update table heading rows attribute when inserting row after headings section', () => {
|
|
|
+ setData( model, modelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '20[]', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+
|
|
|
+ command.execute();
|
|
|
+
|
|
|
+ expect( formatTable( getData( model ) ) ).to.equal( formattedModelTable( [
|
|
|
+ [ '00', '01' ],
|
|
|
+ [ '10', '11' ],
|
|
|
+ [ '', '' ],
|
|
|
+ [ '20[]', '21' ]
|
|
|
+ ], { headingRows: 2 } ) );
|
|
|
+ } );
|
|
|
} );
|
|
|
} );
|
|
|
} );
|