Przeglądaj źródła

Merge pull request #35 from ckeditor/t/ckeditor5/1814

Tests: Prevented `CKEditorInspector` auto–attachment in the memory consumption manual test. Closes ckeditor/ckeditor5#1814.
Aleksander Nowodzinski 6 lat temu
rodzic
commit
805103500a

+ 7 - 7
packages/ckeditor5-editor-balloon/tests/manual/memory.js

@@ -3,13 +3,11 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
  */
 
-/* globals console:false, document, window */
+/* globals console:false, document */
 
 import BalloonEditor from '../../src/ballooneditor';
 import ArticlePluginSet from '@ckeditor/ckeditor5-core/tests/_utils/articlepluginset';
 
-window.editors = {};
-
 /*
  * Memory-leak safe version of balloon editor manual test does not:
  * - define global variables (such as let editor; in main file scope)
@@ -17,6 +15,8 @@ window.editors = {};
  * - add event listeners with () => {} methods which reference other
  */
 function initEditors() {
+	const editors = {};
+
 	init( '#editor-1' );
 	init( '#editor-2' );
 
@@ -59,7 +59,7 @@ function initEditors() {
 				}
 			} )
 			.then( editor => {
-				window.editors[ selector ] = editor;
+				editors[ selector ] = editor;
 			} )
 			.catch( err => {
 				console.error( err.stack );
@@ -67,9 +67,9 @@ function initEditors() {
 	}
 
 	function destroyEditors() {
-		for ( const selector in window.editors ) {
-			window.editors[ selector ].destroy().then( () => {
-				window.editors[ selector ] = undefined;
+		for ( const selector in editors ) {
+			editors[ selector ].destroy().then( () => {
+				editors[ selector ] = undefined;
 			} );
 		}