8
0
Pārlūkot izejas kodu

Fix tests for MouseObserver.

Maciej Gołaszewski 5 gadi atpakaļ
vecāks
revīzija
7fcd483efb

+ 0 - 1
packages/ckeditor5-engine/src/view/observer/mouseobserver.js

@@ -21,7 +21,6 @@ export default class MouseObserver extends DomEventObserver {
 	constructor( view ) {
 		super( view );
 
-		// TODO: either enhance or new classes
 		this.domEventType = [ 'mousedown', 'mousemove', 'mouseup', 'mouseleave' ];
 	}
 

+ 17 - 10
packages/ckeditor5-engine/tests/view/observer/mouseobserver.js

@@ -21,22 +21,29 @@ describe( 'MouseObserver', () => {
 		view.destroy();
 	} );
 
-	it( 'should define domEventType', () => {
-		expect( observer.domEventType ).to.equal( 'mousedown' );
+	it( 'should define domEventTypes', () => {
+		expect( observer.domEventType ).to.deep.equal( [
+			'mousedown',
+			'mousemove',
+			'mouseup',
+			'mouseleave'
+		] );
 	} );
 
 	describe( 'onDomEvent', () => {
-		it( 'should fire mousedown with the right event data', () => {
-			const spy = sinon.spy();
+		for ( const eventName of [ 'mousedown', 'mousemove', 'mouseup', 'mouseleave' ] ) {
+			it( `should fire ${ eventName } with the right event data`, () => {
+				const spy = sinon.spy();
 
-			viewDocument.on( 'mousedown', spy );
+				viewDocument.on( eventName, spy );
 
-			observer.onDomEvent( { type: 'mousedown', target: document.body } );
+				observer.onDomEvent( { type: eventName, target: document.body } );
 
-			expect( spy.calledOnce ).to.be.true;
+				expect( spy.calledOnce ).to.be.true;
 
-			const data = spy.args[ 0 ][ 1 ];
-			expect( data.domTarget ).to.equal( document.body );
-		} );
+				const data = spy.args[ 0 ][ 1 ];
+				expect( data.domTarget ).to.equal( document.body );
+			} );
+		}
 	} );
 } );