Преглед на файлове

Merge pull request #191 from ckeditor/t/187

t/187: Weak instanceof Node check in DOMEmitterMixin.
Piotrek Koszuliński преди 10 години
родител
ревизия
7b3a4b511c
променени са 2 файла, в които са добавени 271 реда и са изтрити 228 реда
  1. 11 2
      packages/ckeditor5-engine/src/ui/domemittermixin.js
  2. 260 226
      packages/ckeditor5-engine/tests/ui/domemittermixin.js

+ 11 - 2
packages/ckeditor5-engine/src/ui/domemittermixin.js

@@ -175,7 +175,7 @@ const DOMEmitterMixin = extend( {}, EmitterMixin, {
 
 		// Check if emitter is an instance of DOM Node. If so, replace the argument with
 		// corresponding ProxyEmitter (or create one if not existing).
-		if ( emitter instanceof Node ) {
+		if ( isDomNode( emitter ) ) {
 			args[ 0 ] = this._getProxyEmitter( emitter ) || new ProxyEmitter( emitter );
 		}
 
@@ -203,7 +203,7 @@ const DOMEmitterMixin = extend( {}, EmitterMixin, {
 		const emitter = args[ 0 ];
 
 		// Check if emitter is an instance of DOM Node. If so, replace the argument with corresponding ProxyEmitter.
-		if ( emitter instanceof Node ) {
+		if ( isDomNode( emitter ) ) {
 			let proxy = this._getProxyEmitter( emitter );
 
 			if ( proxy ) {
@@ -254,6 +254,15 @@ function getNodeUID( node ) {
 	return node[ 'data-ck-expando' ] || ( node[ 'data-ck-expando' ] = utils.uid() );
 }
 
+// Checks (naively) if given node is native DOM Node.
+//
+// @private
+// @param {Node} node
+// @return {Boolean} True when native DOM Node.
+function isDomNode( node ) {
+	return node && node.nodeType && ( typeof node.addEventListener == 'function' );
+}
+
 /**
  * Interface representing classes which mix in {@link core.ui.DOMEmitter}.
  *

+ 260 - 226
packages/ckeditor5-engine/tests/ui/domemittermixin.js

@@ -17,9 +17,9 @@ let emitter, domEmitter, node;
 
 testUtils.createSinonSandbox();
 
-let getEmitterInstance = () => extend( {}, EmitterMixin );
-let getDOMEmitterInstance = () => extend( {}, DOMEmitterMixin );
-let getDOMNodeInstance = () => document.createElement( 'div' );
+const getEmitterInstance = () => extend( {}, EmitterMixin );
+const getDOMEmitterInstance = () => extend( {}, DOMEmitterMixin );
+const getDOMNodeInstance = () => document.createElement( 'div' );
 
 function updateEmitterInstance() {
 	emitter = getEmitterInstance();
@@ -33,325 +33,359 @@ function updateDOMNodeInstance() {
 	node = getDOMNodeInstance();
 }
 
-beforeEach( updateEmitterInstance );
-beforeEach( updateDOMEmitterInstance );
-beforeEach( updateDOMNodeInstance );
+describe( 'DOMEmitterMixin', () => {
+	beforeEach( () => {
+		updateEmitterInstance();
+		updateDOMEmitterInstance();
+		updateDOMNodeInstance();
+	} );
 
-describe( 'listenTo', () => {
-	it( 'should listen to EmitterMixin events', () => {
-		let spy = testUtils.sinon.spy();
+	describe( 'listenTo', () => {
+		it( 'should listen to EmitterMixin events', () => {
+			const spy = testUtils.sinon.spy();
 
-		domEmitter.listenTo( emitter, 'test', spy );
-		emitter.fire( 'test' );
+			domEmitter.listenTo( emitter, 'test', spy );
+			emitter.fire( 'test' );
 
-		sinon.assert.calledOnce( spy );
-	} );
+			sinon.assert.calledOnce( spy );
+		} );
 
-	it( 'should listen to native DOM events', () => {
-		let spy = testUtils.sinon.spy();
+		it( 'should listen to native DOM events', () => {
+			const spy = testUtils.sinon.spy();
 
-		domEmitter.listenTo( node, 'test', spy );
+			domEmitter.listenTo( node, 'test', spy );
 
-		let event = new Event( 'test' );
-		node.dispatchEvent( event );
+			node.dispatchEvent( new Event( 'test' ) );
+
+			sinon.assert.calledOnce( spy );
+		} );
 
-		sinon.assert.calledOnce( spy );
+		// #187
+		it( 'should work for DOM Nodes belonging to another window', () => {
+			const spy = testUtils.sinon.spy();
+			const iframe = document.createElement( 'iframe' );
+
+			document.body.appendChild( iframe );
+			const iframeNode = iframe.contentWindow.document.createElement( 'div' );
+
+			domEmitter.listenTo( iframeNode, 'test', spy );
+			iframeNode.dispatchEvent( new Event( 'test' ) );
+
+			sinon.assert.calledOnce( spy );
+		} );
 	} );
-} );
 
-describe( 'stopListening', () => {
-	it( 'should stop listening to a specific event callback', () => {
-		let spy1 = testUtils.sinon.spy();
-		let spy2 = testUtils.sinon.spy();
+	describe( 'stopListening', () => {
+		it( 'should stop listening to a specific event callback', () => {
+			const spy1 = testUtils.sinon.spy();
+			const spy2 = testUtils.sinon.spy();
 
-		domEmitter.listenTo( node, 'event1', spy1 );
-		domEmitter.listenTo( node, 'event2', spy2 );
+			domEmitter.listenTo( node, 'event1', spy1 );
+			domEmitter.listenTo( node, 'event2', spy2 );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		domEmitter.stopListening( node, 'event1', spy1 );
+			domEmitter.stopListening( node, 'event1', spy1 );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		sinon.assert.calledOnce( spy1 );
-		sinon.assert.calledTwice( spy2 );
-	} );
+			sinon.assert.calledOnce( spy1 );
+			sinon.assert.calledTwice( spy2 );
+		} );
 
-	it( 'should stop listening to an specific event', () => {
-		let spy1a = testUtils.sinon.spy();
-		let spy1b = testUtils.sinon.spy();
-		let spy2 = testUtils.sinon.spy();
+		it( 'should stop listening to an specific event', () => {
+			const spy1a = testUtils.sinon.spy();
+			const spy1b = testUtils.sinon.spy();
+			const spy2 = testUtils.sinon.spy();
 
-		domEmitter.listenTo( node, 'event1', spy1a );
-		domEmitter.listenTo( node, 'event1', spy1b );
-		domEmitter.listenTo( node, 'event2', spy2 );
+			domEmitter.listenTo( node, 'event1', spy1a );
+			domEmitter.listenTo( node, 'event1', spy1b );
+			domEmitter.listenTo( node, 'event2', spy2 );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledOnce( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledOnce( spy2 );
 
-		domEmitter.stopListening( node, 'event1' );
+			domEmitter.stopListening( node, 'event1' );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
-	} );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
+		} );
 
-	it( 'should stop listening to all events from a specific node', () => {
-		let spy1 = testUtils.sinon.spy();
-		let spy2 = testUtils.sinon.spy();
+		it( 'should stop listening to all events from a specific node', () => {
+			const spy1 = testUtils.sinon.spy();
+			const spy2 = testUtils.sinon.spy();
 
-		domEmitter.listenTo( node, 'event1', spy1 );
-		domEmitter.listenTo( node, 'event2', spy2 );
+			domEmitter.listenTo( node, 'event1', spy1 );
+			domEmitter.listenTo( node, 'event2', spy2 );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		domEmitter.stopListening( node );
+			domEmitter.stopListening( node );
 
-		node.dispatchEvent( new Event( 'event1' ) );
-		node.dispatchEvent( new Event( 'event2' ) );
+			node.dispatchEvent( new Event( 'event1' ) );
+			node.dispatchEvent( new Event( 'event2' ) );
 
-		sinon.assert.calledOnce( spy1 );
-		sinon.assert.calledOnce( spy2 );
-	} );
+			sinon.assert.calledOnce( spy1 );
+			sinon.assert.calledOnce( spy2 );
+		} );
 
-	it( 'should stop listening to everything', () => {
-		let spy1 = testUtils.sinon.spy();
-		let spy2 = testUtils.sinon.spy();
+		it( 'should stop listening to everything', () => {
+			const spy1 = testUtils.sinon.spy();
+			const spy2 = testUtils.sinon.spy();
 
-		let node1 = getDOMNodeInstance();
-		let node2 = getDOMNodeInstance();
+			const node1 = getDOMNodeInstance();
+			const node2 = getDOMNodeInstance();
 
-		domEmitter.listenTo( node1, 'event1', spy1 );
-		domEmitter.listenTo( node2, 'event2', spy2 );
+			domEmitter.listenTo( node1, 'event1', spy1 );
+			domEmitter.listenTo( node2, 'event2', spy2 );
 
-		expect( domEmitter ).to.have.property( '_listeningTo' );
+			expect( domEmitter ).to.have.property( '_listeningTo' );
 
-		node1.dispatchEvent( new Event( 'event1' ) );
-		node2.dispatchEvent( new Event( 'event2' ) );
+			node1.dispatchEvent( new Event( 'event1' ) );
+			node2.dispatchEvent( new Event( 'event2' ) );
 
-		domEmitter.stopListening();
+			domEmitter.stopListening();
 
-		node1.dispatchEvent( new Event( 'event1' ) );
-		node2.dispatchEvent( new Event( 'event2' ) );
+			node1.dispatchEvent( new Event( 'event1' ) );
+			node2.dispatchEvent( new Event( 'event2' ) );
 
-		sinon.assert.calledOnce( spy1 );
-		sinon.assert.calledOnce( spy2 );
+			sinon.assert.calledOnce( spy1 );
+			sinon.assert.calledOnce( spy2 );
 
-		expect( domEmitter ).to.not.have.property( '_listeningTo' );
-	} );
+			expect( domEmitter ).to.not.have.property( '_listeningTo' );
+		} );
 
-	it( 'should not stop other nodes when a non-listened node is provided', () => {
-		let spy = testUtils.sinon.spy();
+		it( 'should not stop other nodes when a non-listened node is provided', () => {
+			const spy = testUtils.sinon.spy();
 
-		let node1 = getDOMNodeInstance();
-		let node2 = getDOMNodeInstance();
+			const node1 = getDOMNodeInstance();
+			const node2 = getDOMNodeInstance();
 
-		domEmitter.listenTo( node1, 'test', spy );
+			domEmitter.listenTo( node1, 'test', spy );
 
-		domEmitter.stopListening( node2 );
+			domEmitter.stopListening( node2 );
 
-		node1.dispatchEvent( new Event( 'test' ) );
+			node1.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.called( spy );
-	} );
+			sinon.assert.called( spy );
+		} );
+
+		it( 'should pass DOM Event data to the listener', () => {
+			const spy = testUtils.sinon.spy();
+
+			const node = getDOMNodeInstance();
 
-	it( 'should pass DOM Event data to the listener', () => {
-		let spy = testUtils.sinon.spy();
+			domEmitter.listenTo( node, 'click', spy );
 
-		let node = getDOMNodeInstance();
+			const mouseEvent = new MouseEvent( 'click', {
+				screenX: 10,
+				screenY: 20
+			} );
 
-		domEmitter.listenTo( node, 'click', spy );
+			node.dispatchEvent( mouseEvent );
 
-		let mouseEvent = new MouseEvent( 'click', {
-			screenX: 10,
-			screenY: 20
+			sinon.assert.calledOnce( spy );
+			expect( spy.args[ 0 ][ 1 ] ).to.be.equal( mouseEvent );
 		} );
 
-		node.dispatchEvent( mouseEvent );
+		it( 'should detach native DOM event listener proxy, specific event', () => {
+			const spy1a = testUtils.sinon.spy();
+			const spy1b = testUtils.sinon.spy();
 
-		sinon.assert.calledOnce( spy );
-		expect( spy.args[ 0 ][ 1 ] ).to.be.equal( mouseEvent );
-	} );
+			domEmitter.listenTo( node, 'test', spy1a );
 
-	it( 'should detach native DOM event listener proxy, specific event', () => {
-		let spy1a = testUtils.sinon.spy();
-		let spy1b = testUtils.sinon.spy();
+			const proxyEmitter = domEmitter._getProxyEmitter( node );
+			const spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
 
-		domEmitter.listenTo( node, 'test', spy1a );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		let proxyEmitter = domEmitter._getProxyEmitter( node );
-		let spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy2 );
 
-		node.dispatchEvent( new Event( 'test' ) );
+			domEmitter.stopListening( node, 'test' );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy2 );
 
-		domEmitter.stopListening( node, 'test' );
-		node.dispatchEvent( new Event( 'test' ) );
+			// Attach same event again.
+			domEmitter.listenTo( node, 'test', spy1b );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy2 );
+			expect( proxyEmitter ).to.be.equal( domEmitter._getProxyEmitter( node ) );
 
-		// Attach same event again.
-		domEmitter.listenTo( node, 'test', spy1b );
-		node.dispatchEvent( new Event( 'test' ) );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
+		} );
 
-		expect( proxyEmitter ).to.be.equal( domEmitter._getProxyEmitter( node ) );
+		it( 'should detach native DOM event listener proxy, specific callback', () => {
+			const spy1a = testUtils.sinon.spy();
+			const spy1b = testUtils.sinon.spy();
+			const spy1c = testUtils.sinon.spy();
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
-	} );
+			domEmitter.listenTo( node, 'test', spy1a );
+			domEmitter.listenTo( node, 'test', spy1b );
 
-	it( 'should detach native DOM event listener proxy, specific callback', () => {
-		let spy1a = testUtils.sinon.spy();
-		let spy1b = testUtils.sinon.spy();
-		let spy1c = testUtils.sinon.spy();
+			const proxyEmitter = domEmitter._getProxyEmitter( node );
+			const spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
 
-		domEmitter.listenTo( node, 'test', spy1a );
-		domEmitter.listenTo( node, 'test', spy1b );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		let proxyEmitter = domEmitter._getProxyEmitter( node );
-		let spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledOnce( spy2 );
 
-		node.dispatchEvent( new Event( 'test' ) );
+			domEmitter.stopListening( node, 'test', spy1a );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledOnce( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledTwice( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		domEmitter.stopListening( node, 'test', spy1a );
-		node.dispatchEvent( new Event( 'test' ) );
+			domEmitter.stopListening( node, 'test', spy1b );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledTwice( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledTwice( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		domEmitter.stopListening( node, 'test', spy1b );
-		node.dispatchEvent( new Event( 'test' ) );
+			// Attach same event again.
+			domEmitter.listenTo( node, 'test', spy1c );
+			node.dispatchEvent( new Event( 'test' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledTwice( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			expect( proxyEmitter ).to.be.equal( domEmitter._getProxyEmitter( node ) );
 
-		// Attach same event again.
-		domEmitter.listenTo( node, 'test', spy1c );
-		node.dispatchEvent( new Event( 'test' ) );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledTwice( spy1b );
+			sinon.assert.calledOnce( spy1c );
+			sinon.assert.calledThrice( spy2 );
+		} );
 
-		expect( proxyEmitter ).to.be.equal( domEmitter._getProxyEmitter( node ) );
+		it( 'should detach native DOM event listener proxy, specific emitter', () => {
+			const spy1a = testUtils.sinon.spy();
+			const spy1b = testUtils.sinon.spy();
+			const spy1c = testUtils.sinon.spy();
+			const spy1d = testUtils.sinon.spy();
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledTwice( spy1b );
-		sinon.assert.calledOnce( spy1c );
-		sinon.assert.calledThrice( spy2 );
-	} );
+			domEmitter.listenTo( node, 'test1', spy1a );
+			domEmitter.listenTo( node, 'test2', spy1b );
+
+			const proxyEmitter = domEmitter._getProxyEmitter( node );
+			const spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
 
-	it( 'should detach native DOM event listener proxy, specific emitter', () => {
-		let spy1a = testUtils.sinon.spy();
-		let spy1b = testUtils.sinon.spy();
-		let spy1c = testUtils.sinon.spy();
-		let spy1d = testUtils.sinon.spy();
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		domEmitter.listenTo( node, 'test1', spy1a );
-		domEmitter.listenTo( node, 'test2', spy1b );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		let proxyEmitter = domEmitter._getProxyEmitter( node );
-		let spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
+			domEmitter.stopListening( node );
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		domEmitter.stopListening( node );
+			// Attach same event again.
+			domEmitter.listenTo( node, 'test1', spy1c );
+			domEmitter.listenTo( node, 'test2', spy1d );
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+			// Old proxy emitter died when stopped listening to the node.
+			const proxyEmitter2 = domEmitter._getProxyEmitter( node );
+			const spy3 = testUtils.sinon.spy( proxyEmitter2, 'fire' );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		// Attach same event again.
-		domEmitter.listenTo( node, 'test1', spy1c );
-		domEmitter.listenTo( node, 'test2', spy1d );
+			expect( proxyEmitter ).to.not.be.equal( proxyEmitter2 );
 
-		// Old proxy emitter died when stopped listening to the node.
-		let proxyEmitter2 = domEmitter._getProxyEmitter( node );
-		let spy3 = testUtils.sinon.spy( proxyEmitter2, 'fire' );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledOnce( spy1c );
+			sinon.assert.calledOnce( spy1d );
+			sinon.assert.calledTwice( spy2 );
+			sinon.assert.calledTwice( spy3 );
+		} );
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+		it( 'should detach native DOM event listener proxy, everything', () => {
+			const spy1a = testUtils.sinon.spy();
+			const spy1b = testUtils.sinon.spy();
+			const spy1c = testUtils.sinon.spy();
+			const spy1d = testUtils.sinon.spy();
 
-		expect( proxyEmitter ).to.not.be.equal( proxyEmitter2 );
+			domEmitter.listenTo( node, 'test1', spy1a );
+			domEmitter.listenTo( node, 'test2', spy1b );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledOnce( spy1c );
-		sinon.assert.calledOnce( spy1d );
-		sinon.assert.calledTwice( spy2 );
-		sinon.assert.calledTwice( spy3 );
-	} );
+			const proxyEmitter = domEmitter._getProxyEmitter( node );
+			const spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
 
-	it( 'should detach native DOM event listener proxy, everything', () => {
-		let spy1a = testUtils.sinon.spy();
-		let spy1b = testUtils.sinon.spy();
-		let spy1c = testUtils.sinon.spy();
-		let spy1d = testUtils.sinon.spy();
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		domEmitter.listenTo( node, 'test1', spy1a );
-		domEmitter.listenTo( node, 'test2', spy1b );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		let proxyEmitter = domEmitter._getProxyEmitter( node );
-		let spy2 = testUtils.sinon.spy( proxyEmitter, 'fire' );
+			domEmitter.stopListening();
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledTwice( spy2 );
 
-		domEmitter.stopListening();
+			// Attach same event again.
+			domEmitter.listenTo( node, 'test1', spy1c );
+			domEmitter.listenTo( node, 'test2', spy1d );
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+			// Old proxy emitter died when stopped listening to the node.
+			const proxyEmitter2 = domEmitter._getProxyEmitter( node );
+			const spy3 = testUtils.sinon.spy( proxyEmitter2, 'fire' );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledTwice( spy2 );
+			node.dispatchEvent( new Event( 'test1' ) );
+			node.dispatchEvent( new Event( 'test2' ) );
 
-		// Attach same event again.
-		domEmitter.listenTo( node, 'test1', spy1c );
-		domEmitter.listenTo( node, 'test2', spy1d );
+			expect( proxyEmitter ).to.not.be.equal( proxyEmitter2 );
 
-		// Old proxy emitter died when stopped listening to the node.
-		let proxyEmitter2 = domEmitter._getProxyEmitter( node );
-		let spy3 = testUtils.sinon.spy( proxyEmitter2, 'fire' );
+			sinon.assert.calledOnce( spy1a );
+			sinon.assert.calledOnce( spy1b );
+			sinon.assert.calledOnce( spy1c );
+			sinon.assert.calledOnce( spy1d );
+			sinon.assert.calledTwice( spy2 );
+			sinon.assert.calledTwice( spy3 );
+		} );
+
+		// #187
+		it( 'should work for DOM Nodes belonging to another window', () => {
+			const spy = testUtils.sinon.spy();
+			const iframe = document.createElement( 'iframe' );
 
-		node.dispatchEvent( new Event( 'test1' ) );
-		node.dispatchEvent( new Event( 'test2' ) );
+			document.body.appendChild( iframe );
+			const iframeNode = iframe.contentWindow.document.createElement( 'div' );
 
-		expect( proxyEmitter ).to.not.be.equal( proxyEmitter2 );
+			domEmitter.listenTo( iframeNode, 'test', spy );
 
-		sinon.assert.calledOnce( spy1a );
-		sinon.assert.calledOnce( spy1b );
-		sinon.assert.calledOnce( spy1c );
-		sinon.assert.calledOnce( spy1d );
-		sinon.assert.calledTwice( spy2 );
-		sinon.assert.calledTwice( spy3 );
+			iframeNode.dispatchEvent( new Event( 'test' ) );
+			domEmitter.stopListening( iframeNode );
+			iframeNode.dispatchEvent( new Event( 'test' ) );
+
+			sinon.assert.calledOnce( spy );
+		} );
 	} );
 } );