Explorar o código

Removed: Range#isEmpty.

Szymon Cofalik %!s(int64=9) %!d(string=hai) anos
pai
achega
78e67415d8

+ 1 - 1
packages/ckeditor5-engine/src/controller/deletecontent.js

@@ -33,7 +33,7 @@ export default function deleteContent( selection, batch, options = {} ) {
 	const endPos = LivePosition.createFromPosition( selRange.end );
 
 	// 1. Remove the contents if there are any.
-	if ( !selRange.isEmpty ) {
+	if ( !selRange.start.isTouching( selRange.end ) ) {
 		batch.remove( selRange );
 	}
 

+ 0 - 12
packages/ckeditor5-engine/src/model/range.js

@@ -77,18 +77,6 @@ export default class Range {
 		return this.start.parent === this.end.parent;
 	}
 
-	/**
-	 * Returns whether this range has no nodes in it, that is if {@link #start start} position and
-	 * {@link #end end} position are {@link module:engine/model/position~Position#isTouching touching}.
-	 *
-	 * **Note:** A range may be empty, but not {@link #isCollapsed collapsed}.
-	 *
-	 * @type {Boolean}
-	 */
-	get isEmpty() {
-		return this.start.isTouching( this.end );
-	}
-
 	/**
 	 * Range root element.
 	 *

+ 0 - 16
packages/ckeditor5-engine/tests/model/range.js

@@ -954,22 +954,6 @@ describe( 'Range', () => {
 		} );
 	} );
 
-	describe( 'isEmpty', () => {
-		beforeEach( () => {
-			prepareRichRoot( root );
-		} );
-
-		it( 'should be true if there are no nodes between range start and end', () => {
-			let range = new Range( new Position( root, [ 0, 0, 5 ] ), new Position( root, [ 0, 1, 0 ] ) );
-			expect( range.isEmpty ).to.be.true;
-		} );
-
-		it( 'should be false if there are nodes between range start and end', () => {
-			let range = new Range( new Position( root, [ 0, 0, 5 ] ), new Position( root, [ 0, 1, 1 ] ) );
-			expect( range.isEmpty ).to.be.false;
-		} );
-	} );
-
 	function mapNodesToNames( nodes ) {
 		return nodes.map( ( node ) => {
 			return ( node instanceof Element ) ? 'E:' + node.name : 'T:' + node.data;