Sfoglia il codice sorgente

view.Document.createRoot - root name will always be transform to lower case.

Kamil Piechaczek 9 anni fa
parent
commit
71adbda8a5

+ 3 - 1
packages/ckeditor5-engine/src/view/document.js

@@ -162,6 +162,8 @@ export default class Document {
 	 *		document.createRoot( 'body' );
 	 *		document.attachDomRoot( document.querySelector( 'body#editor' ) );
 	 *
+	 * In both cases, rootName is always transform to lower case.
+	 *
 	 * @param {Element|String} domRoot DOM root element or the tag name of view root element if the DOM element will be
 	 * attached later.
 	 * @param {String} [name='main'] Name of the root.
@@ -170,7 +172,7 @@ export default class Document {
 	createRoot( domRoot, name = 'main' ) {
 		const rootTag = typeof domRoot == 'string' ? domRoot : domRoot.tagName;
 
-		const viewRoot = new RootEditableElement( this, rootTag, name );
+		const viewRoot = new RootEditableElement( this, rootTag.toLowerCase(), name );
 
 		this.roots.set( name, viewRoot );
 

+ 3 - 2
packages/ckeditor5-engine/tests/view/document/document.js

@@ -80,7 +80,7 @@ describe( 'Document', () => {
 			expect( domRoot ).to.equal( domDiv );
 			expect( viewDocument.domConverter.getCorrespondingDom( viewRoot ) ).to.equal( domDiv );
 
-			expect( viewRoot.name.toLowerCase() ).to.equal( 'div' );
+			expect( viewRoot.name ).to.equal( 'div' );
 			expect( viewDocument.renderer.markedChildren.has( viewRoot ) ).to.be.true;
 		} );
 
@@ -173,7 +173,7 @@ describe( 'Document', () => {
 			const domH1 = document.createElement( 'h1' );
 
 			const viewDocument = new Document();
-			viewDocument.createRoot( 'div' );
+			viewDocument.createRoot( 'DIV' );
 			const viewH1 = viewDocument.createRoot( 'h1', 'header' );
 
 			expect( count( viewDocument.domRoots ) ).to.equal( 0 );
@@ -188,6 +188,7 @@ describe( 'Document', () => {
 			expect( viewDocument.getDomRoot( 'header' ) ).to.equal( domH1 );
 			expect( viewDocument.domConverter.getCorrespondingDom( viewH1 ) ).to.equal( domH1 );
 
+			expect( viewDocument.getRoot().name ).to.equal( 'div' );
 			expect( viewDocument.renderer.markedChildren.has( viewH1 ) ).to.be.true;
 		} );
 	} );