Browse Source

Changed: Removed `addDefaultBehavior()` from dropdown utils.

Maciej Gołaszewski 7 years ago
parent
commit
6ffee608cf

+ 0 - 6
packages/ckeditor5-ui/src/dropdown/utils.js

@@ -251,12 +251,6 @@ export function addToolbarToDropdown( dropdownView, model ) {
 	return toolbarView;
 }
 
-export function addDefaultBehavior( dropdownView ) {
-	closeDropdownOnBlur( dropdownView );
-	closeDropdownOnExecute( dropdownView );
-	focusDropdownContentsOnArrows( dropdownView );
-}
-
 // Returns an array of binding components for
 // {@link module:utils/observablemixin~Observable#bind} from a set of iterable
 // buttons.

+ 10 - 4
packages/ckeditor5-ui/tests/dropdown/manual/dropdown.js

@@ -16,12 +16,14 @@ import alignCenterIcon from '@ckeditor/ckeditor5-core/theme/icons/object-center.
 import ButtonView from '../../../src/button/buttonview';
 
 import {
-	addDefaultBehavior,
 	addListViewToDropdown,
 	addToolbarToDropdown,
+	closeDropdownOnBlur,
+	closeDropdownOnExecute,
 	createButtonForDropdown,
 	createDropdownView,
-	createSingleButtonDropdown
+	createSingleButtonDropdown,
+	focusDropdownContentsOnArrows,
 } from '../../../src/dropdown/utils';
 
 const ui = testUtils.createTestUIView( {
@@ -69,7 +71,9 @@ function testList() {
 	const dropdownView = createSingleButtonDropdown( model, {} );
 
 	addListViewToDropdown( dropdownView, model, {} );
-	addDefaultBehavior( dropdownView );
+	closeDropdownOnBlur( dropdownView );
+	closeDropdownOnExecute( dropdownView );
+	focusDropdownContentsOnArrows( dropdownView );
 
 	dropdownView.on( 'execute', evt => {
 		/* global console */
@@ -146,7 +150,9 @@ function testButton() {
 	const toolbarDropdown = createSingleButtonDropdown( toolbarDropdownModel, {} );
 
 	addToolbarToDropdown( toolbarDropdown, toolbarDropdownModel );
-	addDefaultBehavior( toolbarDropdown );
+	closeDropdownOnBlur( toolbarDropdown );
+	closeDropdownOnExecute( toolbarDropdown );
+	focusDropdownContentsOnArrows( toolbarDropdown );
 
 	ui.toolbarDropdown.add( toolbarDropdown );
 

+ 0 - 2
packages/ckeditor5-ui/tests/dropdown/utils.js

@@ -501,7 +501,5 @@ describe( 'utils', () => {
 		} );
 	} );
 
-	describe( 'addDefaultBehavior()', () => {} );
-
 	describe( 'getBindingTargets()', () => {} );
 } );