Răsfoiți Sursa

Merge branch 'master' into t/12

Piotrek Koszuliński 7 ani în urmă
părinte
comite
6f655cf787

+ 17 - 0
packages/ckeditor5-table/src/ui/inserttableview.js

@@ -17,6 +17,7 @@ import './../../theme/inserttable.css';
  * It renders a 10x10 grid to choose inserted table size.
  *
  * @extends module:ui/view~View
+ * @implements module:ui/dropdown/dropdownpanelfocusable~DropdownPanelFocusable
  */
 export default class InsertTableView extends View {
 	/**
@@ -125,6 +126,22 @@ export default class InsertTableView extends View {
 		} );
 	}
 
+	/**
+	 * @inheritDoc
+	 */
+	focus() {
+		// The dropdown panel expects DropdownPanelFocusable interface on views passed to dropdown panel. See #30.
+		// The method should be implemented while working on keyboard support for this view. See #22.
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	focusLast() {
+		// The dropdown panel expects DropdownPanelFocusable interface on views passed to dropdown panel. See #30.
+		// The method should be implemented while working on keyboard support for this view. See #22.
+	}
+
 	/**
 	 * Highlights grid boxes depending on rows & columns selected.
 	 *

+ 5 - 0
packages/ckeditor5-table/tests/ui/inserttableview.js

@@ -54,6 +54,11 @@ describe( 'InsertTableView', () => {
 			expect( view.items ).to.have.length( 100 );
 		} );
 
+		it( 'should not throw error for DropdownPanelFocusable interface methods', () => {
+			expect( () => view.focus() ).to.not.throw();
+			expect( () => view.focusLast() ).to.not.throw();
+		} );
+
 		describe( 'view#items bindings', () => {
 			it( 'updates view#height & view#width on "over" event', () => {
 				const boxView = view.items.get( 0 );

+ 3 - 5
packages/ckeditor5-table/theme/table.css

@@ -11,11 +11,9 @@
 	border-collapse: collapse;
 	border-spacing: 0;
 
-	/* The outer border of the table should be slightly darker than the inner lines. */
-	&:not(:hover) {
-		outline: 1px solid hsl(0, 0%, 70%);
-		outline-offset: -1px;
-	}
+	/* The outer border of the table should be slightly darker than the inner lines.
+	Also see https://github.com/ckeditor/ckeditor5-table/issues/50. */
+	border: 1px double hsl(0, 0%, 70%);
 
 	& td,
 	& th {