Bladeren bron

Code refactoring.

Aleksander Nowodzinski 8 jaren geleden
bovenliggende
commit
690c9de896
2 gewijzigde bestanden met toevoegingen van 3 en 3 verwijderingen
  1. 2 2
      packages/ckeditor5-heading/src/heading.js
  2. 1 1
      packages/ckeditor5-heading/src/headingengine.js

+ 2 - 2
packages/ckeditor5-heading/src/heading.js

@@ -40,7 +40,7 @@ export default class Heading extends Plugin {
 		const collection = new Collection();
 
 		// Add formats to collection.
-		for ( let { id, label } of formats ) {
+		for ( const { id, label } of formats ) {
 			collection.add( new Model( {
 				formatId: id,
 				label: label
@@ -55,7 +55,7 @@ export default class Heading extends Plugin {
 
 		// Bind dropdown model to command.
 		dropdownModel.bind( 'isEnabled' ).to( command, 'isEnabled' );
-		dropdownModel.bind( 'label' ).to( command, 'value', ( { label } ) => label );
+		dropdownModel.bind( 'label' ).to( command, 'value', format => format.label );
 
 		// Register UI component.
 		editor.ui.componentFactory.add( 'headings', ( locale ) => {

+ 1 - 1
packages/ckeditor5-heading/src/headingengine.js

@@ -109,7 +109,7 @@ export default class HeadingEngine extends Plugin {
 			this.listenTo( enterCommand, 'afterExecute', ( evt, data ) => {
 				const positionParent = editor.document.selection.getFirstPosition().parent;
 				const batch = data.batch;
-				const isHeading = formats.some( ( { id } ) => id == positionParent.name );
+				const isHeading = formats.some( format => format.id == positionParent.name );
 
 				if ( isHeading && positionParent.name != command.defaultFormat.id && positionParent.childCount === 0 ) {
 					batch.rename( positionParent, command.defaultFormat.id );