Przeglądaj źródła

Tests: Fixed tests leaking editor instance / DOM element.

Marek Lewandowski 6 lat temu
rodzic
commit
5b59c11422

+ 6 - 2
packages/ckeditor5-ui/tests/dropdown/dropdownview.js

@@ -186,7 +186,7 @@ describe( 'DropdownView', () => {
 
 
 	describe( 'render()', () => {
 	describe( 'render()', () => {
 		it( 'starts listening for #keystrokes coming from #element', () => {
 		it( 'starts listening for #keystrokes coming from #element', () => {
-			view = new DropdownView( locale,
+			const view = new DropdownView( locale,
 				new ButtonView( locale ),
 				new ButtonView( locale ),
 				new DropdownPanelView( locale ) );
 				new DropdownPanelView( locale ) );
 
 
@@ -195,10 +195,12 @@ describe( 'DropdownView', () => {
 			view.render();
 			view.render();
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledWithExactly( spy, view.element );
 			sinon.assert.calledWithExactly( spy, view.element );
+
+			view.element.remove();
 		} );
 		} );
 
 
 		it( 'adds #element to #focusTracker', () => {
 		it( 'adds #element to #focusTracker', () => {
-			view = new DropdownView( locale,
+			const view = new DropdownView( locale,
 				new ButtonView( locale ),
 				new ButtonView( locale ),
 				new DropdownPanelView( locale ) );
 				new DropdownPanelView( locale ) );
 
 
@@ -207,6 +209,8 @@ describe( 'DropdownView', () => {
 			view.render();
 			view.render();
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledWithExactly( spy, view.element );
 			sinon.assert.calledWithExactly( spy, view.element );
+
+			view.element.remove();
 		} );
 		} );
 
 
 		describe( 'activates keyboard navigation for the dropdown', () => {
 		describe( 'activates keyboard navigation for the dropdown', () => {