Explorar el Código

Merge pull request #325 from ckeditor/t/312

Tests: Cleanup promise use in tests. Closes #312.
Piotrek Koszuliński hace 6 años
padre
commit
566dac4523

+ 3 - 2
packages/ckeditor5-image/tests/image/imageediting.js

@@ -68,7 +68,7 @@ describe( 'ImageEditing', () => {
 		const element = document.createElement( 'div' );
 		document.body.appendChild( element );
 
-		ClassicTestEditor.create( element, {
+		return ClassicTestEditor.create( element, {
 			plugins: [ ImageEditing ]
 		} ).then( editor => {
 			editor.data.set( '<figure class="image"><img src="/assets/sample.png" alt="bar" /></figure>' );
@@ -77,7 +77,8 @@ describe( 'ImageEditing', () => {
 
 			editor.ui.on( 'update', spy );
 
-			element.querySelector( 'img' ).dispatchEvent( new Event( 'load' ) );
+			const htmlImageElement = editor.ui.getEditableElement().querySelector( 'img' );
+			htmlImageElement.dispatchEvent( new Event( 'load' ) );
 
 			sinon.assert.calledOnce( spy );
 

+ 1 - 1
packages/ckeditor5-image/tests/imageupload/imageuploadediting.js

@@ -707,7 +707,7 @@ describe( 'ImageUploadEditing', () => {
 
 		// Stub `fetch` so it can be rejected.
 		sinon.stub( window, 'fetch' ).callsFake( () => {
-			return new Promise( ( res, rej ) => rej() );
+			return new Promise( ( res, rej ) => rej( 'could not fetch' ) );
 		} );
 
 		viewDocument.fire( 'clipboardInput', { dataTransfer, targetRanges: [ targetViewRange ] } );