Przeglądaj źródła

Tests: Update tests to the recent changes in widgets API.

Maciej Gołaszewski 7 lat temu
rodzic
commit
513033406e

+ 8 - 0
packages/ckeditor5-image/tests/image.js

@@ -12,11 +12,17 @@ import { setData as setModelData } from '@ckeditor/ckeditor5-engine/src/dev-util
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 import ModelRange from '@ckeditor/ckeditor5-engine/src/model/range';
 import global from '@ckeditor/ckeditor5-utils/src/dom/global';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 describe( 'Image', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editorElement, model, view, editor, document, viewDocument;
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		editorElement = global.document.createElement( 'div' );
 		global.document.body.appendChild( editorElement );
 
@@ -34,6 +40,8 @@ describe( 'Image', () => {
 	} );
 
 	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+
 		editorElement.remove();
 
 		return editor.destroy();

+ 10 - 0
packages/ckeditor5-image/tests/image/converters.js

@@ -17,11 +17,17 @@ import { upcastElementToElement } from '@ckeditor/ckeditor5-engine/src/conversio
 import ModelRange from '@ckeditor/ckeditor5-engine/src/model/range';
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 import { setData as setModelData, getData as getModelData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 describe( 'Image converters', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editor, model, document, viewDocument;
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		return VirtualTestEditor.create()
 			.then( newEditor => {
 				editor = newEditor;
@@ -52,6 +58,10 @@ describe( 'Image converters', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	describe( 'viewFigureToModel', () => {
 		function expectModel( data ) {
 			expect( getModelData( model, { withoutSelection: true } ) ).to.equal( data );

+ 10 - 0
packages/ckeditor5-image/tests/image/imageediting.js

@@ -13,11 +13,17 @@ import { getData as getModelData, setData as setModelData } from '@ckeditor/cked
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 import { isImageWidget } from '../../src/image/utils';
 import normalizeHtml from '@ckeditor/ckeditor5-utils/tests/_utils/normalizehtml';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 describe( 'ImageEditing', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editor, model, doc, view, viewDocument;
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		return VirtualTestEditor
 			.create( {
 				plugins: [ ImageEditing ]
@@ -31,6 +37,10 @@ describe( 'ImageEditing', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	it( 'should be loaded', () => {
 		expect( editor.plugins.get( ImageEditing ) ).to.be.instanceOf( ImageEditing );
 	} );

+ 11 - 0
packages/ckeditor5-image/tests/imagecaption/imagecaptionediting.js

@@ -18,10 +18,17 @@ import ModelRange from '@ckeditor/ckeditor5-engine/src/model/range';
 import { getData as getModelData, setData as setModelData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 
+import env from '@ckeditor/ckeditor5-utils/src/env';
+
 describe( 'ImageCaptionEditing', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editor, model, doc, view;
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		return VirtualTestEditor
 			.create( {
 				plugins: [ ImageCaptionEditing, ImageEditing, UndoEditing, Paragraph ]
@@ -43,6 +50,10 @@ describe( 'ImageCaptionEditing', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	it( 'should be loaded', () => {
 		expect( editor.plugins.get( ImageCaptionEditing ) ).to.be.instanceOf( ImageCaptionEditing );
 	} );

+ 9 - 0
packages/ckeditor5-image/tests/imagestyle/imagestyleediting.js

@@ -12,13 +12,22 @@ import { getData as getModelData, setData as setModelData } from '@ckeditor/cked
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 testUtils.createSinonSandbox();
 
 describe( 'ImageStyleEditing', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editor, model, document, viewDocument;
 
+	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+	} );
+
 	afterEach( () => {
+		env.isEdge = initialEnvEdge;
 		editor.destroy();
 	} );
 

+ 9 - 0
packages/ckeditor5-image/tests/imagetextalternative/ui/textalternativeformview.js

@@ -13,16 +13,25 @@ import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';
 import FocusCycler from '@ckeditor/ckeditor5-ui/src/focuscycler';
 import ViewCollection from '@ckeditor/ckeditor5-ui/src/viewcollection';
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 testUtils.createSinonSandbox();
 
 describe( 'TextAlternativeFormView', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let view;
 
 	beforeEach( () => {
+		env.isEdge = false;
+
 		view = new TextAlternativeFormView( { t: () => {} } );
 	} );
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	describe( 'constructor()', () => {
 		it( 'should create element from template', () => {
 			view.render();

+ 8 - 0
packages/ckeditor5-image/tests/imagetoolbar.js

@@ -15,11 +15,17 @@ import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
 import Range from '@ckeditor/ckeditor5-engine/src/model/range';
 import View from '@ckeditor/ckeditor5-ui/src/view';
 import { setData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 describe( 'ImageToolbar', () => {
+	const initialEnvEdge = env.isEdge;
+
 	let editor, model, doc, plugin, toolbar, balloon, editorElement;
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		editorElement = global.document.createElement( 'div' );
 		global.document.body.appendChild( editorElement );
 
@@ -41,6 +47,8 @@ describe( 'ImageToolbar', () => {
 	} );
 
 	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+
 		editorElement.remove();
 
 		return editor.destroy();

+ 7 - 0
packages/ckeditor5-image/tests/imageupload/imageuploadediting.js

@@ -25,10 +25,12 @@ import Range from '@ckeditor/ckeditor5-engine/src/model/range';
 import Position from '@ckeditor/ckeditor5-engine/src/model/position';
 
 import log from '@ckeditor/ckeditor5-utils/src/log';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
 import Notification from '@ckeditor/ckeditor5-ui/src/notification/notification';
 
 describe( 'ImageUploadEditing', () => {
+	const initialEnvEdge = env.isEdge;
 	// eslint-disable-next-line max-len
 	const base64Sample = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=';
 	let editor, model, view, doc, fileRepository, viewDocument, nativeReaderMock, loader, adapterMock;
@@ -48,6 +50,9 @@ describe( 'ImageUploadEditing', () => {
 	}
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		testUtils.sinon.stub( window, 'FileReader' ).callsFake( () => {
 			nativeReaderMock = new NativeFileReaderMock();
 
@@ -68,6 +73,8 @@ describe( 'ImageUploadEditing', () => {
 	} );
 
 	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+
 		return editor.destroy();
 	} );
 

+ 11 - 0
packages/ckeditor5-image/tests/imageupload/imageuploadprogress.js

@@ -20,7 +20,11 @@ import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
 import svgPlaceholder from '../../theme/icons/image_placeholder.svg';
 
+import env from '@ckeditor/ckeditor5-utils/src/env';
+
 describe( 'ImageUploadProgress', () => {
+	const initialEnvEdge = env.isEdge;
+
 	const imagePlaceholder = encodeURIComponent( svgPlaceholder );
 
 	// eslint-disable-next-line max-len
@@ -42,6 +46,9 @@ describe( 'ImageUploadProgress', () => {
 	testUtils.createSinonSandbox();
 
 	beforeEach( () => {
+		// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+		env.isEdge = false;
+
 		testUtils.sinon.stub( window, 'FileReader' ).callsFake( () => {
 			nativeReaderMock = new NativeFileReaderMock();
 
@@ -68,6 +75,10 @@ describe( 'ImageUploadProgress', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		env.isEdge = initialEnvEdge;
+	} );
+
 	it( 'should convert image\'s "reading" uploadStatus attribute', () => {
 		setModelData( model, '<paragraph>[]foo</paragraph>' );
 		editor.execute( 'imageUpload', { file: createNativeFileMock() } );

+ 7 - 0
packages/ckeditor5-image/tests/integration.js

@@ -11,12 +11,18 @@ import global from '@ckeditor/ckeditor5-utils/src/dom/global';
 import Image from '../src/image';
 import ImageToolbar from '../src/imagetoolbar';
 import View from '@ckeditor/ckeditor5-ui/src/view';
+import env from '@ckeditor/ckeditor5-utils/src/env';
 
 describe( 'ImageToolbar integration', () => {
+	const initialEnvEdge = env.isEdge;
+
 	describe( 'with the BalloonToolbar', () => {
 		let balloon, balloonToolbar, newEditor, editorElement;
 
 		beforeEach( () => {
+			// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
+			env.isEdge = false;
+
 			editorElement = global.document.createElement( 'div' );
 			global.document.body.appendChild( editorElement );
 
@@ -42,6 +48,7 @@ describe( 'ImageToolbar integration', () => {
 		} );
 
 		afterEach( () => {
+			env.isEdge = initialEnvEdge;
 			editorElement.remove();
 			return newEditor.destroy();
 		} );