8
0
Просмотр исходного кода

Use to.have.property assertion, to make test results more descriptive.

Tomek Wytrębowicz 5 лет назад
Родитель
Сommit
50dc07f5d4

+ 3 - 4
packages/ckeditor5-link/tests/linkediting.js

@@ -256,7 +256,7 @@ describe( 'LinkEditing', () => {
 				domTarget: document.body
 			} );
 
-			expect( model.document.selection.isGravityOverridden ).to.be.true;
+			expect( model.document.selection ).to.have.property( 'isGravityOverridden', true );
 
 			model.change( writer => {
 				model.insertContent( writer.createText( 'INSERTED', { bold: true } ) );
@@ -270,8 +270,7 @@ describe( 'LinkEditing', () => {
 				'</paragraph>'
 			);
 
-			expect( model.document.selection.isGravityOverridden ).to.be.true;
-
+			expect( model.document.selection ).to.have.property( 'isGravityOverridden', true );
 			expect( model.document.selection ).to.have.attribute( 'linkHref' );
 		} );
 
@@ -296,7 +295,7 @@ describe( 'LinkEditing', () => {
 		it( 'should not remove link atttributes when pasting before another link (different URLs, no merge)', () => {
 			setModelData( model, '<paragraph>[]<$text linkHref="ckeditor.com">foo</$text></paragraph>' );
 
-			expect( model.document.selection.isGravityOverridden ).to.be.false;
+			expect( model.document.selection ).to.have.property( 'isGravityOverridden', false );
 
 			model.change( writer => {
 				model.insertContent( writer.createText( 'INSERTED', { linkHref: 'http://INSERTED' } ) );

+ 13 - 12
packages/ckeditor5-typing/tests/twostepcaretmovement.js

@@ -511,7 +511,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			} );
 
 			// <$text a="1">x</$text><$text b="1">[]</$text>
-			expect( selection.isGravityOverridden ).to.be.true;
+			expect( selection ).to.have.property( 'isGravityOverridden', true );
 			expect( getSelectionAttributesArray( selection ) ).to.have.members( [ 'b' ] );
 
 			model.change( writer => {
@@ -519,7 +519,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			} );
 
 			// <$text a="1">x</$text><$text b="1">yz[]</$text>
-			expect( selection.isGravityOverridden ).to.be.false;
+			expect( selection ).to.have.property( 'isGravityOverridden', false );
 			expect( getSelectionAttributesArray( selection ) ).to.have.members( [ 'b' ] );
 		} );
 
@@ -539,7 +539,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			} );
 
 			// <$text b="1">[]</$text><$text a="1">x</$text>
-			expect( selection.isGravityOverridden ).to.be.false;
+			expect( selection ).to.have.property( 'isGravityOverridden', false );
 			expect( getSelectionAttributesArray( selection ) ).to.have.members( [ 'b' ] );
 
 			model.change( writer => {
@@ -547,7 +547,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			} );
 
 			// <$text b="1">yz[]</$text><$text a="1">x</$text>
-			expect( selection.isGravityOverridden ).to.be.false;
+			expect( selection ).to.have.property( 'isGravityOverridden', false );
 			expect( getSelectionAttributesArray( selection ) ).to.have.members( [ 'b' ] );
 		} );
 	} );
@@ -646,13 +646,13 @@ describe( 'TwoStepCaretMovement()', () => {
 		it( 'should not override gravity when selection is placed at the beginning of text', () => {
 			setData( model, '<$text a="true">[]foo</$text>' );
 
-			expect( selection.isGravityOverridden ).to.be.false;
+			expect( selection ).to.have.property( 'isGravityOverridden', false );
 		} );
 
 		it( 'should not override gravity when selection is placed at the end of text', () => {
 			setData( model, '<$text a="true">foo[]</$text>' );
 
-			expect( selection.isGravityOverridden ).to.be.false;
+			expect( selection ).to.have.property( 'isGravityOverridden', false );
 		} );
 	} );
 
@@ -693,7 +693,7 @@ describe( 'TwoStepCaretMovement()', () => {
 
 		fireKeyDownEvent( { keyCode: keyCodes.arrowright } );
 
-		expect( selection.isGravityOverridden ).to.be.false;
+		expect( selection ).to.have.property( 'isGravityOverridden', false );
 	} );
 
 	it( 'should do nothing when shift key is pressed', () => {
@@ -704,7 +704,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			shiftKey: true
 		} );
 
-		expect( selection.isGravityOverridden ).to.be.false;
+		expect( selection ).to.have.property( 'isGravityOverridden', false );
 	} );
 
 	it( 'should do nothing when alt key is pressed', () => {
@@ -715,7 +715,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			altKey: true
 		} );
 
-		expect( selection.isGravityOverridden ).to.be.false;
+		expect( selection ).to.have.property( 'isGravityOverridden', false );
 	} );
 
 	it( 'should do nothing when ctrl key is pressed', () => {
@@ -726,7 +726,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			ctrlKey: true
 		} );
 
-		expect( selection.isGravityOverridden ).to.be.false;
+		expect( selection ).to.have.property( 'isGravityOverridden', false );
 	} );
 
 	it( 'should do nothing when the not a direct selection change but at the attribute boundary', () => {
@@ -743,7 +743,7 @@ describe( 'TwoStepCaretMovement()', () => {
 			writer.insertText( 'x', selection.getFirstPosition().getShiftedBy( -2 ) );
 		} );
 
-		expect( selection.isGravityOverridden ).to.be.true;
+		expect( selection ).to.have.property( 'isGravityOverridden', true );
 		expect( getSelectionAttributesArray( selection ) ).to.have.members( [] );
 	} );
 
@@ -910,7 +910,8 @@ describe( 'TwoStepCaretMovement()', () => {
 
 				expect( getSelectionAttributesArray( selection ) ).to.have.members(
 					step.selectionAttributes, `#attributes ${ stepString }` );
-				expect( selection.isGravityOverridden ).to.equal( step.isGravityOverridden, `#isGravityOverridden ${ stepString }` );
+				expect( selection, `#isGravityOverridden ${ stepString }` )
+					.to.have.property( 'isGravityOverridden', step.isGravityOverridden );
 				expect( preventDefaultSpy.callCount ).to.equal( step.preventDefault, `#preventDefault ${ stepString }` );
 				expect( evtStopSpy.callCount ).to.equal( step.evtStopCalled, `#evtStopCalled ${ stepString }` );
 			}