Browse Source

Merge pull request #1812 from ckeditor/i/6002

Tests: Fixed tests leaking editor instances / DOM elements. See ckeditor/ckeditor5#6002.
Kamil Piechaczek 6 years ago
parent
commit
501d045f53

+ 5 - 0
packages/ckeditor5-engine/tests/view/observer/focusobserver.js

@@ -165,6 +165,11 @@ describe( 'FocusObserver', () => {
 			observer = view.getObserver( FocusObserver );
 		} );
 
+		afterEach( () => {
+			view.destroy();
+			domRoot.remove();
+		} );
+
 		it( 'should always render document after selectionChange event', done => {
 			const selectionChangeSpy = sinon.spy();
 			const renderSpy = sinon.spy();

+ 7 - 0
packages/ckeditor5-engine/tests/view/renderer.js

@@ -2009,6 +2009,8 @@ describe( 'Renderer', () => {
 				container = document.getSelection().anchorNode;
 
 				expect( domEditable.contains( container ) ).to.be.true;
+
+				domEditable.remove();
 			} );
 
 			it( 'should bind fake selection container to view selection', () => {
@@ -3721,6 +3723,11 @@ describe( 'Renderer', () => {
 			converter = view.domConverter;
 		} );
 
+		afterEach( () => {
+			view.destroy();
+			domRoot.remove();
+		} );
+
 		it( 'should properly render unwrapped attributes #1', () => {
 			setViewData( view,
 				'<container:p>' +