浏览代码

Internal: ResizerOptions interface no longer has the downcastWriter property.

Also linting: fixed line that violated 140 chars policy. This line skipped linter as it was commit straight from GH web interface.

MINOR BREAKING CHANGE: Removed downcastWriter property from the ResizerOptions interface.
Marek Lewandowski 6 年之前
父节点
当前提交
500f768763
共有 2 个文件被更改,包括 23 次插入24 次删除
  1. 1 5
      packages/ckeditor5-widget/src/widgetresize.js
  2. 22 19
      packages/ckeditor5-widget/src/widgetresize/resizer.js

+ 1 - 5
packages/ckeditor5-widget/src/widgetresize.js

@@ -193,10 +193,6 @@ mix( WidgetResize, ObservableMixin );
  */
 
 /**
- * @member {module:engine/view/downcastwriter~DowncastWriter} module:widget/widgetresize~ResizerOptions#downcastWriter
- */
-
-/**
  * A callback to be executed once the resizing process is done.
  *
  * It receives a `Number` (`newValue`) as a parameter.
@@ -206,9 +202,9 @@ mix( WidgetResize, ObservableMixin );
  *
  * ```js
  * {
+ *	editor,
  *	modelElement: data.item,
  *	viewElement: widget,
- *	downcastWriter: conversionApi.writer,
  *
  *	onCommit( newValue ) {
  *		editor.execute( 'imageResize', { width: newValue } );

+ 22 - 19
packages/ckeditor5-widget/src/widgetresize/resizer.js

@@ -81,7 +81,8 @@ export default class Resizer {
 		this.decorate( 'updateSize' );
 
 		this.on( 'commit', event => {
-			// State might not be initialized yet. In this case, prevent further handling and make sure that the resizer is cleaned up (#5195).
+			// State might not be initialized yet. In this case, prevent further handling and make sure that the resizer is
+			// cleaned up (#5195).
 			if ( !this.state.proposedWidth ) {
 				this._cleanup();
 				event.stop();
@@ -95,32 +96,34 @@ export default class Resizer {
 	attach() {
 		const that = this;
 		const widgetElement = this._options.viewElement;
-		const writer = this._options.downcastWriter;
+		const editingView = this._options.editor.editing.view;
 
-		const viewResizerWrapper = writer.createUIElement( 'div', {
-			class: 'ck ck-reset_all ck-widget__resizer'
-		}, function( domDocument ) {
-			const domElement = this.toDomElement( domDocument );
+		editingView.change( writer => {
+			const viewResizerWrapper = writer.createUIElement( 'div', {
+				class: 'ck ck-reset_all ck-widget__resizer'
+			}, function( domDocument ) {
+				const domElement = this.toDomElement( domDocument );
 
-			that._appendHandles( domElement );
-			that._appendSizeUI( domElement );
+				that._appendHandles( domElement );
+				that._appendSizeUI( domElement );
 
-			that._domResizerWrapper = domElement;
+				that._domResizerWrapper = domElement;
 
-			that.on( 'change:isEnabled', ( evt, propName, newValue ) => {
-				domElement.style.display = newValue ? '' : 'none';
-			} );
+				that.on( 'change:isEnabled', ( evt, propName, newValue ) => {
+					domElement.style.display = newValue ? '' : 'none';
+				} );
 
-			domElement.style.display = that.isEnabled ? '' : 'none';
+				domElement.style.display = that.isEnabled ? '' : 'none';
 
-			return domElement;
-		} );
+				return domElement;
+			} );
 
-		// Append the resizer wrapper to the widget's wrapper.
-		writer.insert( writer.createPositionAt( widgetElement, 'end' ), viewResizerWrapper );
-		writer.addClass( 'ck-widget_with-resizer', widgetElement );
+			// Append the resizer wrapper to the widget's wrapper.
+			writer.insert( writer.createPositionAt( widgetElement, 'end' ), viewResizerWrapper );
+			writer.addClass( 'ck-widget_with-resizer', widgetElement );
 
-		this._viewResizerWrapper = viewResizerWrapper;
+			this._viewResizerWrapper = viewResizerWrapper;
+		} );
 	}
 
 	/**