瀏覽代碼

Early return instead of braking a loop.

Piotrek Koszuliński 11 年之前
父節點
當前提交
4559bcb7f4
共有 1 個文件被更改,包括 3 次插入6 次删除
  1. 3 6
      packages/ckeditor5-ui/src/emitter.js

+ 3 - 6
packages/ckeditor5-ui/src/emitter.js

@@ -26,7 +26,6 @@ CKEDITOR.define( [ 'eventinfo', 'utils' ], function( EventInfo, utils ) {
 		 */
 		on: function( event, callback, ctx, priority ) {
 			var callbacks = getCallbacks( this, event );
-			var wasAdded;
 
 			// Priority defaults to 10.
 			if ( typeof priority != 'number' ) {
@@ -43,14 +42,12 @@ CKEDITOR.define( [ 'eventinfo', 'utils' ], function( EventInfo, utils ) {
 			for ( var i = 0; i < callbacks.length; i++ ) {
 				if ( callbacks[ i ].priority > priority ) {
 					callbacks.splice( i, 0, callback );
-					wasAdded = true;
-					break;
+
+					return;
 				}
 			}
 
-			if ( !wasAdded ) {
-				callbacks.push( callback );
-			}
+			callbacks.push( callback );
 		},
 
 		/**