浏览代码

Changed const from upper case to lower case.

Kamil Piechaczek 9 年之前
父节点
当前提交
44c59c3b60

+ 3 - 5
packages/ckeditor5-typing/src/delete.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import Feature from '../feature.js';
 import DeleteCommand from './deletecommand.js';
 import DeleteObserver from './deleteobserver.js';
@@ -22,11 +20,11 @@ export default class Delete extends Feature {
 
 		editingView.addObserver( DeleteObserver );
 
-		editor.commands.set( 'forwardDelete', new DeleteCommand( editor, 'FORWARD' ) );
-		editor.commands.set( 'delete', new DeleteCommand( editor, 'BACKWARD' ) );
+		editor.commands.set( 'forwardDelete', new DeleteCommand( editor, 'forward' ) );
+		editor.commands.set( 'delete', new DeleteCommand( editor, 'backward' ) );
 
 		this.listenTo( editingView, 'delete', ( evt, data ) => {
-			editor.execute( data.direction == 'FORWARD' ? 'forwardDelete' : 'delete' );
+			editor.execute( data.direction == 'forward' ? 'forwardDelete' : 'delete' );
 			data.preventDefault();
 		} );
 	}

+ 3 - 5
packages/ckeditor5-typing/src/deletecommand.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import Command from '../command/command.js';
 import Selection from '../engine/model/selection.js';
 import ChangeBuffer from './changebuffer.js';
@@ -22,7 +20,7 @@ export default class DeleteCommand extends Command {
 	 * Creates instance of the command;
 	 *
 	 * @param {ckeditor5.Editor} editor
-	 * @param {'FORWARD'|'BACKWARD'} direction The directionality of the delete (in what direction it should
+	 * @param {'forward'|'backward'} direction The directionality of the delete (in what direction it should
 	 * consume the content when selection is collapsed).
 	 */
 	constructor( editor, direction ) {
@@ -33,7 +31,7 @@ export default class DeleteCommand extends Command {
 		 * consume the content when selection is collapsed).
 		 *
 		 * @readonly
-		 * @member {'FORWARD'|'BACKWARD'} typing.DeleteCommand#direction
+		 * @member {'forward'|'backward'} typing.DeleteCommand#direction
 		 */
 		this.direction = direction;
 
@@ -52,7 +50,7 @@ export default class DeleteCommand extends Command {
 	 * or piece of content in the {@link typing.DeleteCommand#direction defined direction}.
 	 *
 	 * @param {Object} [options] The command options.
-	 * @param {'CHARACTER'} [options.unit='CHARACTER'] See {@link engine.model.composer.modifySelection}'s options.
+	 * @param {'character'} [options.unit='character'] See {@link engine.model.composer.modifySelection}'s options.
 	 */
 	_doExecute( options = {} ) {
 		const doc = this.editor.document;

+ 5 - 7
packages/ckeditor5-typing/src/deleteobserver.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import Observer from '../engine/view/observer/observer.js';
 import DomEventData from '../engine/view/observer/domeventdata.js';
 import { keyCodes } from '../utils/keyboard.js';
@@ -23,14 +21,14 @@ export default class DeleteObserver extends Observer {
 			const deleteData = {};
 
 			if ( data.keyCode == keyCodes.delete ) {
-				deleteData.direction = 'FORWARD';
+				deleteData.direction = 'forward';
 			} else if ( data.keyCode == keyCodes.backspace ) {
-				deleteData.direction = 'BACKWARD';
+				deleteData.direction = 'backward';
 			} else {
 				return;
 			}
 
-			deleteData.unit = data.altKey ? 'WORD' : 'CHARACTER';
+			deleteData.unit = data.altKey ? 'word' : 'character';
 
 			document.fire( 'delete', new DomEventData( document, data.domEvent, deleteData ) );
 		} );
@@ -50,6 +48,6 @@ export default class DeleteObserver extends Observer {
  *
  * @event engine.view.Document#delete
  * @param {engine.view.observer.DomEventData} data
- * @param {'FORWARD'|'DELETE'} data.direction The direction in which the deletion should happen.
- * @param {'CHARACTER'|'WORD'} data.unit The "amount" of content that should be deleted.
+ * @param {'forward'|'delete'} data.direction The direction in which the deletion should happen.
+ * @param {'character'|'word'} data.unit The "amount" of content that should be deleted.
  */

+ 6 - 8
packages/ckeditor5-typing/tests/delete.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import VirtualTestEditor from '/tests/ckeditor5/_utils/virtualtesteditor.js';
 import Delete from '/ckeditor5/typing/delete.js';
 import DomEventData from '/ckeditor5/engine/view/observer/domeventdata.js';
@@ -23,8 +21,8 @@ describe( 'Delete feature', () => {
 	} );
 
 	it( 'creates two commands', () => {
-		expect( editor.commands.get( 'delete' ) ).to.have.property( 'direction', 'BACKWARD' );
-		expect( editor.commands.get( 'forwardDelete' ) ).to.have.property( 'direction', 'FORWARD' );
+		expect( editor.commands.get( 'delete' ) ).to.have.property( 'direction', 'backward' );
+		expect( editor.commands.get( 'forwardDelete' ) ).to.have.property( 'direction', 'forward' );
 	} );
 
 	it( 'listens to the editing view delete event', () => {
@@ -33,8 +31,8 @@ describe( 'Delete feature', () => {
 		const domEvt = getDomEvent();
 
 		view.fire( 'delete', new DomEventData( editingView, domEvt, {
-			direction: 'FORWARD',
-			unit: 'CHARACTER'
+			direction: 'forward',
+			unit: 'character'
 		} ) );
 
 		expect( spy.calledOnce ).to.be.true;
@@ -43,8 +41,8 @@ describe( 'Delete feature', () => {
 		expect( domEvt.preventDefault.calledOnce ).to.be.true;
 
 		view.fire( 'delete', new DomEventData( editingView, getDomEvent(), {
-			direction: 'BACKWARD',
-			unit: 'CHARACTER'
+			direction: 'backward',
+			unit: 'character'
 		} ) );
 
 		expect( spy.calledTwice ).to.be.true;

+ 1 - 3
packages/ckeditor5-typing/tests/deletecommand-integration.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import ModelTestEditor from '/tests/ckeditor5/_utils/modeltesteditor.js';
 import DeleteCommand from '/ckeditor5/typing/deletecommand.js';
 import UndoEngine from '/ckeditor5/undo/undoengine.js';
@@ -25,7 +23,7 @@ beforeEach( () => {
 			editor = newEditor;
 			doc = editor.document;
 
-			const command = new DeleteCommand( editor, 'BACKWARD' );
+			const command = new DeleteCommand( editor, 'backward' );
 			editor.commands.set( 'delete', command );
 
 			doc.schema.registerItem( 'p', '$block' );

+ 7 - 9
packages/ckeditor5-typing/tests/deletecommand.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import ModelTestEditor from '/tests/ckeditor5/_utils/modeltesteditor.js';
 import DeleteCommand from '/ckeditor5/typing/deletecommand.js';
 import { getData, setData } from '/tests/engine/_utils/model.js';
@@ -18,7 +16,7 @@ describe( 'DeleteCommand', () => {
 				editor = newEditor;
 				doc = editor.document;
 
-				const command = new DeleteCommand( editor, 'BACKWARD' );
+				const command = new DeleteCommand( editor, 'backward' );
 				editor.commands.set( 'delete', command );
 
 				doc.schema.registerItem( 'p', '$block' );
@@ -26,9 +24,9 @@ describe( 'DeleteCommand', () => {
 	} );
 
 	it( 'has direction', () => {
-		const command = new DeleteCommand( editor, 'FORWARD' );
+		const command = new DeleteCommand( editor, 'forward' );
 
-		expect( command ).to.have.property( 'direction', 'FORWARD' );
+		expect( command ).to.have.property( 'direction', 'forward' );
 	} );
 
 	describe( 'execute', () => {
@@ -84,15 +82,15 @@ describe( 'DeleteCommand', () => {
 			doc.composer.on( 'modifySelection', spy );
 			setData( doc, '<p>foo<selection />bar</p>' );
 
-			editor.commands.get( 'delete' ).direction = 'FORWARD';
+			editor.commands.get( 'delete' ).direction = 'forward';
 
-			editor.execute( 'delete', { unit: 'WORD' } );
+			editor.execute( 'delete', { unit: 'word' } );
 
 			expect( spy.callCount ).to.equal( 1 );
 
 			const modifyOpts = spy.args[ 0 ][ 1 ].options;
-			expect( modifyOpts ).to.have.property( 'direction', 'FORWARD' );
-			expect( modifyOpts ).to.have.property( 'unit', 'WORD' );
+			expect( modifyOpts ).to.have.property( 'direction', 'forward' );
+			expect( modifyOpts ).to.have.property( 'unit', 'word' );
 		} );
 	} );
 } );

+ 4 - 6
packages/ckeditor5-typing/tests/deleteobserver.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-'use strict';
-
 import DeleteObserver from '/ckeditor5/typing/deleteobserver.js';
 import ViewDocument from '/ckeditor5/engine/view/document.js';
 import DomEventData from '/ckeditor5/engine/view/observer/domeventdata.js';
@@ -38,8 +36,8 @@ describe( 'DeleteObserver', () => {
 			expect( spy.calledOnce ).to.be.true;
 
 			const data = spy.args[ 0 ][ 1 ];
-			expect( data ).to.have.property( 'direction', 'FORWARD' );
-			expect( data ).to.have.property( 'unit', 'CHARACTER' );
+			expect( data ).to.have.property( 'direction', 'forward' );
+			expect( data ).to.have.property( 'unit', 'character' );
 		} );
 
 		it( 'is fired with a proper direction and unit', () => {
@@ -55,8 +53,8 @@ describe( 'DeleteObserver', () => {
 			expect( spy.calledOnce ).to.be.true;
 
 			const data = spy.args[ 0 ][ 1 ];
-			expect( data ).to.have.property( 'direction', 'BACKWARD' );
-			expect( data ).to.have.property( 'unit', 'WORD' );
+			expect( data ).to.have.property( 'direction', 'backward' );
+			expect( data ).to.have.property( 'unit', 'word' );
 		} );
 
 		it( 'is not fired on keydown when keyCode does not match backspace or delete', () => {