Explorar el Código

Changed: use `model.writer` in view -> model conversion. Fixes #44.

Szymon Cofalik hace 8 años
padre
commit
3e5592d11e

+ 3 - 2
packages/ckeditor5-list/src/converters.js

@@ -11,6 +11,7 @@ import ViewListItemElement from './viewlistitemelement';
 
 import ModelElement from '@ckeditor/ckeditor5-engine/src/model/element';
 import ModelPosition from '@ckeditor/ckeditor5-engine/src/model/position';
+import modelWriter from '@ckeditor/ckeditor5-engine/src/model/writer';
 
 import ViewContainerElement from '@ckeditor/ckeditor5-engine/src/view/containerelement';
 import ViewPosition from '@ckeditor/ckeditor5-engine/src/view/position';
@@ -353,7 +354,7 @@ export function viewModelConverter( evt, data, consumable, conversionApi ) {
 		// 3. Handle `<li>` children.
 		data.context.push( listItem );
 
-		// `listItem`s created recursievly should have bigger indent.
+		// `listItem`s created recursively should have bigger indent.
 		data.indent++;
 
 		// `listItem`s will be kept in flat structure.
@@ -373,7 +374,7 @@ export function viewModelConverter( evt, data, consumable, conversionApi ) {
 			}
 			// If it was not a list it was a "regular" list item content. Just append it to `listItem`.
 			else {
-				listItem.appendChildren( converted );
+				modelWriter.insert( ModelPosition.createAt( listItem, 'end' ), converted );
 			}
 		}
 

+ 2 - 1
packages/ckeditor5-list/tests/manual/nestedlists.js

@@ -12,10 +12,11 @@ import Heading from '@ckeditor/ckeditor5-heading/src/heading';
 import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
 import Undo from '@ckeditor/ckeditor5-undo/src/undo';
 import Clipboard from '@ckeditor/ckeditor5-clipboard/src/clipboard';
+import Link from '@ckeditor/ckeditor5-link/src/link';
 import List from '../../src/list';
 
 ClassicEditor.create( document.querySelector( '#editor' ), {
-	plugins: [ Enter, Typing, Heading, Paragraph, Undo, List, Clipboard ],
+	plugins: [ Enter, Typing, Heading, Paragraph, Undo, List, Clipboard, Link ],
 	toolbar: [ 'headings', 'bulletedList', 'numberedList', 'undo', 'redo' ]
 } )
 .then( editor => {