浏览代码

Apply suggestions from code review

Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Maciej 5 年之前
父节点
当前提交
3d5bea51a0

+ 1 - 1
packages/ckeditor5-engine/src/conversion/downcastdispatcher.js

@@ -186,7 +186,7 @@ export default class DowncastDispatcher {
 	 *
 	 * @protected
 	 * @param {String} modelName Main model element name for which events will trigger reconversion.
-	 * @param {Array<String>} events Array of inner events that would trigger conversion for this model.
+	 * @param {Array.<String>} events Array of inner events that would trigger conversion for this model.
 	 */
 	mapRefreshTriggerEvent( modelName, events ) {
 		for ( const eventName of events ) {

+ 2 - 2
packages/ckeditor5-engine/src/model/differ.js

@@ -615,7 +615,7 @@ export default class Differ {
 	}
 
 	/**
-	 * Saves and handles a remove change.
+	 * Saves and handles a refresh change.
 	 *
 	 * @private
 	 * @param {module:engine/model/element~Element} parent
@@ -629,7 +629,7 @@ export default class Differ {
 	}
 
 	/**
-	 * Saves and handles a refresh change.
+	 * Saves and handles an attribute change.
 	 *
 	 * @private
 	 * @param {module:engine/model/item~Item} item

+ 1 - 1
packages/ckeditor5-table/src/converters/table-cell-refresh-post-fixer.js

@@ -54,8 +54,8 @@ function tableCellRefreshPostFixer( model ) {
 
 		// 2b. If we detect that number of children has changed...
 		if ( childDiff !== 0 ) {
-			const prevChildren = tableCell.childCount - childDiff;
 			const currentChildren = tableCell.childCount;
+			const prevChildren = currentChildren - childDiff;
 
 			// Might need refresh if previous children was different from 1. Eg.: it was 2 before, now is 1.
 			if ( currentChildren === 1 && prevChildren !== 1 ) {