8
0
Pārlūkot izejas kodu

Apply suggestions from code review

Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
Maciej 5 gadi atpakaļ
vecāks
revīzija
3c82a085d4

+ 4 - 4
packages/ckeditor5-engine/src/conversion/downcastdispatcher.js

@@ -176,10 +176,10 @@ export default class DowncastDispatcher {
 	/**
 	 * Maps model element "insert" reconversion for given event names. The event names must be fully specified:
 	 *
-	 * * For "attribute" change event it should include main element name, ie: `'attribute:attributeName:main'`.
+	 * * For "attribute" change event it should include main element name, ie: `'attribute:attributeName:elementName'`.
 	 * * For child nodes change events, those should use child event name as well, ie:
-	 *     * For adding a node: `'insert:child'`.
-	 *     * For removing a node: `'remove:child'`.
+	 *     * For adding a node: `'insert:childElementName'`.
+	 *     * For removing a node: `'remove:childElementName'`.
 	 *
 	 * **Note**: This method should not be used directly. A reconversion is defined by `triggerBy` attribute of the `elementToElement()`
 	 * conversion helper.
@@ -672,7 +672,7 @@ export default class DowncastDispatcher {
 				const currentViewItem = this.conversionApi.mapper.getExistingViewForSlot( modelItem );
 
 				// This of course needs better API, but for now it works.
-				// Mapper.bindSlot() creates mappings as mapper.bindElements() but also binds view element
+				// Mapper.bindSlotElements() creates mappings as mapper.bindElements() but also binds view element
 				// from view to the model item.
 				if ( currentViewItem ) {
 					// This allows to have a map: updatedView - model - oldView and to retain previously rendered children

+ 1 - 1
packages/ckeditor5-engine/src/model/differ.js

@@ -1262,7 +1262,7 @@ function _generateActionsFromChanges( oldChildrenLength, changes ) {
 			// We changed `howMany` old nodes, update `oldChildrenHandled`.
 			oldChildrenHandled += change.howMany;
 		} else {
-			// In order to properly handle item refreshing we do not merge "x" action nor do we allow renge refreshing.
+			// In order to properly handle item refreshing we do not merge "x" action nor do we allow range refreshing.
 			actions.push( 'x' );
 
 			// The last handled offset is after inserted item (singular see above comment).