Selaa lähdekoodia

Merge pull request #99 from ckeditor/t/98

Tests: Added missing editor destroy in tests. Closes #98.
Piotrek Koszuliński 8 vuotta sitten
vanhempi
commit
3b08e2e11a

+ 4 - 0
packages/ckeditor5-typing/tests/delete.js

@@ -20,6 +20,10 @@ describe( 'Delete feature', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		return editor.destroy();
+	} );
+
 	it( 'creates two commands', () => {
 		expect( editor.commands.get( 'delete' ) ).to.have.property( 'direction', 'backward' );
 		expect( editor.commands.get( 'forwardDelete' ) ).to.have.property( 'direction', 'forward' );

+ 4 - 0
packages/ckeditor5-typing/tests/deletecommand-integration.js

@@ -35,6 +35,10 @@ describe( 'DeleteCommand integration', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		return editor.destroy();
+	} );
+
 	function assertOutput( output ) {
 		expect( getData( doc ) ).to.equal( output );
 	}

+ 5 - 1
packages/ckeditor5-typing/tests/deletecommand.js

@@ -14,7 +14,7 @@ describe( 'DeleteCommand', () => {
 	testUtils.createSinonSandbox();
 
 	beforeEach( () => {
-		return ModelTestEditor.create( )
+		return ModelTestEditor.create()
 			.then( newEditor => {
 				editor = newEditor;
 				doc = editor.document;
@@ -26,6 +26,10 @@ describe( 'DeleteCommand', () => {
 			} );
 	} );
 
+	afterEach( () => {
+		return editor.destroy();
+	} );
+
 	it( 'has direction', () => {
 		const command = new DeleteCommand( editor, 'forward' );
 

+ 4 - 0
packages/ckeditor5-typing/tests/input.js

@@ -54,6 +54,10 @@ describe( 'Input feature', () => {
 			} );
 	} );
 
+	after( () => {
+		return editor.destroy();
+	} );
+
 	beforeEach( () => {
 		editor.setData( '<p>foobar</p>' );
 

+ 5 - 1
packages/ckeditor5-typing/tests/inputcommand.js

@@ -19,7 +19,7 @@ describe( 'InputCommand', () => {
 	testUtils.createSinonSandbox();
 
 	before( () => {
-		return ModelTestEditor.create( )
+		return ModelTestEditor.create()
 			.then( newEditor => {
 				editor = newEditor;
 				doc = editor.document;
@@ -34,6 +34,10 @@ describe( 'InputCommand', () => {
 			} );
 	} );
 
+	after( () => {
+		return editor.destroy();
+	} );
+
 	beforeEach( () => {
 		buffer.size = 0;
 	} );

+ 8 - 2
packages/ckeditor5-typing/tests/spellchecking.js

@@ -20,10 +20,10 @@ import { getData as getModelData } from '@ckeditor/ckeditor5-engine/src/dev-util
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 
 describe( 'Spellchecking integration', () => {
-	let editor, onChangesDone;
+	let editor, onChangesDone, container;
 
 	before( () => {
-		const container = document.createElement( 'div' );
+		container = document.createElement( 'div' );
 		document.body.appendChild( container );
 
 		return ClassicEditor.create( container, {
@@ -34,6 +34,12 @@ describe( 'Spellchecking integration', () => {
 		} );
 	} );
 
+	after( () => {
+		container.remove();
+
+		return editor.destroy();
+	} );
+
 	beforeEach( () => {
 		if ( onChangesDone ) {
 			editor.document.off( 'changesDone', onChangesDone );

+ 6 - 0
packages/ckeditor5-typing/tests/tickets/59.js

@@ -27,6 +27,12 @@ describe( 'Bug ckeditor5-typing#59', () => {
 		} );
 	} );
 
+	afterEach( () => {
+		container.remove();
+
+		return editor.destroy();
+	} );
+
 	it( 'editor does not blow up when deleting last styled character', () => {
 		editor.document.enqueueChanges( () => {
 			editor.editing.view.getDomRoot().focus();