Bladeren bron

Encoding image's placeholder data before putting it to the img.src attribute.

Szymon Kupś 8 jaren geleden
bovenliggende
commit
347f5f2ac0

+ 1 - 1
packages/ckeditor5-upload/src/imageuploadprogress.js

@@ -39,7 +39,7 @@ export default class ImageUploadProgress extends Plugin {
 		 * @protected
 		 * @member {String} #placeholder
 		 */
-		this.placeholder = 'data:image/svg+xml;utf8,' + uploadingPlaceholder;
+		this.placeholder = 'data:image/svg+xml;utf8,' + encodeURIComponent( uploadingPlaceholder );
 	}
 
 	init() {

+ 2 - 1
packages/ckeditor5-upload/tests/imageuploadprogress.js

@@ -16,9 +16,10 @@ import { setData as setModelData } from '@ckeditor/ckeditor5-engine/src/dev-util
 import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils/view';
 import { eventNameToConsumableType } from '@ckeditor/ckeditor5-engine/src/conversion/model-to-view-converters';
 import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
-import imagePlaceholder from '../theme/icons/image_placeholder.svg';
+import svgPlaceholder from '../theme/icons/image_placeholder.svg';
 
 describe( 'ImageUploadProgress', () => {
+	const imagePlaceholder = encodeURIComponent( svgPlaceholder );
 	// eslint-disable-next-line max-len
 	const base64Sample = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNk+A8AAQUBAScY42YAAAAASUVORK5CYII=';
 	let editor, document, fileRepository, viewDocument, nativeReaderMock, loader, adapterMock;

+ 2 - 0
packages/ckeditor5-upload/tests/manual/imageplaceholder.html

@@ -0,0 +1,2 @@
+<div id="container">
+</div>

+ 13 - 0
packages/ckeditor5-upload/tests/manual/imageplaceholder.js

@@ -0,0 +1,13 @@
+/**
+ * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved.
+ * For licensing, see LICENSE.md.
+ */
+
+/* global document */
+
+import placeholder from '../../theme/icons/image_placeholder.svg';
+
+const img = document.createElement( 'img' );
+img.src = 'data:image/svg+xml;utf8,' + encodeURIComponent( placeholder );
+
+document.getElementById( 'container' ).appendChild( img );

+ 3 - 0
packages/ckeditor5-upload/tests/manual/imageplaceholder.md

@@ -0,0 +1,3 @@
+## Image placeholder
+
+Check if image placeholder is visible.