Przeglądaj źródła

Remove Position, Range, Selection imports from view/model.

Maciej Gołaszewski 7 lat temu
rodzic
commit
33561a6153

+ 2 - 5
packages/ckeditor5-media-embed/src/converters.js

@@ -7,9 +7,6 @@
  * @module media-embed/converters
  * @module media-embed/converters
  */
  */
 
 
-import ViewRange from '@ckeditor/ckeditor5-engine/src/view/range';
-import ViewPosition from '@ckeditor/ckeditor5-engine/src/view/position';
-
 /**
 /**
  * Returns a function that converts the model "url" attribute to the view representation.
  * Returns a function that converts the model "url" attribute to the view representation.
  *
  *
@@ -51,10 +48,10 @@ export function modelToViewUrlAttributeConverter( registry, options ) {
 		const figure = conversionApi.mapper.toViewElement( data.item );
 		const figure = conversionApi.mapper.toViewElement( data.item );
 
 
 		// TODO: removing it and creating it from scratch is a hack. We can do better than that.
 		// TODO: removing it and creating it from scratch is a hack. We can do better than that.
-		viewWriter.remove( ViewRange.createIn( figure ) );
+		viewWriter.remove( viewWriter.createRangeIn( figure ) );
 
 
 		const mediaViewElement = registry.getMediaViewElement( viewWriter, url, options );
 		const mediaViewElement = registry.getMediaViewElement( viewWriter, url, options );
 
 
-		viewWriter.insert( ViewPosition.createAt( figure, 0 ), mediaViewElement );
+		viewWriter.insert( viewWriter.createPositionAt( figure, 0 ), mediaViewElement );
 	}
 	}
 }
 }

+ 1 - 2
packages/ckeditor5-media-embed/src/utils.js

@@ -7,7 +7,6 @@
  * @module media-embed/utils
  * @module media-embed/utils
  */
  */
 
 
-import ViewPosition from '@ckeditor/ckeditor5-engine/src/view/position';
 import { isWidget, toWidget } from '@ckeditor/ckeditor5-widget/src/utils';
 import { isWidget, toWidget } from '@ckeditor/ckeditor5-widget/src/utils';
 
 
 const mediaSymbol = Symbol( 'isMedia' );
 const mediaSymbol = Symbol( 'isMedia' );
@@ -68,7 +67,7 @@ export function createMediaFigureElement( writer, registry, url, options ) {
 	// Note: The hack is a copy&paste from widget utils; it makes the figure act like it's a widget.
 	// Note: The hack is a copy&paste from widget utils; it makes the figure act like it's a widget.
 	figure.getFillerOffset = getFillerOffset;
 	figure.getFillerOffset = getFillerOffset;
 
 
-	writer.insert( ViewPosition.createAt( figure, 0 ), registry.getMediaViewElement( writer, url, options ) );
+	writer.insert( writer.createPositionAt( figure, 0 ), registry.getMediaViewElement( writer, url, options ) );
 
 
 	return figure;
 	return figure;
 }
 }