8
0
Просмотр исходного кода

Changed: Removed `createSingleButtonDropdown()` from dropdown utils.

Maciej Gołaszewski 8 лет назад
Родитель
Сommit
2fb3774520

+ 0 - 6
packages/ckeditor5-ui/src/dropdown/utils.js

@@ -125,12 +125,6 @@ export function createSplitButtonDropdown( model, locale ) {
 	return dropdownView;
 }
 
-export function createSingleButtonDropdown( model, locale ) {
-	const buttonView = createButtonForDropdown( model, locale );
-
-	return createDropdownView( model, buttonView, locale );
-}
-
 export function enableModelIfOneIsEnabled( model, observables ) {
 	model.bind( 'isEnabled' ).to(
 		// Bind to #isEnabled of each observable...

+ 4 - 3
packages/ckeditor5-ui/tests/dropdown/manual/dropdown.js

@@ -22,7 +22,6 @@ import {
 	closeDropdownOnExecute,
 	createButtonForDropdown,
 	createDropdownView,
-	createSingleButtonDropdown,
 	focusDropdownContentsOnArrows,
 } from '../../../src/dropdown/utils';
 
@@ -68,7 +67,8 @@ function testList() {
 		items: collection
 	} );
 
-	const dropdownView = createSingleButtonDropdown( model, {} );
+	const buttonView = createButtonForDropdown( model, {} );
+	const dropdownView = createDropdownView( model, buttonView, {} );
 
 	addListViewToDropdown( dropdownView, model, {} );
 	closeDropdownOnBlur( dropdownView );
@@ -147,7 +147,8 @@ function testButton() {
 		buttons: buttonViews
 	} );
 
-	const toolbarDropdown = createSingleButtonDropdown( toolbarDropdownModel, {} );
+	const buttonView = createButtonForDropdown( toolbarDropdownModel, locale );
+	const toolbarDropdown = createDropdownView( toolbarDropdownModel, buttonView, locale );
 
 	addToolbarToDropdown( toolbarDropdown, toolbarDropdownModel );
 	closeDropdownOnBlur( toolbarDropdown );

+ 4 - 5
packages/ckeditor5-ui/tests/dropdown/utils.js

@@ -28,7 +28,6 @@ import {
 	closeDropdownOnExecute,
 	createButtonForDropdown,
 	createDropdownView,
-	createSingleButtonDropdown,
 	createSplitButtonForDropdown,
 	enableModelIfOneIsEnabled,
 	focusDropdownContentsOnArrows
@@ -330,8 +329,6 @@ describe( 'utils', () => {
 
 	describe( 'createSplitButtonDropdown()', () => { } );
 
-	describe( 'createSingleButtonDropdown()', () => {} );
-
 	describe( 'enableModelIfOneIsEnabled()', () => {
 		it( 'Bind to #isEnabled of each observable  and set it true if any observable #isEnabled is true', () => {
 			const observables = [
@@ -369,7 +366,8 @@ describe( 'utils', () => {
 				label: 'foo'
 			} );
 
-			dropdownView = createSingleButtonDropdown( model, locale );
+			const buttonView = createButtonForDropdown( model, locale );
+			const dropdownView = createDropdownView( model, buttonView, locale );
 
 			addListViewToDropdown( dropdownView, model, locale );
 
@@ -451,7 +449,8 @@ describe( 'utils', () => {
 				buttons
 			} );
 
-			dropdownView = createSingleButtonDropdown( model, locale );
+			const buttonView = createButtonForDropdown( model, locale );
+			const dropdownView = createDropdownView( model, buttonView, locale );
 
 			addToolbarToDropdown( dropdownView, model );
 

+ 1 - 0
packages/ckeditor5-ui/theme/components/button/splitbutton.css

@@ -3,6 +3,7 @@
  * For licensing, see LICENSE.md.
  */
 
+// TODO: change me
 .ck-splitbutton-dropdown {
 	&::after {
 		display: none;