8
0
Pārlūkot izejas kodu

Tests: Added FormHeaderView tests.

Aleksander Nowodzinski 5 gadi atpakaļ
vecāks
revīzija
2d8644bd92

+ 20 - 9
packages/ckeditor5-table/src/ui/formheaderview.js

@@ -25,11 +25,11 @@ export default class FormHeaderView extends View {
 	 * Creates an instance of the form header view class.
 	 *
 	 * @param {module:utils/locale~Locale} locale The locale instance.
-	 * @param {Object} options
+	 * @param {Object} [options]
 	 * @param {String} [options.class] When passed, the class will be set on the header element.
 	 * @param {String} [options.label] When passed, the label will be used for the header.
 	 */
-	constructor( locale, options ) {
+	constructor( locale, options = {} ) {
 		super( locale );
 
 		const bind = this.bindTemplate;
@@ -58,6 +58,23 @@ export default class FormHeaderView extends View {
 		 */
 		this.set( 'label', options.label || '' );
 
+		const label = new View( locale );
+
+		label.setTemplate( {
+			tag: 'span',
+			attributes: {
+				class: [
+					'ck',
+					'ck-form__header__label'
+				],
+			},
+			children: [
+				{ text: bind.to( 'label' ) }
+			]
+		} );
+
+		this.children.add( label );
+
 		this.setTemplate( {
 			tag: 'div',
 			attributes: {
@@ -67,13 +84,7 @@ export default class FormHeaderView extends View {
 					bind.to( 'class' )
 				]
 			},
-			children: [
-				{ text: bind.to( 'label' ) },
-				{
-					tag: 'div',
-					children: this.children
-				}
-			]
+			children: this.children
 		} );
 	}
 }

+ 98 - 0
packages/ckeditor5-table/tests/ui/formheaderview.js

@@ -0,0 +1,98 @@
+/**
+ * @license Copyright (c) 2003-2020, CKSource - Frederico Knabben. All rights reserved.
+ * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
+ */
+
+import View from '@ckeditor/ckeditor5-ui/src/view';
+import FormHeaderView from '../../src/ui/formheaderview';
+import ViewCollection from '@ckeditor/ckeditor5-ui/src/viewcollection';
+
+describe( 'FormHeaderView', () => {
+	let view, locale;
+
+	beforeEach( () => {
+		locale = { t: val => val };
+		view = new FormHeaderView( locale );
+		view.render();
+	} );
+
+	afterEach( () => {
+		view.element.remove();
+	} );
+
+	describe( 'constructor()', () => {
+		it( 'should set view#locale', () => {
+			expect( view.locale ).to.equal( locale );
+		} );
+
+		it( 'should create view#children collection', () => {
+			expect( view.children ).to.be.instanceOf( ViewCollection );
+			expect( view.children ).to.have.length( 1 );
+		} );
+
+		it( 'should set view#label', () => {
+			expect( view.label ).to.equal( '' );
+		} );
+
+		it( 'should set view#class', () => {
+			expect( view.class ).to.be.null;
+		} );
+
+		it( 'should set the template', () => {
+			expect( view.element.classList.contains( 'ck' ) ).to.be.true;
+			expect( view.element.classList.contains( 'ck-form__header' ) ).to.be.true;
+		} );
+
+		describe( 'options', () => {
+			it( 'should set view#class when class was passed', () => {
+				const view = new FormHeaderView( locale, {
+					class: 'foo'
+				} );
+
+				expect( view.class ).to.equal( 'foo' );
+
+				view.destroy();
+			} );
+
+			it( 'should use a label text when passed', () => {
+				const view = new FormHeaderView( locale, {
+					label: 'foo'
+				} );
+
+				view.render();
+
+				expect( view.element.firstChild.classList.contains( 'ck' ) ).to.be.true;
+				expect( view.element.firstChild.classList.contains( 'ck-form__header__label' ) ).to.be.true;
+				expect( view.element.firstChild.textContent ).to.equal( 'foo' );
+
+				view.destroy();
+			} );
+		} );
+
+		describe( 'template bindings', () => {
+			it( 'should bind #class to the template', () => {
+				view.class = 'foo';
+				expect( view.element.classList.contains( 'foo' ) ).to.be.true;
+			} );
+
+			it( 'should bind #label to the template', () => {
+				view.label = 'bar';
+				expect( view.element.firstChild.textContent ).to.equal( 'bar' );
+
+				view.label = 'baz';
+				expect( view.element.firstChild.textContent ).to.equal( 'baz' );
+			} );
+
+			it( 'should bind #children to the template', () => {
+				const child = new View();
+				child.setTemplate( { tag: 'div' } );
+
+				view.children.add( child );
+
+				expect( view.element.childNodes[ 1 ] ).to.equal( child.element );
+
+				view.destroy();
+			} );
+		} );
+	} );
+} );

+ 4 - 0
packages/ckeditor5-table/tests/ui/formrowview.js

@@ -74,6 +74,8 @@ describe( 'FormRowView', () => {
 
 				expect( view.element.getAttribute( 'role' ) ).to.equal( 'group' );
 				expect( view.element.getAttribute( 'aria-labelledby' ) ).to.equal( '123' );
+
+				view.destroy();
 			} );
 		} );
 
@@ -90,6 +92,8 @@ describe( 'FormRowView', () => {
 				view.children.add( child );
 
 				expect( view.element.firstChild ).to.equal( child.element );
+
+				view.destroy();
 			} );
 		} );
 	} );

+ 4 - 1
packages/ckeditor5-table/theme/formheader.css

@@ -4,9 +4,12 @@
  */
 
 .ck.ck-form__header {
-	font-weight: bold;
 	padding: 0 var(--ck-spacing-large);
 	height: 38px;
 	line-height: 38px;
 	border-bottom: 1px solid var(--ck-color-base-border);
+
+	& .ck-form__header__label {
+		font-weight: bold;
+	}
 }