Bladeren bron

Reviewed tests to use `bender.amd.require()` and to avoid `setTimeout()`.

fredck 11 jaren geleden
bovenliggende
commit
2b959e12f5
2 gewijzigde bestanden met toevoegingen van 13 en 17 verwijderingen
  1. 2 1
      packages/ckeditor5-utils/gruntfile.js
  2. 11 16
      packages/ckeditor5-utils/tests/promise/promise.js

+ 2 - 1
packages/ckeditor5-utils/gruntfile.js

@@ -18,7 +18,8 @@ module.exports = function( grunt ) {
 		jshint: {
 			options: {
 				globals: {
-					'CKEDITOR': false
+					'CKEDITOR': false,
+					'bender': false
 				},
 				ignores: ignoreFiles
 			}

+ 11 - 16
packages/ckeditor5-utils/tests/promise/promise.js

@@ -3,27 +3,22 @@
  * For licensing, see LICENSE.md.
  */
 
-/* globals describe, it, expect, CKEDITOR, window */
+/* globals describe, it, expect */
 
 'use strict';
 
+var modules = bender.amd.require( 'promise' );
+
 describe( 'Promise', function() {
-	it( 'should resolve properly', function( done ) {
-		CKEDITOR.require( [ 'promise' ], function( Promise ) {
-			var promise = new Promise( function( resolve ) {
-				// Fake an asynchronous operation.
-				window.setTimeout( function() {
-					resolve( 1 );
-				}, 0 );
-			} );
+	it( 'should resolve properly', function() {
+		var Promise = modules.promise;
+
+		var promise = new Promise( function( resolve ) {
+			resolve( 1 );
+		} );
 
-			promise.then( function( value ) {
-				// then() catches errors, so we need to delay the execution.
-				window.setTimeout( function() {
-					expect( value ).to.equal( 1 );
-					done();
-				} );
-			} );
+		return promise.then( function( value ) {
+			expect( value ).to.equal( 1 );
 		} );
 	} );
 } );