8
0
Просмотр исходного кода

Removed id rendering from marked renderer.

Szymon Kupś 9 лет назад
Родитель
Сommit
28aaf1a633

+ 1 - 3
packages/ckeditor5-markdown-gfm/src/lib/marked/renderer.js

@@ -45,9 +45,7 @@ Renderer.prototype.html = function( html ) {
 };
 
 Renderer.prototype.heading = function( text, level, raw ) {
-	const id = this.options.headerPrefix + raw.toLowerCase().replace( /[^\w]+/g, '-' );
-
-	return `<h${ level } id="${id}">${ text }</h${ level }>`;
+	return `<h${ level }>${ text }</h${ level }>`;
 };
 
 Renderer.prototype.hr = function() {

+ 9 - 27
packages/ckeditor5-markdown-gfm/tests/gfmdataprocessor/headers.js

@@ -11,9 +11,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'# Level 1',
 
-				// GitHub is rendering as:
-				// <h1>Level 1</h1>
-				'<h1 id="level-1">Level 1</h1>'
+				'<h1>Level 1</h1>'
 			);
 		} );
 
@@ -22,9 +20,7 @@ describe( 'GFMDataProcessor', () => {
 				'Level 1\n' +
 				'===',
 
-				// GitHub is rendering as:
-				// <h1>Level 1</h1>
-				'<h1 id="level-1">Level 1</h1>',
+				'<h1>Level 1</h1>',
 
 				// When converting back it will be normalized to # representation.
 				'# Level 1'
@@ -35,9 +31,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'## Level 2',
 
-				// GitHub is rendering as:
-				// <h2>Level 2</h2>
-				'<h2 id="level-2">Level 2</h2>'
+				'<h2>Level 2</h2>'
 			);
 		} );
 
@@ -46,9 +40,7 @@ describe( 'GFMDataProcessor', () => {
 				'Level 2\n' +
 				'---',
 
-				// GitHub is rendering as:
-				// <h2>Level 2</h2>
-				'<h2 id="level-2">Level 2</h2>',
+				'<h2>Level 2</h2>',
 
 				// When converting back it will be normalized to ## representation.
 				'## Level 2'
@@ -59,9 +51,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'### Level 3',
 
-				// GitHub is rendering as:
-				// <h3>Level 3</h3>
-				'<h3 id="level-3">Level 3</h3>'
+				'<h3>Level 3</h3>'
 			);
 		} );
 
@@ -69,9 +59,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'#### Level 4',
 
-				// GitHub is rendering as:
-				// <h4>Level 4</h4>
-				'<h4 id="level-4">Level 4</h4>'
+				'<h4>Level 4</h4>'
 			);
 		} );
 
@@ -79,9 +67,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'##### Level 5',
 
-				// GitHub is rendering as:
-				// <h5>Level 5</h5>
-				'<h5 id="level-5">Level 5</h5>'
+				'<h5>Level 5</h5>'
 			);
 		} );
 
@@ -89,9 +75,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'###### Level 6',
 
-				// GitHub is rendering as:
-				// <h6>Level 6</h6>
-				'<h6 id="level-6">Level 6</h6>'
+				'<h6>Level 6</h6>'
 			);
 		} );
 
@@ -99,9 +83,7 @@ describe( 'GFMDataProcessor', () => {
 			test(
 				'#      Level 1',
 
-				// GitHub is rendering as:
-				// <h1>Level 6</h1>
-				'<h1 id="level-1">Level 1</h1>',
+				'<h1>Level 1</h1>',
 
 				// When converting back it will be normalized to # Level 1.
 				'# Level 1'

+ 2 - 2
packages/ckeditor5-markdown-gfm/tests/gfmdataprocessor/paragraphs.js

@@ -38,7 +38,7 @@ describe( 'GFMDataProcessor', () => {
 				// <p>single line</p>
 				//
 				//<h1>header</h1>
-				'<p>single line</p><h1 id="header">header</h1>',
+				'<p>single line</p><h1>header</h1>',
 
 				// To-markdown always put 2 empty lines after paragraph.
 				'single line\n\n' +
@@ -56,7 +56,7 @@ describe( 'GFMDataProcessor', () => {
 				// <p>single line</p>
 				//
 				//<h1>header</h1>
-				'<p>single line</p><h1 id="header">header</h1>',
+				'<p>single line</p><h1>header</h1>',
 
 				// To-markdown always put 2 empty lines after paragraph and normalize header to #.
 				'single line\n' +