Преглед на файлове

Removed config opiton for responsive image sizes attribute - not needed for now.

Szymon Kupś преди 8 години
родител
ревизия
27c6966653
променени са 2 файла, в които са добавени 2 реда и са изтрити 27 реда
  1. 2 7
      packages/ckeditor5-image/src/image/imageengine.js
  2. 0 20
      packages/ckeditor5-image/tests/image/imageengine.js

+ 2 - 7
packages/ckeditor5-image/src/image/imageengine.js

@@ -33,7 +33,6 @@ export default class ImageEngine extends Plugin {
 		const schema = doc.schema;
 		const data = editor.data;
 		const editing = editor.editing;
-		const config = editor.config;
 		const t = editor.t;
 
 		// Configure schema.
@@ -55,17 +54,13 @@ export default class ImageEngine extends Plugin {
 		createImageAttributeConverter( [ editing.modelToView, data.modelToView ], 'src' );
 		createImageAttributeConverter( [ editing.modelToView, data.modelToView ], 'alt' );
 
-		// Responsive sizes default value. More information and discussion on this topic:
-		// https://github.com/ckeditor/ckeditor5-image/issues/2.
-		config.define( 'image.responsiveSizes', '100vw' );
-		const sizes = config.get( 'image.responsiveSizes' );
-
 		// Convert `srcset` attribute changes and add or remove `sizes` attribute when necessary.
 		createImageAttributeConverter( [ editing.modelToView, data.modelToView ], 'srcset', ( viewImg, type ) => {
 			if ( type == 'removeAttribute' ) {
 				viewImg.removeAttribute( 'sizes' );
 			} else {
-				viewImg.setAttribute( 'sizes', sizes );
+				// Always outputting `100vw`. See https://github.com/ckeditor/ckeditor5-image/issues/2.
+				viewImg.setAttribute( 'sizes', '100vw' );
 			}
 		} );
 

+ 0 - 20
packages/ckeditor5-image/tests/image/imageengine.js

@@ -394,26 +394,6 @@ describe( 'ImageEngine', () => {
 				);
 			} );
 
-			it( 'should use sizes from configuration', () => {
-				return VirtualTestEditor.create( {
-					plugins: [ ImageEngine ],
-					image: {
-						responsiveSizes: '50vf'
-					}
-				} )
-				.then( newEditor => {
-					setModelData( newEditor.document,
-						'<image src="foo.png" alt="alt text" srcset="small.png 148w, big.png 1024w"></image>'
-					);
-
-					expect( getViewData( newEditor.editing.view, { withoutSelection: true } ) ).to.equal(
-						'<figure class="image ck-widget" contenteditable="false">' +
-						'<img alt="alt text" sizes="50vf" src="foo.png" srcset="small.png 148w, big.png 1024w"></img>' +
-						'</figure>'
-					);
-				} );
-			} );
-
 			it( 'should remove sizes attribute when srcset attribute is removed', () => {
 				setModelData( document, '<image src="foo.png" srcset="small.png 148w, big.png 1024w"></image>' );
 				const image = document.getRoot().getChild( 0 );