Procházet zdrojové kódy

Removed clickOutsideHandler as render callback does closing the panel.

Szymon Kupś před 9 roky
rodič
revize
26dd1be83d

+ 0 - 9
packages/ckeditor5-image/src/imagealternatetext/imagealternatetext.js

@@ -10,7 +10,6 @@
 import Plugin from 'ckeditor5-core/src/plugin';
 import ButtonView from 'ckeditor5-ui/src/button/buttonview';
 import ImageAlternateTextEngine from './imagealternatetextengine';
-import clickOutsideHandler from 'ckeditor5-ui/src/bindings/clickoutsidehandler';
 import escPressHandler from 'ckeditor5-ui/src/bindings/escpresshandler';
 import ImageToolbar from '../imagetoolbar';
 import AlternateTextFormView from './ui/alternatetextformview';
@@ -109,14 +108,6 @@ export default class ImageAlternateText extends Plugin {
 			callback: () => this._hideBalloonPanel()
 		} );
 
-		// Close on click outside of balloon panel element.
-		clickOutsideHandler( {
-			emitter: panel,
-			activator: () => panel.isVisible,
-			contextElement: panel.element,
-			callback: () => this._hideBalloonPanel()
-		} );
-
 		return Promise.all( [
 			panel.content.add( form ),
 			editor.ui.view.body.add( panel )

+ 0 - 11
packages/ckeditor5-image/tests/imagealternatetext/imagealternatetext.js

@@ -3,8 +3,6 @@
  * For licensing, see LICENSE.md.
  */
 
-/* global Event */
-
 import ClassicTestEditor from 'ckeditor5-core/tests/_utils/classictesteditor';
 import Image from 'ckeditor5-image/src/image';
 import ImageToolbar from 'ckeditor5-image/src/imagetoolbar';
@@ -177,15 +175,6 @@ describe( 'ImageAlternateText', () => {
 					sinon.assert.called( hidePanelSpy );
 				} );
 			} );
-
-			describe( 'mouse', () => {
-				it( 'should close on click outside the panel', () => {
-					balloonPanel.isVisible = true;
-					global.document.body.dispatchEvent( new Event( 'mouseup', { bubbles: true } ) );
-
-					sinon.assert.called( hidePanelSpy );
-				} );
-			} );
 		} );
 	} );
 } );