瀏覽代碼

Removed the confirmation of mention selection by using the space key.

fredck 5 年之前
父節點
當前提交
26855ccfa4
共有 2 個文件被更改,包括 1 次插入8 次删除
  1. 1 2
      packages/ckeditor5-mention/src/mentionui.js
  2. 0 6
      packages/ckeditor5-mention/tests/mentionui.js

+ 1 - 2
packages/ckeditor5-mention/src/mentionui.js

@@ -34,7 +34,6 @@ const handledKeyCodes = [
 	keyCodes.arrowdown,
 	keyCodes.enter,
 	keyCodes.tab,
-	keyCodes.space,
 	keyCodes.esc
 ];
 
@@ -121,7 +120,7 @@ export default class MentionUI extends Plugin {
 					this._mentionsView.selectPrevious();
 				}
 
-				if ( data.keyCode == keyCodes.enter || data.keyCode == keyCodes.tab || data.keyCode == keyCodes.space ) {
+				if ( data.keyCode == keyCodes.enter || data.keyCode == keyCodes.tab ) {
 					this._mentionsView.executeSelected();
 				}
 

+ 0 - 6
packages/ckeditor5-mention/tests/mentionui.js

@@ -1572,8 +1572,6 @@ describe( 'MentionUI', () => {
 				testExecuteKey( 'enter', keyCodes.enter, feedItems );
 
 				testExecuteKey( 'tab', keyCodes.tab, feedItems );
-
-				testExecuteKey( 'space', keyCodes.space, feedItems );
 			} );
 		} );
 
@@ -1724,8 +1722,6 @@ describe( 'MentionUI', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
 
 					testExecuteKey( 'tab', keyCodes.tab, issues );
-
-					testExecuteKey( 'space', keyCodes.space, issues );
 				} );
 			} );
 		} );
@@ -1849,8 +1845,6 @@ describe( 'MentionUI', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
 
 					testExecuteKey( 'tab', keyCodes.tab, issues );
-
-					testExecuteKey( 'space', keyCodes.space, issues );
 				} );
 
 				describe( 'mouse', () => {