Forráskód Böngészése

Rename editors ids.

Piotr Jasiun 9 éve
szülő
commit
26669fd5c8

+ 2 - 2
packages/ckeditor5-engine/tests/treeview/observer/__template__.html

@@ -1,2 +1,2 @@
-<div contenteditable="true" id="editor"></div>
-<div contenteditable="true" id="editor2"></div>
+<div contenteditable="true" id="main"></div>
+<div contenteditable="true" id="additional"></div>

+ 9 - 9
packages/ckeditor5-engine/tests/treeview/observer/mutationobserver.js

@@ -16,10 +16,10 @@ describe( 'MutationObserver', () => {
 
 	beforeEach( () => {
 		treeView = new TreeView();
-		domEditor = document.getElementById( 'editor' );
+		domEditor = document.getElementById( 'main' );
 		lastMutations = null;
 
-		treeView.createRoot( domEditor, 'editor' );
+		treeView.createRoot( domEditor );
 		treeView.selection.removeAllRanges();
 		document.getSelection().removeAllRanges();
 
@@ -27,7 +27,7 @@ describe( 'MutationObserver', () => {
 
 		treeView.on( 'mutations', ( evt, mutations ) => lastMutations = mutations );
 
-		viewRoot = treeView.viewRoots.get( 'editor' );
+		viewRoot = treeView.getRoot();
 
 		viewRoot.appendChildren( parse( '<container:p>foo</container:p><container:p>bar</container:p>' ) );
 
@@ -104,19 +104,19 @@ describe( 'MutationObserver', () => {
 	} );
 
 	it( 'should be able to observe multiple roots', () => {
-		const domEditor2 = document.getElementById( 'editor2' );
+		const domAdditionalEditor = document.getElementById( 'additional' );
 
-		// Prepare editor2
-		treeView.createRoot( domEditor2, 'editor2' );
+		// Prepare AdditionalEditor
+		treeView.createRoot( domAdditionalEditor, 'additional' );
 
-		treeView.viewRoots.get( 'editor2' ).appendChildren(
+		treeView.viewRoots.get( 'additional' ).appendChildren(
 			parse( '<container:p>foo</container:p><container:p>bar</container:p>' ) );
 
-		// Render editor2 (first editor has been rendered in the beforeEach function)
+		// Render AdditionalEditor (first editor has been rendered in the beforeEach function)
 		treeView.render();
 
 		domEditor.childNodes[ 0 ].childNodes[ 0 ].data = 'foom';
-		domEditor2.childNodes[ 0 ].childNodes[ 0 ].data = 'foom';
+		domAdditionalEditor.childNodes[ 0 ].childNodes[ 0 ].data = 'foom';
 
 		mutationObserver.flush();
 

+ 4 - 4
packages/ckeditor5-engine/tests/treeview/observer/selectionobserver.js

@@ -25,7 +25,7 @@ describe( 'SelectionObserver', () => {
 
 		treeView = new TreeView();
 
-		treeView.createRoot( document.getElementById( 'editor' ) );
+		treeView.createRoot( document.getElementById( 'main' ) );
 
 		mutationObserver = treeView.addObserver( MutationObserver );
 		selectionObserver = treeView.addObserver( SelectionObserver );
@@ -77,7 +77,7 @@ describe( 'SelectionObserver', () => {
 
 	it( 'should add only one listener to one document', ( done ) => {
 		// Add second roots to ensure that listener is added once.
-		treeView.createRoot( document.getElementById( 'editor2' ), 'editor2' );
+		treeView.createRoot( document.getElementById( 'additional' ), 'additional' );
 
 		listenter.listenTo( treeView, 'selectionchange', () => {
 			done();
@@ -121,7 +121,7 @@ describe( 'SelectionObserver', () => {
 				expect( domSelection.rangeCount ).to.equal( 1 );
 
 				const domRange = domSelection.getRangeAt( 0 );
-				const domBar = document.getElementById( 'editor' ).childNodes[ 1 ].childNodes[ 0 ];
+				const domBar = document.getElementById( 'main' ).childNodes[ 1 ].childNodes[ 0 ];
 
 				expect( domRange.startContainer ).to.equal( domBar );
 				expect( domRange.startOffset ).to.equal( 0 );
@@ -139,7 +139,7 @@ describe( 'SelectionObserver', () => {
 function changeDomSelection() {
 	const domSelection = document.getSelection();
 	domSelection.removeAllRanges();
-	const domFoo = document.getElementById( 'editor' ).childNodes[ 0 ].childNodes[ 0 ];
+	const domFoo = document.getElementById( 'main' ).childNodes[ 0 ].childNodes[ 0 ];
 	const domRange = new Range();
 	domRange.setStart( domFoo, 1 );
 	domRange.setEnd( domFoo, 2 );