8
0
Просмотр исходного кода

Renamed conversionApi.data to conversionApi.store.

Oskar Wróbel 8 лет назад
Родитель
Сommit
23069f18fb

+ 3 - 3
packages/ckeditor5-engine/src/conversion/viewconversiondispatcher.js

@@ -180,7 +180,7 @@ export default class ViewConversionDispatcher {
 			this.conversionApi.consumable = ViewConsumable.createFrom( viewItem );
 
 			// Custom data stored by converter for conversion process.
-			this.conversionApi.data = {};
+			this.conversionApi.store = {};
 
 			// Do the conversion.
 			const { modelRange } = this._convertItem( viewItem, this._modelCursor );
@@ -210,7 +210,7 @@ export default class ViewConversionDispatcher {
 
 			// Clear conversion API.
 			this.conversionApi.writer = null;
-			this.conversionApi.data = null;
+			this.conversionApi.store = null;
 
 			// Return fragment as conversion result.
 			return documentFragment;
@@ -510,5 +510,5 @@ function createContextTree( contextDefinition, writer ) {
 /**
  * Custom data stored by converter for conversion process.
  *
- * @param {Object} #data
+ * @param {Object} #store
  */

+ 5 - 6
packages/ckeditor5-engine/tests/conversion/viewconversiondispatcher.js

@@ -63,20 +63,20 @@ describe( 'ViewConversionDispatcher', () => {
 
 			// Conversion process properties should be undefined/empty before conversion.
 			expect( dispatcher.conversionApi.writer ).to.not.ok;
-			expect( dispatcher.conversionApi.data ).to.not.ok;
+			expect( dispatcher.conversionApi.store ).to.not.ok;
 			expect( dispatcher._removeIfEmpty.size ).to.equal( 0 );
 
 			dispatcher.on( 'element', ( evt, data, conversionApi ) => {
 				// Check conversion api params.
 				expect( conversionApi.writer ).to.instanceof( ModelWriter );
-				expect( conversionApi.data ).to.deep.equal( {} );
+				expect( conversionApi.store ).to.deep.equal( {} );
 				expect( dispatcher._removeIfEmpty.size ).to.equal( 0 );
 
 				// Remember writer to check in next converter that is exactly the same instance (the same undo step).
 				writer = conversionApi.writer;
 
 				// Add some data to conversion storage to verify them in next converter.
-				conversionApi.data.foo = 'bar';
+				conversionApi.store.foo = 'bar';
 
 				// Add empty element and mark as a split result to check in next converter.
 				dispatcher._removeIfEmpty.add( conversionApi.writer.createElement( 'paragraph' ) );
@@ -92,7 +92,7 @@ describe( 'ViewConversionDispatcher', () => {
 				expect( conversionApi.writer ).to.equal( writer );
 
 				// Data set by previous converter are remembered.
-				expect( conversionApi.data ).to.deep.equal( { foo: 'bar' } );
+				expect( conversionApi.store ).to.deep.equal( { foo: 'bar' } );
 
 				// Split element is remembered as well.
 				expect( dispatcher._removeIfEmpty.size ).to.equal( 1 );
@@ -107,7 +107,7 @@ describe( 'ViewConversionDispatcher', () => {
 
 			// Conversion process properties should be cleared after conversion.
 			expect( dispatcher.conversionApi.writer ).to.not.ok;
-			expect( dispatcher.conversionApi.data ).to.not.ok;
+			expect( dispatcher.conversionApi.store ).to.not.ok;
 			expect( dispatcher._removeIfEmpty.size ).to.equal( 0 );
 		} );
 
@@ -237,7 +237,6 @@ describe( 'ViewConversionDispatcher', () => {
 				data.modelRange = ModelRange.createOn( text );
 			} );
 
-			// Use `additionalData` parameter to check if it was passed to the event.
 			const conversionResult = dispatcher.convert( viewFragment );
 
 			// Check conversion result.