|
|
@@ -3,9 +3,9 @@
|
|
|
* For licensing, see LICENSE.md.
|
|
|
*/
|
|
|
|
|
|
-/* global document */
|
|
|
+/* global document, window */
|
|
|
|
|
|
-import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
|
|
|
+import ClassicTestEditor from '@ckeditor/ckeditor5-editor-classic/src/classiceditor';
|
|
|
import TableToolbar from '../src/tabletoolbar';
|
|
|
import Table from '../src/table';
|
|
|
import global from '@ckeditor/ckeditor5-utils/src/dom/global';
|
|
|
@@ -15,199 +15,450 @@ import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph';
|
|
|
import Range from '@ckeditor/ckeditor5-engine/src/model/range';
|
|
|
import View from '@ckeditor/ckeditor5-ui/src/view';
|
|
|
import { setData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';
|
|
|
+import WidgetToolbarRepository from '@ckeditor/ckeditor5-widget/src/widgettoolbarrepository';
|
|
|
+import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
|
|
|
|
|
|
describe( 'TableToolbar', () => {
|
|
|
- let editor, model, doc, widgetToolbarRepository, toolbar, balloon, editorElement;
|
|
|
+ testUtils.createSinonSandbox();
|
|
|
|
|
|
- beforeEach( () => {
|
|
|
- editorElement = global.document.createElement( 'div' );
|
|
|
- global.document.body.appendChild( editorElement );
|
|
|
+ describe( 'contentToolbar', () => {
|
|
|
+ let editor, model, doc, widgetToolbarRepository, toolbar, balloon, editorElement;
|
|
|
|
|
|
- return ClassicEditor
|
|
|
- .create( editorElement, {
|
|
|
- plugins: [ Paragraph, Table, TableToolbar, FakeButton ],
|
|
|
- table: {
|
|
|
- toolbar: [ 'fake_button' ]
|
|
|
- }
|
|
|
+ beforeEach( () => {
|
|
|
+ editorElement = global.document.createElement( 'div' );
|
|
|
+ global.document.body.appendChild( editorElement );
|
|
|
+
|
|
|
+ return ClassicTestEditor
|
|
|
+ .create( editorElement, {
|
|
|
+ plugins: [ Paragraph, Table, TableToolbar, FakeButton ],
|
|
|
+ table: {
|
|
|
+ contentToolbar: [ 'fake_button' ]
|
|
|
+ }
|
|
|
+ } )
|
|
|
+ .then( newEditor => {
|
|
|
+ editor = newEditor;
|
|
|
+ model = newEditor.model;
|
|
|
+ doc = model.document;
|
|
|
+ widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ toolbar = widgetToolbarRepository._toolbars.get( 'tableContent' ).view;
|
|
|
+ balloon = editor.plugins.get( 'ContextualBalloon' );
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+
|
|
|
+ afterEach( () => {
|
|
|
+ editorElement.remove();
|
|
|
+
|
|
|
+ return editor.destroy();
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should be loaded', () => {
|
|
|
+ expect( editor.plugins.get( TableToolbar ) ).to.be.instanceOf( TableToolbar );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should not initialize if there is no configuration', () => {
|
|
|
+ const editorElement = global.document.createElement( 'div' );
|
|
|
+ global.document.body.appendChild( editorElement );
|
|
|
+
|
|
|
+ return ClassicTestEditor.create( editorElement, {
|
|
|
+ plugins: [ TableToolbar ]
|
|
|
} )
|
|
|
- .then( newEditor => {
|
|
|
- editor = newEditor;
|
|
|
- model = newEditor.model;
|
|
|
- doc = model.document;
|
|
|
- widgetToolbarRepository = editor.plugins.get( 'WidgetToolbarRepository' );
|
|
|
- toolbar = widgetToolbarRepository._toolbars.get( 'table' ).view;
|
|
|
- balloon = editor.plugins.get( 'ContextualBalloon' );
|
|
|
+ .then( editor => {
|
|
|
+ const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ expect( widgetToolbarRepository._toolbars.get( 'tableContent' ) ).to.be.undefined;
|
|
|
+
|
|
|
+ editorElement.remove();
|
|
|
+ return editor.destroy();
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+
|
|
|
+ describe( 'toolbar', () => {
|
|
|
+ it( 'should use the config.table.toolbar to create items', () => {
|
|
|
+ expect( toolbar.items ).to.have.length( 1 );
|
|
|
+ expect( toolbar.items.get( 0 ).label ).to.equal( 'fake button' );
|
|
|
} );
|
|
|
- } );
|
|
|
|
|
|
- afterEach( () => {
|
|
|
- editorElement.remove();
|
|
|
+ it( 'should set proper CSS classes', () => {
|
|
|
+ const spy = sinon.spy( balloon, 'add' );
|
|
|
|
|
|
- return editor.destroy();
|
|
|
- } );
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
|
|
|
- it( 'should be loaded', () => {
|
|
|
- expect( editor.plugins.get( TableToolbar ) ).to.be.instanceOf( TableToolbar );
|
|
|
- } );
|
|
|
+ setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
|
|
|
- it( 'should not initialize if there is no configuration', () => {
|
|
|
- const editorElement = global.document.createElement( 'div' );
|
|
|
- global.document.body.appendChild( editorElement );
|
|
|
+ sinon.assert.calledWithMatch( spy, {
|
|
|
+ view: toolbar,
|
|
|
+ balloonClassName: 'ck-toolbar-container'
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+ } );
|
|
|
+
|
|
|
+ describe( 'integration with the editor focus', () => {
|
|
|
+ it( 'should show the toolbar when the editor gains focus and the table is selected', () => {
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
|
|
|
- return ClassicEditor.create( editorElement, {
|
|
|
- plugins: [ TableToolbar ]
|
|
|
- } )
|
|
|
- .then( editor => {
|
|
|
- expect( editor.plugins.get( TableToolbar )._toolbar ).to.be.undefined;
|
|
|
+ setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
|
|
|
- editorElement.remove();
|
|
|
- return editor.destroy();
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
} );
|
|
|
- } );
|
|
|
|
|
|
- describe( 'toolbar', () => {
|
|
|
- it( 'should use the config.table.toolbar to create items', () => {
|
|
|
- expect( toolbar.items ).to.have.length( 1 );
|
|
|
- expect( toolbar.items.get( 0 ).label ).to.equal( 'fake button' );
|
|
|
+ it( 'should hide the toolbar when the editor loses focus and the table is selected', () => {
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
+
|
|
|
+ setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
+
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should set proper CSS classes', () => {
|
|
|
- const spy = sinon.spy( balloon, 'add' );
|
|
|
+ describe( 'integration with the editor selection (ui#update event)', () => {
|
|
|
+ beforeEach( () => {
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should not show the toolbar on ui#update when the table is selected', () => {
|
|
|
+ setData( model, '<paragraph>foo</paragraph>[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
|
|
|
- editor.ui.focusTracker.isFocused = true;
|
|
|
+ it( 'should show the toolbar on ui#update when the table content is selected', () => {
|
|
|
+ setData(
|
|
|
+ model,
|
|
|
+ '<paragraph>[foo]</paragraph><table><tableRow><tableCell><paragraph>bar</paragraph></tableCell></tableRow></table>'
|
|
|
+ );
|
|
|
|
|
|
- setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
|
|
|
- sinon.assert.calledWithMatch( spy, {
|
|
|
- view: toolbar,
|
|
|
- balloonClassName: 'ck-toolbar-container'
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+
|
|
|
+ model.change( writer => {
|
|
|
+ // Select the <tableCell>[bar]</tableCell>
|
|
|
+ writer.setSelection(
|
|
|
+ Range.createOn( doc.getRoot().getChild( 1 ).getChild( 0 ).getChild( 0 ).getChild( 0 ) )
|
|
|
+ );
|
|
|
+ } );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ // Make sure successive change does not throw, e.g. attempting
|
|
|
+ // to insert the toolbar twice.
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
} );
|
|
|
- } );
|
|
|
- } );
|
|
|
|
|
|
- describe( 'integration with the editor focus', () => {
|
|
|
- it( 'should show the toolbar when the editor gains focus and the table is selected', () => {
|
|
|
- editor.ui.focusTracker.isFocused = true;
|
|
|
+ it( 'should not engage when the toolbar is in the balloon yet invisible', () => {
|
|
|
+ setData( model, '<table><tableRow><tableCell><paragraph>x[y]z</paragraph></tableCell></tableRow></table>' );
|
|
|
|
|
|
- setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
|
|
|
- editor.ui.focusTracker.isFocused = false;
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ // Put anything on top of the ContextualBalloon stack above the table toolbar.
|
|
|
+ const lastView = new View();
|
|
|
+ lastView.element = document.createElement( 'div' );
|
|
|
|
|
|
- editor.ui.focusTracker.isFocused = true;
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
- } );
|
|
|
+ balloon.add( {
|
|
|
+ view: lastView,
|
|
|
+ position: {
|
|
|
+ target: document.body
|
|
|
+ }
|
|
|
+ } );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should hide the toolbar on render if the table is de–selected', () => {
|
|
|
+ setData(
|
|
|
+ model,
|
|
|
+ '<paragraph>foo</paragraph><table><tableRow><tableCell><paragraph>[]</paragraph></tableCell></tableRow></table>'
|
|
|
+ );
|
|
|
|
|
|
- it( 'should hide the toolbar when the editor loses focus and the table is selected', () => {
|
|
|
- editor.ui.focusTracker.isFocused = false;
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
|
|
|
- setData( model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
+ model.change( writer => {
|
|
|
+ // Select the <paragraph>[...]</paragraph>
|
|
|
+ writer.setSelection(
|
|
|
+ Range.createIn( doc.getRoot().getChild( 0 ) )
|
|
|
+ );
|
|
|
+ } );
|
|
|
|
|
|
- editor.ui.focusTracker.isFocused = true;
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
|
|
|
- editor.ui.focusTracker.isFocused = false;
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ // Make sure successive change does not throw, e.g. attempting
|
|
|
+ // to remove the toolbar twice.
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
} );
|
|
|
} );
|
|
|
|
|
|
- describe( 'integration with the editor selection (ui#update event)', () => {
|
|
|
- beforeEach( () => {
|
|
|
- editor.ui.focusTracker.isFocused = true;
|
|
|
+ describe( 'deprecated toolbar', () => {
|
|
|
+ let editor, editorElement, warnMock;
|
|
|
+
|
|
|
+ it( 'table.toolbar should work as table.contentToolbar', () => {
|
|
|
+ editorElement = global.document.createElement( 'div' );
|
|
|
+ global.document.body.appendChild( editorElement );
|
|
|
+ warnMock = sinon.stub( window.console, 'warn' );
|
|
|
+
|
|
|
+ return ClassicTestEditor
|
|
|
+ .create( editorElement, {
|
|
|
+ plugins: [ Paragraph, Table, TableToolbar, FakeButton ],
|
|
|
+ table: {
|
|
|
+ toolbar: [ 'fake_button' ]
|
|
|
+ }
|
|
|
+ } )
|
|
|
+ .then( newEditor => {
|
|
|
+ editor = newEditor;
|
|
|
+
|
|
|
+ const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ const toolbarView = widgetToolbarRepository._toolbars.get( 'tableContent' ).view;
|
|
|
+
|
|
|
+ expect( toolbarView.items ).to.have.length( 1 );
|
|
|
+ expect( toolbarView.items.get( 0 ).label ).to.equal( 'fake button' );
|
|
|
+
|
|
|
+ sinon.assert.calledWith(
|
|
|
+ warnMock,
|
|
|
+ '`config.table.toolbar` is deprecated and will be removed in the next major release.' +
|
|
|
+ ' Use `config.table.contentToolbar` instead.'
|
|
|
+ );
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not show the toolbar on ui#update when the table is selected', () => {
|
|
|
- setData( model, '<paragraph>foo</paragraph>[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
+ it( 'table.contentToolbar should be used if both toolbars options are provided', () => {
|
|
|
+ editorElement = global.document.createElement( 'div' );
|
|
|
+ global.document.body.appendChild( editorElement );
|
|
|
+ warnMock = sinon.stub( window.console, 'warn' );
|
|
|
+
|
|
|
+ return ClassicTestEditor
|
|
|
+ .create( editorElement, {
|
|
|
+ plugins: [ Paragraph, Table, TableToolbar, FakeButton, FooButton ],
|
|
|
+ table: {
|
|
|
+ toolbar: [ 'fake_button' ],
|
|
|
+ contentToolbar: [ 'foo_button' ],
|
|
|
+ }
|
|
|
+ } )
|
|
|
+ .then( newEditor => {
|
|
|
+ editor = newEditor;
|
|
|
+
|
|
|
+ const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ const toolbarView = widgetToolbarRepository._toolbars.get( 'tableContent' ).view;
|
|
|
+
|
|
|
+ expect( toolbarView.items ).to.have.length( 1 );
|
|
|
+ expect( toolbarView.items.get( 0 ).label ).to.equal( 'foo button' );
|
|
|
+ } );
|
|
|
+ } );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ afterEach( () => {
|
|
|
+ editorElement.remove();
|
|
|
+
|
|
|
+ return editor.destroy();
|
|
|
} );
|
|
|
+ } );
|
|
|
|
|
|
- it( 'should show the toolbar on ui#update when the table content is selected', () => {
|
|
|
- setData(
|
|
|
- model,
|
|
|
- '<paragraph>[foo]</paragraph><table><tableRow><tableCell><paragraph>bar</paragraph></tableCell></tableRow></table>'
|
|
|
- );
|
|
|
+ describe( 'tableToolbar', () => {
|
|
|
+ let editor, element, widgetToolbarRepository, balloon, toolbar, model;
|
|
|
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ beforeEach( () => {
|
|
|
+ element = document.createElement( 'div' );
|
|
|
+ document.body.appendChild( element );
|
|
|
|
|
|
- editor.ui.fire( 'update' );
|
|
|
+ return ClassicTestEditor.create( element, {
|
|
|
+ plugins: [ Paragraph, Table, TableToolbar, FakeButton ],
|
|
|
+ table: {
|
|
|
+ tableToolbar: [ 'fake_button' ]
|
|
|
+ }
|
|
|
+ } ).then( _editor => {
|
|
|
+ editor = _editor;
|
|
|
+ widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ toolbar = widgetToolbarRepository._toolbars.get( 'table' ).view;
|
|
|
+ balloon = editor.plugins.get( 'ContextualBalloon' );
|
|
|
+ model = editor.model;
|
|
|
+ } );
|
|
|
+ } );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ afterEach( () => {
|
|
|
+ return editor.destroy()
|
|
|
+ .then( () => element.remove() );
|
|
|
+ } );
|
|
|
|
|
|
- model.change( writer => {
|
|
|
- // Select the <tableCell>[bar]</tableCell>
|
|
|
- writer.setSelection(
|
|
|
- Range.createOn( doc.getRoot().getChild( 1 ).getChild( 0 ).getChild( 0 ).getChild( 0 ) )
|
|
|
- );
|
|
|
+ describe( 'toolbar', () => {
|
|
|
+ it( 'should not initialize if there is no configuration', () => {
|
|
|
+ const editorElement = global.document.createElement( 'div' );
|
|
|
+ global.document.body.appendChild( editorElement );
|
|
|
+
|
|
|
+ return ClassicTestEditor.create( editorElement, {
|
|
|
+ plugins: [ TableToolbar ]
|
|
|
+ } )
|
|
|
+ .then( editor => {
|
|
|
+ const widgetToolbarRepository = editor.plugins.get( WidgetToolbarRepository );
|
|
|
+ expect( widgetToolbarRepository._toolbars.get( 'table' ) ).to.be.undefined;
|
|
|
+
|
|
|
+ editorElement.remove();
|
|
|
+ return editor.destroy();
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+ it( 'should use the config.table.tableWidget to create items', () => {
|
|
|
+ expect( toolbar.items ).to.have.length( 1 );
|
|
|
+ expect( toolbar.items.get( 0 ).label ).to.equal( 'fake button' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should set proper CSS classes', () => {
|
|
|
+ const spy = sinon.spy( balloon, 'add' );
|
|
|
+
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
|
|
|
- // Make sure successive change does not throw, e.g. attempting
|
|
|
- // to insert the toolbar twice.
|
|
|
- editor.ui.fire( 'update' );
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+ setData( model, '[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
+
|
|
|
+ sinon.assert.calledWithMatch( spy, {
|
|
|
+ view: toolbar,
|
|
|
+ balloonClassName: 'ck-toolbar-container'
|
|
|
+ } );
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should not engage when the toolbar is in the balloon yet invisible', () => {
|
|
|
- setData( model, '<table><tableRow><tableCell><paragraph>x[y]z</paragraph></tableCell></tableRow></table>' );
|
|
|
+ describe( 'integration with the editor focus', () => {
|
|
|
+ it( 'should show the toolbar when the editor gains focus and the table is selected', () => {
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+ setData( model, '[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
|
|
|
- // Put anything on top of the ContextualBalloon stack above the table toolbar.
|
|
|
- const lastView = new View();
|
|
|
- lastView.element = document.createElement( 'div' );
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
|
|
|
- balloon.add( {
|
|
|
- view: lastView,
|
|
|
- position: {
|
|
|
- target: document.body
|
|
|
- }
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
} );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+ it( 'should hide the toolbar when the editor loses focus and the table is selected', () => {
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
|
|
|
- editor.ui.fire( 'update' );
|
|
|
+ setData( model, '[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ editor.ui.focusTracker.isFocused = false;
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
} );
|
|
|
|
|
|
- it( 'should hide the toolbar on render if the table is de–selected', () => {
|
|
|
- setData(
|
|
|
- model,
|
|
|
- '<paragraph>foo</paragraph><table><tableRow><tableCell><paragraph>[]</paragraph></tableCell></tableRow></table>'
|
|
|
- );
|
|
|
+ describe( 'integration with the editor selection', () => {
|
|
|
+ beforeEach( () => {
|
|
|
+ editor.ui.focusTracker.isFocused = true;
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should show the toolbar on ui#update when the table widget is selected', () => {
|
|
|
+ setData( editor.model, '<paragraph>[foo]</paragraph><table><tableRow><tableCell></tableCell></tableRow></table>' );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
|
|
|
- model.change( writer => {
|
|
|
- // Select the <paragraph>[...]</paragraph>
|
|
|
- writer.setSelection(
|
|
|
- Range.createIn( doc.getRoot().getChild( 0 ) )
|
|
|
- );
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+
|
|
|
+ editor.model.change( writer => {
|
|
|
+ // Select the [<table></table>]
|
|
|
+ writer.setSelection( editor.model.document.getRoot().getChild( 1 ), 'on' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ // Make sure successive change does not throw, e.g. attempting
|
|
|
+ // to insert the toolbar twice.
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
} );
|
|
|
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ it( 'should not show the toolbar on ui#update when the selection is inside a table cell', () => {
|
|
|
+ setData( editor.model, '<table><tableRow><tableCell>[]</tableCell></tableRow></table>' );
|
|
|
|
|
|
- // Make sure successive change does not throw, e.g. attempting
|
|
|
- // to remove the toolbar twice.
|
|
|
- editor.ui.fire( 'update' );
|
|
|
- expect( balloon.visibleView ).to.be.null;
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should not engage when the toolbar is in the balloon yet invisible', () => {
|
|
|
+ setData( model, '<table><tableRow><tableCell></tableCell></tableRow></table>' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ const lastView = new View();
|
|
|
+ lastView.element = document.createElement( 'div' );
|
|
|
+
|
|
|
+ balloon.add( {
|
|
|
+ view: lastView,
|
|
|
+ position: {
|
|
|
+ target: document.body
|
|
|
+ }
|
|
|
+ } );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.equal( lastView );
|
|
|
+ } );
|
|
|
+
|
|
|
+ it( 'should hide the toolbar on ui#update if the table is de–selected', () => {
|
|
|
+ setData( model, '<paragraph>foo</paragraph>[<table><tableRow><tableCell></tableCell></tableRow></table>]' );
|
|
|
+ expect( balloon.visibleView ).to.equal( toolbar );
|
|
|
+
|
|
|
+ model.change( writer => {
|
|
|
+ // Select the <paragraph>[...]</paragraph>
|
|
|
+ writer.setSelection( model.document.getRoot().getChild( 0 ), 'in' );
|
|
|
+ } );
|
|
|
+
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+
|
|
|
+ // Make sure successive change does not throw, e.g. attempting
|
|
|
+ // to remove the toolbar twice.
|
|
|
+ editor.ui.fire( 'update' );
|
|
|
+ expect( balloon.visibleView ).to.be.null;
|
|
|
+ } );
|
|
|
} );
|
|
|
} );
|
|
|
+} );
|
|
|
|
|
|
- // Plugin that adds fake_button to editor's component factory.
|
|
|
- class FakeButton extends Plugin {
|
|
|
- init() {
|
|
|
- this.editor.ui.componentFactory.add( 'fake_button', locale => {
|
|
|
- const view = new ButtonView( locale );
|
|
|
+// Plugin that adds fake_button to editor's component factory.
|
|
|
+class FakeButton extends Plugin {
|
|
|
+ init() {
|
|
|
+ this.editor.ui.componentFactory.add( 'fake_button', locale => {
|
|
|
+ const view = new ButtonView( locale );
|
|
|
|
|
|
- view.set( {
|
|
|
- label: 'fake button'
|
|
|
- } );
|
|
|
+ view.set( {
|
|
|
+ label: 'fake button'
|
|
|
+ } );
|
|
|
|
|
|
- return view;
|
|
|
+ return view;
|
|
|
+ } );
|
|
|
+ }
|
|
|
+}
|
|
|
+
|
|
|
+// Plugin that adds foo_button to editor's component factory.
|
|
|
+class FooButton extends Plugin {
|
|
|
+ init() {
|
|
|
+ this.editor.ui.componentFactory.add( 'foo_button', locale => {
|
|
|
+ const view = new ButtonView( locale );
|
|
|
+
|
|
|
+ view.set( {
|
|
|
+ label: 'foo button'
|
|
|
} );
|
|
|
- }
|
|
|
+
|
|
|
+ return view;
|
|
|
+ } );
|
|
|
}
|
|
|
-} );
|
|
|
+}
|