8
0
فهرست منبع

Minor leftover fixes.

Maciej Gołaszewski 5 سال پیش
والد
کامیت
225ea0e39c

+ 0 - 2
packages/ckeditor5-engine/src/conversion/downcasthelpers.js

@@ -803,7 +803,6 @@ export function wrap( elementCreator ) {
  */
 export function insertElement( elementCreator ) {
 	return ( evt, data, conversionApi ) => {
-		// Create view structure:
 		const viewElement = elementCreator( data.item, conversionApi );
 
 		if ( !viewElement ) {
@@ -816,7 +815,6 @@ export function insertElement( elementCreator ) {
 
 		const viewPosition = conversionApi.mapper.toViewPosition( data.range.start );
 
-		// Rest of standard insertElement converter.
 		conversionApi.mapper.bindElements( data.item, viewElement );
 		conversionApi.writer.insert( viewPosition, viewElement );
 	};

+ 0 - 1
packages/ckeditor5-engine/src/model/differ.js

@@ -933,7 +933,6 @@ export default class Differ {
 			if ( inc.type === 'refresh' ) {
 				if ( old.type === 'insert' ) {
 					if ( inc.offset >= old.offset && inc.offset < oldEnd ) {
-						// if ( inc.offset === old.offset && inc.howMany === old.howMany ) {
 						inc.nodesToHandle = 0;
 					}
 				}

+ 18 - 18
packages/ckeditor5-image/tests/imageupload/imageuploadprogress.js

@@ -75,8 +75,8 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-appear ck-image-upload-placeholder ck-widget image" contenteditable="false">' +
-			`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
-			'<div class="ck-upload-placeholder-loader"></div>' +
+				`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
+				'<div class="ck-upload-placeholder-loader"></div>' +
 			'</figure>]<p>foo</p>'
 		);
 	} );
@@ -139,12 +139,12 @@ describe( 'ImageUploadProgress', () => {
 			try {
 				expect( getViewData( view ) ).to.equal(
 					'<outerBlock>' +
-					'<innerBlock>' +
-					'[<figure class="ck-appear ck-widget image" contenteditable="false">' +
-					`<img src="${ base64Sample }"></img>` +
-					'<div class="ck-progress-bar"></div>' +
-					'</figure>]' +
-					'</innerBlock>' +
+						'<innerBlock>' +
+							'[<figure class="ck-appear ck-widget image" contenteditable="false">' +
+								`<img src="${ base64Sample }"></img>` +
+								'<div class="ck-progress-bar"></div>' +
+							'</figure>]' +
+						'</innerBlock>' +
 					'</outerBlock>'
 				);
 
@@ -174,8 +174,8 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-appear ck-widget image" contenteditable="false">' +
-			'<img src="image.png"></img>' +
-			'<div class="ck-progress-bar"></div>' +
+				'<img src="image.png"></img>' +
+				'<div class="ck-progress-bar"></div>' +
 			'</figure>]'
 		);
 	} );
@@ -192,8 +192,8 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-appear ck-image-upload-placeholder ck-widget image" contenteditable="false">' +
-			`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
-			'<div class="ck-upload-placeholder-loader"></div>' +
+				`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
+				'<div class="ck-upload-placeholder-loader"></div>' +
 			'</figure>]'
 		);
 	} );
@@ -215,7 +215,7 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-widget image" contenteditable="false">' +
-			`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
+				`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
 			'</figure>]'
 		);
 	} );
@@ -289,8 +289,8 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-appear ck-image-upload-placeholder ck-widget image" contenteditable="false">' +
-			`<img src="${ base64Sample }"></img>` +
-			'<div class="ck-upload-placeholder-loader"></div>' +
+				`<img src="${ base64Sample }"></img>` +
+				'<div class="ck-upload-placeholder-loader"></div>' +
 			'</figure>]<p>foo</p>'
 		);
 	} );
@@ -319,8 +319,8 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-appear ck-image-upload-placeholder ck-widget image" contenteditable="false">' +
-			`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
-			'<div class="ck-upload-placeholder-loader"></div>' +
+				`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
+				'<div class="ck-upload-placeholder-loader"></div>' +
 			'</figure>]'
 		);
 
@@ -330,7 +330,7 @@ describe( 'ImageUploadProgress', () => {
 
 		expect( getViewData( view ) ).to.equal(
 			'[<figure class="ck-widget image" contenteditable="false">' +
-			`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
+				`<img src="data:image/svg+xml;utf8,${ imagePlaceholder }"></img>` +
 			'</figure>]'
 		);
 	} );

+ 0 - 3
packages/ckeditor5-table/tests/converters/table-cell-refresh-post-fixer.js

@@ -219,7 +219,6 @@ describe( 'Table cell refresh post-fixer', () => {
 		assertEqualMarkup( getViewData( view, { withoutSelection: true } ), viewTable( [
 			[ '<p foo="baz">00</p>' ]
 		], { asWidget: true } ) );
-		// False positive: should not be called.
 	} );
 
 	it( 'should keep <p> in the view when adding another attribute to a <paragraph> with other attributes', () => {
@@ -234,7 +233,6 @@ describe( 'Table cell refresh post-fixer', () => {
 		assertEqualMarkup( getViewData( view, { withoutSelection: true } ), viewTable( [
 			[ '<p bar="bar" foo="bar">00</p>' ]
 		], { asWidget: true } ) );
-		// False positive: should not be called.
 	} );
 
 	it( 'should keep <p> in the view when adding another attribute to a <paragraph> and removing attribute that is already set', () => {
@@ -250,7 +248,6 @@ describe( 'Table cell refresh post-fixer', () => {
 		assertEqualMarkup( getViewData( view, { withoutSelection: true } ), viewTable( [
 			[ '<p bar="bar">00</p>' ]
 		], { asWidget: true } ) );
-		// False positive: should not be called.
 	} );
 
 	it( 'should keep <p> in the view when <paragraph> attribute value is changed (table cell with multiple blocks)', () => {

+ 2 - 2
packages/ckeditor5-table/tests/tableclipboard-paste.js

@@ -2731,8 +2731,8 @@ describe( 'table clipboard', () => {
 					/* eslint-disable no-multi-spaces */
 					assertSelectedCells( model, [
 						[ 1, 1, 1, 1 ],
-						[ 1, 1 ],
-						[ 1, 1 ],
+						[ 1,       1 ],
+						[       1, 1 ],
 						[ 0, 0, 0, 0 ]
 					] );
 					/* eslint-enable no-multi-spaces */