Procházet zdrojové kódy

Changed: Button icon should have own class name set.

Maciej Gołaszewski před 8 roky
rodič
revize
2080bffe40

+ 6 - 0
packages/ckeditor5-ui/src/button/buttonview.js

@@ -151,6 +151,12 @@ export default class ButtonView extends View {
 
 			iconView.bind( 'content' ).to( this, 'icon' );
 
+			iconView.extendTemplate( {
+				attributes: {
+					class: 'ck-button__icon'
+				}
+			} );
+
 			this.children.add( iconView );
 		}
 

+ 1 - 0
packages/ckeditor5-ui/tests/button/buttonview.js

@@ -248,6 +248,7 @@ describe( 'ButtonView', () => {
 
 			expect( view.iconView ).to.instanceOf( IconView );
 			expect( view.iconView.content ).to.equal( '<svg></svg>' );
+			expect( view.iconView.element.classList.contains( 'ck-button__icon' ) ).to.be.true;
 
 			view.icon = '<svg>bar</svg>';
 			expect( view.iconView.content ).to.equal( '<svg>bar</svg>' );

+ 1 - 1
packages/ckeditor5-ui/theme/components/button/mixins/_button.css

@@ -7,7 +7,7 @@
  * A helper to define button–specific icon styles.
  */
 @define-mixin ck-button-icon {
-	& .ck-icon:first-child {
+	& .ck-button__icon {
 		@mixin-content;
 	}
 }