Sfoglia il codice sorgente

Removed obsolete Region class.

Aleksander Nowodziński 9 anni fa
parent
commit
2005512c20
2 ha cambiato i file con 0 aggiunte e 217 eliminazioni
  1. 0 77
      packages/ckeditor5-ui/src/region.js
  2. 0 140
      packages/ckeditor5-ui/tests/region.js

+ 0 - 77
packages/ckeditor5-ui/src/region.js

@@ -1,77 +0,0 @@
-/**
- * @license Copyright (c) 2003-2016, CKSource - Frederico Knabben. All rights reserved.
- * For licensing, see LICENSE.md.
- */
-
-import Collection from '../utils/collection.js';
-
-/**
- * Basic Region class.
- *
- * @memberOf ui
- */
-export default class Region {
-	/**
-	 * Creates an instance of the {@link ui.Region} class.
-	 *
-	 * @param {String} name The name of the Region.
-	 */
-	constructor( name ) {
-		/**
-		 * The name of the region.
-		 *
-		 * @member {String} ui.Region#name
-		 */
-		this.name = name;
-
-		/**
-		 * Views which belong to the region.
-		 *
-		 * @member {utils.Collection} ui.Region#views
-		 */
-		this.views = new Collection();
-
-		/**
-		 * Element of this region (see {@link #init}).
-		 *
-		 * @member {HTMLElement} ui.Region#element
-		 */
-		this.element = null;
-	}
-
-	/**
-	 * Initializes region instance with an element. Usually it comes from {@link View#init}.
-	 *
-	 * @param {HTMLElement} regionElement Element of this region.
-	 */
-	init( regionElement ) {
-		this.element = regionElement;
-
-		if ( regionElement ) {
-			this.views.on( 'add', ( evt, childView, index ) => {
-				regionElement.insertBefore( childView.element, regionElement.childNodes[ index ] );
-			} );
-
-			this.views.on( 'remove', ( evt, childView ) => {
-				childView.element.remove();
-			} );
-		}
-	}
-
-	/**
-	 * Destroys region instance.
-	 */
-	destroy() {
-		if ( this.element ) {
-			for ( let view of this.views ) {
-				view.element.remove();
-				this.views.remove( view );
-			}
-		}
-
-		// Drop the reference to HTMLElement but don't remove it from DOM.
-		// Element comes as a parameter and it could be a part of the View.
-		// Then it's up to the View what to do with it when the View is destroyed.
-		this.element = this.views = null;
-	}
-}

+ 0 - 140
packages/ckeditor5-ui/tests/region.js

@@ -1,140 +0,0 @@
-/**
- * @license Copyright (c) 2003-2016, CKSource - Frederico Knabben. All rights reserved.
- * For licensing, see LICENSE.md.
- */
-
-/* global document */
-/* bender-tags: ui */
-
-import Region from 'ckeditor5/ui/region.js';
-import View from 'ckeditor5/ui/view.js';
-import Template from 'ckeditor5/ui/template.js';
-
-let TestViewA, TestViewB;
-let region, el;
-
-describe( 'View', () => {
-	beforeEach( createRegionInstance );
-
-	describe( 'constructor()', () => {
-		it( 'accepts name', () => {
-			expect( region.name ).to.be.equal( 'foo' );
-			expect( region.element ).to.be.null;
-			expect( region.views.length ).to.be.equal( 0 );
-		} );
-	} );
-
-	describe( 'init()', () => {
-		it( 'accepts region element', () => {
-			region.init( el );
-
-			expect( region.element ).to.be.equal( el );
-		} );
-	} );
-
-	describe( 'views collection', () => {
-		it( 'updates DOM when adding views', () => {
-			let view;
-
-			region.init( el );
-
-			expect( region.element.childNodes.length ).to.be.equal( 0 );
-
-			view = new TestViewA();
-			region.views.add( view, 0 );
-			expect( region.element.childNodes.length ).to.be.equal( 1 );
-
-			region.views.add( new TestViewA() );
-			expect( region.element.childNodes.length ).to.be.equal( 2 );
-
-			view = new TestViewA();
-			region.views.add( view, 1 );
-			expect( region.element.childNodes.length ).to.be.equal( 3 );
-			expect( region.element.childNodes[ 1 ] ).to.equal( view.element );
-
-			view = new TestViewA();
-			region.views.add( view, 0 );
-			expect( region.element.childNodes.length ).to.be.equal( 4 );
-			expect( region.element.childNodes[ 0 ] ).to.equal( view.element );
-		} );
-
-		it( 'does not update DOM when no region element', () => {
-			region.init();
-
-			expect( () => {
-				region.views.add( new TestViewA() );
-				region.views.add( new TestViewA() );
-			} ).to.not.throw();
-		} );
-
-		it( 'updates DOM when removing views', () => {
-			region.init( el );
-
-			let viewA = new TestViewA();
-			let viewB = new TestViewB();
-
-			region.views.add( viewA );
-			region.views.add( viewB );
-
-			expect( el.childNodes.length ).to.be.equal( 2 );
-			expect( el.firstChild.nodeName ).to.be.equal( 'A' );
-			expect( el.lastChild.nodeName ).to.be.equal( 'B' );
-
-			region.views.remove( viewA );
-			expect( el.childNodes.length ).to.be.equal( 1 );
-			expect( el.firstChild.nodeName ).to.be.equal( 'B' );
-
-			region.views.remove( viewB );
-			expect( el.childNodes.length ).to.be.equal( 0 );
-		} );
-	} );
-
-	describe( 'destroy()', () => {
-		it( 'destroys the region', () => {
-			region.init( el );
-			region.views.add( new TestViewA() );
-
-			const elRef = region.element;
-			const viewsRef = region.views;
-
-			region.destroy();
-
-			expect( elRef.parentNode ).to.be.null;
-			expect( region.name ).to.be.equal( 'foo' );
-			expect( region.views ).to.be.null;
-			expect( viewsRef.length ).to.be.equal( 0 );
-			expect( region.element ).to.be.null;
-		} );
-
-		it( 'destroys an element–less region', () => {
-			region.init();
-
-			expect( () => {
-				region.destroy();
-			} ).to.not.throw();
-		} );
-	} );
-} );
-
-function createRegionInstance() {
-	class A extends View {
-		constructor() {
-			super();
-			this.template = new Template( { tag: 'a' } );
-		}
-	}
-
-	class B extends View {
-		constructor() {
-			super();
-			this.template = new Template( { tag: 'b' } );
-		}
-	}
-
-	TestViewA = A;
-	TestViewB = B;
-
-	el = document.createElement( 'div' );
-
-	region = new Region( 'foo' );
-}