Przeglądaj źródła

Docs: Minor improvements.

Kamil Piechaczek 8 lat temu
rodzic
commit
1f6015a5c3

+ 2 - 1
packages/ckeditor5-core/src/plugincollection.js

@@ -84,6 +84,7 @@ export default class PluginCollection {
 		const loaded = [];
 
 		// Plugins which should be remove can be the constructors or plugin names.
+		// We need to unify this because we are supporting loading plugins by names or plugin constructors.
 		removePlugins = removePlugins.reduce( ( arr, PluginConstructorOrName ) => {
 			arr.push( PluginConstructorOrName );
 
@@ -100,7 +101,7 @@ export default class PluginCollection {
 			.then( () => loaded );
 
 		function loadPlugin( PluginConstructorOrName ) {
-			// Don't load the plugin if it should be removed.
+			// Don't load the plugin if it cannot be loaded.
 			if ( removePlugins.includes( PluginConstructorOrName ) ) {
 				return;
 			}

+ 3 - 3
packages/ckeditor5-core/tests/plugincollection.js

@@ -276,7 +276,7 @@ describe( 'PluginCollection', () => {
 				} );
 		} );
 
-		it( 'should load allowed plugins (plugins are constructors, removedPlugins are plugin names)', () => {
+		it( 'should load allowed plugins (plugins are constructors, removedPlugins are names)', () => {
 			let plugins = new PluginCollection( editor, availablePlugins );
 
 			return plugins.load( [ PluginA, PluginB, PluginC ], [ 'A' ] )
@@ -288,7 +288,7 @@ describe( 'PluginCollection', () => {
 				} );
 		} );
 
-		it( 'should load allowed plugins (plugins and removedPlugins are plugin names)', () => {
+		it( 'should load allowed plugins (plugins and removedPlugins are names)', () => {
 			let plugins = new PluginCollection( editor, availablePlugins );
 
 			return plugins.load( [ 'A', 'B', 'C' ], [ 'A' ] )
@@ -300,7 +300,7 @@ describe( 'PluginCollection', () => {
 				} );
 		} );
 
-		it( 'should load allowed plugins (plugins are plugin names, removedPlugins are constructors)', () => {
+		it( 'should load allowed plugins (plugins are names, removedPlugins are constructors)', () => {
 			let plugins = new PluginCollection( editor, availablePlugins );
 
 			return plugins.load( [ 'A', 'B', 'C' ], [ PluginA ] )