Ver Fonte

Removed TODOs.

Maciej Bukowski há 8 anos atrás
pai
commit
1eb46d8ba8

+ 1 - 1
packages/ckeditor5-engine/src/view/range.js

@@ -449,7 +449,7 @@ export default class Range {
 	}
 	}
 }
 }
 
 
-// Function used by getEnlagred and getTrimmed methods.
+// Function used by getEnlarged and getTrimmed methods.
 function enlargeTrimSkip( value ) {
 function enlargeTrimSkip( value ) {
 	if ( value.item.is( 'attributeElement' ) || value.item.is( 'uiElement' ) ) {
 	if ( value.item.is( 'attributeElement' ) || value.item.is( 'uiElement' ) ) {
 		return true;
 		return true;

+ 6 - 8
packages/ckeditor5-engine/tests/model/range.js

@@ -177,27 +177,25 @@ describe( 'Range', () => {
 		} );
 		} );
 
 
 		describe( 'createCollapsedAt()', () => {
 		describe( 'createCollapsedAt()', () => {
-			it( 'should return new collapse range at the given item position and offset', () => {
+			it( 'should return new collapsed range at the given item position', () => {
 				const item = new Element( 'p', null, new Text( 'foo' ) );
 				const item = new Element( 'p', null, new Text( 'foo' ) );
-				const range = Range.createCollapsedAt( item, 1 );
+				const range = Range.createCollapsedAt( item );
 
 
 				expect( range.start.parent ).to.equal( item );
 				expect( range.start.parent ).to.equal( item );
-				expect( range.start.offset ).to.equal( 1 );
+				expect( range.start.offset ).to.equal( 0 );
 
 
 				expect( range.isCollapsed ).to.be.true;
 				expect( range.isCollapsed ).to.be.true;
 			} );
 			} );
 
 
-			it( 'should return new collapsed range at the given item position', () => {
+			it( 'should return new collapse range at the given item position and offset', () => {
 				const item = new Element( 'p', null, new Text( 'foo' ) );
 				const item = new Element( 'p', null, new Text( 'foo' ) );
-				const range = Range.createCollapsedAt( item );
+				const range = Range.createCollapsedAt( item, 1 );
 
 
 				expect( range.start.parent ).to.equal( item );
 				expect( range.start.parent ).to.equal( item );
-				expect( range.start.offset ).to.equal( 0 );
+				expect( range.start.offset ).to.equal( 1 );
 
 
 				expect( range.isCollapsed ).to.be.true;
 				expect( range.isCollapsed ).to.be.true;
 			} );
 			} );
-
-			// TODO - TextProxy
 		} );
 		} );
 
 
 		describe( 'createFromParentsAndOffsets()', () => {
 		describe( 'createFromParentsAndOffsets()', () => {

+ 6 - 8
packages/ckeditor5-engine/tests/view/range.js

@@ -676,27 +676,25 @@ describe( 'Range', () => {
 		} );
 		} );
 
 
 		describe( 'createCollapsedAt()', () => {
 		describe( 'createCollapsedAt()', () => {
-			it( 'should return new collapse range at the given item position and offset', () => {
+			it( 'should return new collapsed range at the given item position', () => {
 				const item = new Element( 'p', null, new Text( 'foo' ) );
 				const item = new Element( 'p', null, new Text( 'foo' ) );
-				const range = Range.createCollapsedAt( item, 1 );
+				const range = Range.createCollapsedAt( item );
 
 
 				expect( range.start.parent ).to.equal( item );
 				expect( range.start.parent ).to.equal( item );
-				expect( range.start.offset ).to.equal( 1 );
+				expect( range.start.offset ).to.equal( 0 );
 
 
 				expect( range.isCollapsed ).to.be.true;
 				expect( range.isCollapsed ).to.be.true;
 			} );
 			} );
 
 
-			it( 'should return new collapsed range at the given item position', () => {
+			it( 'should return new collapse range at the given item position and offset', () => {
 				const item = new Element( 'p', null, new Text( 'foo' ) );
 				const item = new Element( 'p', null, new Text( 'foo' ) );
-				const range = Range.createCollapsedAt( item );
+				const range = Range.createCollapsedAt( item, 1 );
 
 
 				expect( range.start.parent ).to.equal( item );
 				expect( range.start.parent ).to.equal( item );
-				expect( range.start.offset ).to.equal( 0 );
+				expect( range.start.offset ).to.equal( 1 );
 
 
 				expect( range.isCollapsed ).to.be.true;
 				expect( range.isCollapsed ).to.be.true;
 			} );
 			} );
-
-			// TODO - TextProxy
 		} );
 		} );
 
 
 		describe( 'createFromParentsAndOffsets', () => {
 		describe( 'createFromParentsAndOffsets', () => {