8
0
Просмотр исходного кода

Tests: Added tests for DropdownView#id.

Aleksander Nowodzinski 5 лет назад
Родитель
Сommit
158089044f

+ 0 - 9
packages/ckeditor5-ui/src/dropdown/dropdownview.js

@@ -139,15 +139,6 @@ export default class DropdownView extends View {
 		this.set( 'id' );
 
 		/**
-		 * Set to `true` when the field has some error. Usually controlled via
-		 * {@link module:ui/labeledview/labeledview~LabeledView#errorText}.
-		 *
-		 * @observable
-		 * @member {Boolean} #hasError
-		 */
-		this.set( 'hasError', false );
-
-		/**
 		 * The position of the panel, relative to the dropdown.
 		 *
 		 * **Note**: When `'auto'`, the panel will use one of the remaining positions to stay

+ 15 - 0
packages/ckeditor5-ui/tests/dropdown/dropdownview.js

@@ -60,6 +60,14 @@ describe( 'DropdownView', () => {
 			expect( view.isEnabled ).to.be.true;
 		} );
 
+		it( 'sets view#class', () => {
+			expect( view.class ).to.be.undefined;
+		} );
+
+		it( 'sets view#id', () => {
+			expect( view.id ).to.be.undefined;
+		} );
+
 		it( 'sets view#panelPosition "auto"', () => {
 			expect( view.panelPosition ).to.equal( 'auto' );
 		} );
@@ -180,6 +188,13 @@ describe( 'DropdownView', () => {
 						expect( view.element.classList.contains( 'custom-css-class' ) ).to.be.true;
 					} );
 				} );
+
+				describe( 'id', () => {
+					it( 'reacts on view#id', () => {
+						view.id = 'foo';
+						expect( view.element.id ).to.equal( 'foo' );
+					} );
+				} );
 			} );
 		} );
 	} );