Browse Source

Internal (ckeditor5): Adjusted breaking change commment for is() method changes.

Marek Lewandowski 5 years ago
parent
commit
150ae25e3e
1 changed files with 1 additions and 2 deletions
  1. 1 2
      CHANGELOG.md

+ 1 - 2
CHANGELOG.md

@@ -37,8 +37,7 @@ The CKEditor 5 Collaboration features changelog can be found here: https://ckedi
 
 * **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: The `DomConverter#getParentUIElement()` method was renamed to `DomConverter#getHostViewElement()` because now it supports both `UIElement` and `RawElement` (see [#4469](https://github.com/ckeditor/ckeditor5/issues/4469)).
 * **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: Changed expected argument for model's and view's [`Text#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_model_text-Text.html#function-is) and [`TextProxy#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_model_textproxy-TextProxy.html#function-is) methods (`'text'` replaced with `'$text'` and `'textProxy'` replaced with `'$textProxy'`).
-* **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: Changed expected arguments for model's `Element#is()`, `Text#is()` and `TextProxy#is()` (the element name is no longer accepted as a first argument, type argument is required for name checks).
-* **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: Changed expected arguments for view's `Element#is()`, `Text#is()`, `TextProxy#is()`, `AttributeElement#is()`, `ContainerElement#is()`, `EditableElement#is()`, `EmptyElement#is()`, `UIElement#is()` (the element name is no longer accepted as a first argument, type argument is required for name checks).
+* **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: Model's and view's `is()` method (e.g. [`Element#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_model_element-Element.html#function-is), [`Text#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_model_text-Text.html#function-is), [`AttributeElement#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_view_attributeelement-AttributeElement.html#function-is) or [`ContainerElement#is()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_engine_view_containerelement-ContainerElement.html#function-is)) no longer treats the first argument as a name. To check the element's name use the second argument instead.
 * **[engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine)**: Marker conversion has changed. As a result, names with a `,` (comma) character are now disallowed. See the GitHub issue for an [example migration path](https://github.com/ckeditor/ckeditor5/issues/7556#issuecomment-665579653).
 * The method `editor.setData()` clears the undo and redo stacks.