浏览代码

Fix and add test to have coverage on 100%.

Mateusz Samsel 6 年之前
父节点
当前提交
1230937d69

+ 1 - 1
packages/ckeditor5-engine/src/model/history.js

@@ -106,7 +106,7 @@ export default class History {
 	 * @returns {Boolean}
 	 */
 	is( type ) {
-		return type == 'history' || type == 'mdoel:history';
+		return type == 'history' || type == 'model:history';
 	}
 
 	/**

+ 15 - 0
packages/ckeditor5-engine/tests/view/domconverter/domconverter.js

@@ -34,6 +34,21 @@ describe( 'DomConverter', () => {
 		} );
 	} );
 
+	describe( 'is()', () => {
+		it( 'should return true for "domConverter"', () => {
+			expect( converter.is( 'domConverter' ) ).to.be.true;
+			expect( converter.is( 'view:domConverter' ) ).to.be.true;
+		} );
+
+		it( 'should return false for incorrect values', () => {
+			expect( converter.is( 'view' ) ).to.be.false;
+			expect( converter.is( 'model:domConverter' ) ).to.be.false;
+			expect( converter.is( 'node' ) ).to.be.false;
+			expect( converter.is( 'view:node' ) ).to.be.false;
+			expect( converter.is( 'element', 'text' ) ).to.be.false;
+		} );
+	} );
+
 	describe( 'focus()', () => {
 		let viewEditable, domEditable, domEditableParent, viewDocument;
 

+ 23 - 0
packages/ckeditor5-engine/tests/view/downcastwriter/is.js

@@ -0,0 +1,23 @@
+import DowncastWriter from '../../../src/view/downcastwriter';
+import Document from '../../../src/view/document';
+
+describe( 'is()', () => {
+	let writer;
+
+	before( () => {
+		writer = new DowncastWriter( new Document() );
+	} );
+
+	it( 'should return true for "downcastWriter"', () => {
+		expect( writer.is( 'downcastWriter' ) ).to.be.true;
+		expect( writer.is( 'view:downcastWriter' ) ).to.be.true;
+	} );
+
+	it( 'should return false for incorrect values', () => {
+		expect( writer.is( 'view' ) ).to.be.false;
+		expect( writer.is( 'model:downcastWriter' ) ).to.be.false;
+		expect( writer.is( 'node' ) ).to.be.false;
+		expect( writer.is( 'view:node' ) ).to.be.false;
+		expect( writer.is( 'element', 'text' ) ).to.be.false;
+	} );
+} );

+ 1 - 1
packages/ckeditor5-engine/tests/view/treewalker.js

@@ -74,7 +74,7 @@ describe( 'TreeWalker', () => {
 		let treeWalker;
 
 		beforeEach( () => {
-			treeWalker = new TreeWalker();
+			treeWalker = new TreeWalker( { startPosition: rootBeginning } );
 		} );
 
 		it( 'should return true for "treeWalker"', () => {

+ 14 - 0
packages/ckeditor5-engine/tests/view/view/view.js

@@ -488,6 +488,20 @@ describe( 'view', () => {
 		} );
 	} );
 
+	describe( 'is()', () => {
+		it( 'should return true for "view"', () => {
+			expect( view.is( 'view' ) ).to.be.true;
+		} );
+
+		it( 'should return false for incorrect values', () => {
+			expect( view.is( 'model' ) ).to.be.false;
+			expect( view.is( 'model:document' ) ).to.be.false;
+			expect( view.is( 'node' ) ).to.be.false;
+			expect( view.is( 'view:node' ) ).to.be.false;
+			expect( view.is( 'element', 'text' ) ).to.be.false;
+		} );
+	} );
+
 	describe( 'isFocused', () => {
 		it( 'should change renderer.isFocused too', () => {
 			expect( viewDocument.isFocused ).to.equal( false );