Parcourir la source

Changed: Make upcasting empty table more explicit.

Maciej Gołaszewski il y a 7 ans
Parent
commit
108c6a42ec
1 fichiers modifiés avec 4 ajouts et 4 suppressions
  1. 4 4
      packages/ckeditor5-table/src/converters/upcasttable.js

+ 4 - 4
packages/ckeditor5-table/src/converters/upcasttable.js

@@ -47,7 +47,10 @@ export default function upcastTable() {
 			conversionApi.writer.insert( table, splitResult.position );
 			conversionApi.consumable.consume( viewTable, { name: true } );
 
-			if ( !rows.length ) {
+			if ( rows.length ) {
+				// Upcast table rows in proper order (heading rows first).
+				rows.forEach( row => conversionApi.convertItem( row, ModelPosition.createAt( table, 'end' ) ) );
+			} else {
 				// Create one row and one table cell for empty table.
 				const row = conversionApi.writer.createElement( 'tableRow' );
 
@@ -55,9 +58,6 @@ export default function upcastTable() {
 				conversionApi.writer.insertElement( 'tableCell', ModelPosition.createAt( row, 'end' ) );
 			}
 
-			// Upcast table rows in proper order (heading rows first).
-			rows.forEach( row => conversionApi.convertItem( row, ModelPosition.createAt( table, 'end' ) ) );
-
 			// Set conversion result range.
 			data.modelRange = new ModelRange(
 				// Range should start before inserted element